4:24 a.m.
From: kernel test robot <lkp(a)intel.com>
fs/ext4/inline.c:997:3-6: WARNING: Use BUG_ON
Use BUG_ON instead of a if condition followed by BUG.
Semantic patch information:
This makes an effort to find cases where BUG() follows an if
condition on an expression and replaces the if condition and BUG()
with a BUG_ON having the conditional expression of the if statement
as argument.
Generated by: scripts/coccinelle/misc/bugon.cocci
Fixes: 8214bf079208 ("scripts/dtc: Export YYLOC global declaration")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: dd54b61f1458c03f68fc019b4874d98f2f0ae3a5
commit: 8214bf079208b146e63cd0a3ce0ed335a87ce7b3 [396/1051] scripts/dtc: Export YYLOC
global declaration
:::::: branch date: 5 weeks ago
:::::: commit date: 3 months ago
Please take the patch only if it's a positive warning. Thanks!
inline.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -992,9 +992,7 @@ void ext4_show_inline_dir(struct inode *
trace_printk("de: off %u rlen %u name %*.s nlen %u ino %u\n",
offset, de_len, de->name_len, de->name,
de->name_len, le32_to_cpu(de->inode));
- if (ext4_check_dir_entry(dir, NULL, de, bh,
- inline_start, inline_size, offset))
- BUG();
+ BUG_ON(ext4_check_dir_entry(dir, NULL, de, bh, inline_start, inline_size, offset));
offset += de_len;
de = (struct ext4_dir_entry_2 *) ((char *) de + de_len);