I have pushed a fix for this warning, to declare this function as static,
to the v2alpha branch and the tag:
$ git diff
diff --git a/net/ipv4/tcp_bbr2.c b/net/ipv4/tcp_bbr2.c
index 87f0c38fbcc4..5510adc92bbb 100644
--- a/net/ipv4/tcp_bbr2.c
+++ b/net/ipv4/tcp_bbr2.c
@@ -2231,7 +2231,7 @@ static bool bbr2_fast_path(struct sock *sk, bool
*update_model,
return false;
}
-void bbr2_main(struct sock *sk, const struct rate_sample *rs)
+static void bbr2_main(struct sock *sk, const struct rate_sample *rs)
{
struct tcp_sock *tp = tcp_sk(sk);
struct bbr *bbr = inet_csk_ca(sk);
neal
On Mon, Feb 8, 2021 at 11:54 PM kernel test robot <lkp(a)intel.com> wrote:
tree:
https://github.com/zen-kernel/zen-kernel 5.10/master
head: a2b0fa0a0d28e152d16d20389a8026713ae2b753
commit: 4ee004a30d45cec170d7c5d176068a9a2885d0bb [1131/1926] net-tcp_bbr:
v2: BBRv2 ("bbr2") congestion control for Linux TCP
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/zen-kernel/zen-kernel/commit/4ee004a30d45cec170d7c5d17...
git remote add zen-kernel-zen-kernel
https://github.com/zen-kernel/zen-kernel
git fetch --no-tags zen-kernel-zen-kernel 5.10/master
git checkout 4ee004a30d45cec170d7c5d176068a9a2885d0bb
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv4/tcp_bbr2.c:2242:6: warning: no previous prototype for
'bbr2_main' [-Wmissing-prototypes]
2242 | void bbr2_main(struct sock *sk, const struct rate_sample *rs)
| ^~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC &&
SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC
&& SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND &&
SND_SOC &&
SND_ATMEL_SOC && ATMEL_SSC
vim +/bbr2_main +2242 net/ipv4/tcp_bbr2.c
2241
> 2242 void bbr2_main(struct sock *sk, const struct rate_sample *rs)
2243 {
2244 struct tcp_sock *tp = tcp_sk(sk);
2245 struct bbr *bbr = inet_csk_ca(sk);
2246 struct bbr_context ctx = { 0 };
2247 bool update_model = true;
2248 u32 bw;
2249
2250 bbr->debug.event = '.'; /* init to default NOP (no event
yet) */
2251
2252 bbr_update_round_start(sk, rs, &ctx);
2253 if (bbr->round_start) {
2254 bbr->rounds_since_probe =
2255 min_t(s32, bbr->rounds_since_probe + 1,
0xFF);
2256 bbr2_update_ecn_alpha(sk);
2257 }
2258
2259 bbr->ecn_in_round |= rs->is_ece;
2260 bbr_calculate_bw_sample(sk, rs, &ctx);
2261
2262 if (bbr2_fast_path(sk, &update_model, rs, &ctx))
2263 goto out;
2264
2265 if (update_model)
2266 bbr2_update_model(sk, rs, &ctx);
2267
2268 bbr_update_gains(sk);
2269 bw = bbr_bw(sk);
2270 bbr_set_pacing_rate(sk, bw, bbr->pacing_gain);
2271 bbr_set_cwnd(sk, rs, rs->acked_sacked, bw, bbr->cwnd_gain,
2272 tp->snd_cwnd, &ctx);
2273 bbr2_bound_cwnd_for_inflight_model(sk);
2274
2275 out:
2276 bbr->prev_ca_state = inet_csk(sk)->icsk_ca_state;
2277 bbr->loss_in_cycle |= rs->lost > 0;
2278 bbr->ecn_in_cycle |= rs->delivered_ce > 0;
2279
2280 bbr_debug(sk, rs->acked_sacked, rs, &ctx);
2281 }
2282
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org