5:18 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
for-5.13/block
head: 3212135a718b06be38811f2d9a320ae842e76409
commit: d3c4a43d9291279c28b26757351a6ab72c110753 [23/30] block: refactor
blk_drop_partitions
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
> fs/block_dev.c:1281:9: warning: Uninitialized variable: ret
[uninitvar]
return ret;
^
vim +1281 fs/block_dev.c
37be41241f4310 NeilBrown 2006-12-08 1235
142fe8f4bb169e Christoph Hellwig 2019-11-14 1236 int bdev_disk_changed(struct
block_device *bdev, bool invalidate)
a1548b674403c0 Christoph Hellwig 2019-11-14 1237 {
142fe8f4bb169e Christoph Hellwig 2019-11-14 1238 struct gendisk *disk =
bdev->bd_disk;
a1548b674403c0 Christoph Hellwig 2019-11-14 1239 int ret;
a1548b674403c0 Christoph Hellwig 2019-11-14 1240
f0b870df80bc70 Christoph Hellwig 2019-11-14 1241
lockdep_assert_held(&bdev->bd_mutex);
f0b870df80bc70 Christoph Hellwig 2019-11-14 1242
38430f0876fa8b Christoph Hellwig 2020-09-21 1243 clear_bit(GD_NEED_PART_SCAN,
&bdev->bd_disk->state);
6540fbf6b63407 Christoph Hellwig 2020-09-01 1244
a1548b674403c0 Christoph Hellwig 2019-11-14 1245 rescan:
d3c4a43d929127 Christoph Hellwig 2021-04-06 1246 if (bdev->bd_part_count)
d3c4a43d929127 Christoph Hellwig 2021-04-06 1247 return -EBUSY;
d3c4a43d929127 Christoph Hellwig 2021-04-06 1248 sync_blockdev(bdev);
d3c4a43d929127 Christoph Hellwig 2021-04-06 1249 invalidate_bdev(bdev);
d3c4a43d929127 Christoph Hellwig 2021-04-06 1250 blk_drop_partitions(disk);
a1548b674403c0 Christoph Hellwig 2019-11-14 1251
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1252 /*
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1253 * Historically we only set the
capacity to zero for devices that
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1254 * support partitions (independ of
actually having partitions created).
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1255 * Doing that is rather inconsistent,
but changing it broke legacy
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1256 * udisks polling for legacy ide-cdrom
devices. Use the crude check
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1257 * below to get the sane behavior for
most device while not breaking
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1258 * userspace for this particular
setup.
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1259 */
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1260 if (invalidate) {
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1261 if (disk_part_scan_enabled(disk) ||
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1262 !(disk->flags &
GENHD_FL_REMOVABLE))
a1548b674403c0 Christoph Hellwig 2019-11-14 1263 set_capacity(disk, 0);
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1264 } else {
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1265 if
(disk->fops->revalidate_disk)
a1548b674403c0 Christoph Hellwig 2019-11-14 1266
disk->fops->revalidate_disk(disk);
d981cb5b9fa0da Christoph Hellwig 2020-03-18 1267 }
a1548b674403c0 Christoph Hellwig 2019-11-14 1268
142fe8f4bb169e Christoph Hellwig 2019-11-14 1269 if (get_capacity(disk)) {
142fe8f4bb169e Christoph Hellwig 2019-11-14 1270 ret = blk_add_partitions(disk,
bdev);
142fe8f4bb169e Christoph Hellwig 2019-11-14 1271 if (ret == -EAGAIN)
142fe8f4bb169e Christoph Hellwig 2019-11-14 1272 goto rescan;
490547ca2df66b Eric Biggers 2019-12-02 1273 } else if (invalidate) {
a1548b674403c0 Christoph Hellwig 2019-11-14 1274 /*
a1548b674403c0 Christoph Hellwig 2019-11-14 1275 * Tell userspace that the media /
partition table may have
a1548b674403c0 Christoph Hellwig 2019-11-14 1276 * changed.
a1548b674403c0 Christoph Hellwig 2019-11-14 1277 */
a1548b674403c0 Christoph Hellwig 2019-11-14 1278
kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE);
a1548b674403c0 Christoph Hellwig 2019-11-14 1279 }
a1548b674403c0 Christoph Hellwig 2019-11-14 1280
a1548b674403c0 Christoph Hellwig 2019-11-14 @1281 return ret;
a1548b674403c0 Christoph Hellwig 2019-11-14 1282 }
f0b870df80bc70 Christoph Hellwig 2019-11-14 1283 /*
3d742d4b6ebb33 Randy Dunlap 2021-02-24 1284 * Only exported for loop and dasd for
historic reasons. Don't use in new
f0b870df80bc70 Christoph Hellwig 2019-11-14 1285 * code!
f0b870df80bc70 Christoph Hellwig 2019-11-14 1286 */
f0b870df80bc70 Christoph Hellwig 2019-11-14 1287 EXPORT_SYMBOL_GPL(bdev_disk_changed);
a1548b674403c0 Christoph Hellwig 2019-11-14 1288
:::::: The code at line 1281 was first introduced by commit
:::::: a1548b674403c0de70cc29a1575689917ba60157 block: move rescan_partitions to
fs/block_dev.c
:::::: TO: Christoph Hellwig <hch(a)lst.de>
:::::: CC: Jens Axboe <axboe(a)kernel.dk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org