[kbuild-all] Re: [PATCH v4 02/10] user_events: Add minimal support for trace_event into ftrace

On Fri, 5 Nov 2021 05:34:31 +0800 kernel test robot <lkp(a)intel.com&gt; wrote: > Hi Beau, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on rostedt-trace/for-next] > [also build test ERROR on shuah-kselftest/next linux/master linus/master v5.15 next-20211104] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Beau-Belgrave/user_events-Enable... > base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next > config: powerpc-allmodconfig (attached as .config) > compiler: powerpc-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/da0961ad45aa1192b47b8a80de6b17437... > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Beau-Belgrave/user_events-Enable-user-processes-to-create-and-write-to-trace-events/20211105-010650 > git checkout da0961ad45aa1192b47b8a80de6b17437434ae4a > # save the attached .config to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash kernel/trace/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp(a)intel.com&gt; > > All errors (new ones prefixed by >>): > > kernel/trace/trace_events_user.c: In function 'user_event_parse': > >> kernel/trace/trace_events_user.c:665:9: error: too few arguments to function 'dyn_event_add' > 665 | dyn_event_add(&user->devent); > | ^~~~~~~~~~~~~ > In file included from kernel/trace/trace_events_user.c:23: > kernel/trace/trace_dynevent.h:79:19: note: declared here > 79 | static inline int dyn_event_add(struct dyn_event *ev, > | ^~~~~~~~~~~~~ You need to pass &user->call too :) Thank you, -- Masami Hiramatsu <mhiramat(a)kernel.org&gt;