11:46 a.m.
Hi Calvin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
34bb975126419e86bc3b95e200dc41de6c6ca69c
config: x86_64-randconfig-a013-20210311 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
574a9dabc63ba1e7a04c08d4bde2eacd61b44ce1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/fc2494f709d3130a0c1dbb4d3769904ee...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Calvin-Johnson/ACPI-support-for-dpaa2-driver/20210311-142527
git checkout fc2494f709d3130a0c1dbb4d3769904ee869185b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/mdio/fwnode_mdio.c:18:5: warning: no previous prototype for function
'fwnode_mdiobus_register_phy' [-Wmissing-prototypes]
int fwnode_mdiobus_register_phy(struct mii_bus *bus,
^
drivers/net/mdio/fwnode_mdio.c:18:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
int fwnode_mdiobus_register_phy(struct mii_bus *bus,
^
static
> drivers/net/mdio/fwnode_mdio.c:88:5: warning: no previous
prototype for function 'fwnode_mdiobus_register' [-Wmissing-prototypes]
int fwnode_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode)
^
drivers/net/mdio/fwnode_mdio.c:88:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
int fwnode_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode)
^
static
2 warnings generated.
vim +/fwnode_mdiobus_register +88 drivers/net/mdio/fwnode_mdio.c
17
18 int fwnode_mdiobus_register_phy(struct mii_bus *bus,
19 struct fwnode_handle *child, u32 addr)
20 {
21 struct mii_timestamper *mii_ts = NULL;
22 struct phy_device *phy;
23 bool is_c45 = false;
24 u32 phy_id;
25 int rc;
26
27 if (is_of_node(child)) {
28 mii_ts = of_find_mii_timestamper(to_of_node(child));
29 if (IS_ERR(mii_ts))
30 return PTR_ERR(mii_ts);
31 }
32
33 rc = fwnode_property_match_string(child, "compatible",
"ethernet-phy-ieee802.3-c45");
34 if (rc >= 0)
35 is_c45 = true;
36
37 if (is_c45 || fwnode_get_phy_id(child, &phy_id))
38 phy = get_phy_device(bus, addr, is_c45);
39 else
40 phy = phy_device_create(bus, addr, phy_id, 0, NULL);
41 if (IS_ERR(phy)) {
42 unregister_mii_timestamper(mii_ts);
43 return PTR_ERR(phy);
44 }
45
46 if (is_acpi_node(child)) {
47 phy->irq = bus->irq[addr];
48
49 /* Associate the fwnode with the device structure so it
50 * can be looked up later.
51 */
52 phy->mdio.dev.fwnode = child;
53
54 /* All data is now stored in the phy struct, so register it */
55 rc = phy_device_register(phy);
56 if (rc) {
57 phy_device_free(phy);
58 fwnode_handle_put(phy->mdio.dev.fwnode);
59 return rc;
60 }
61 } else if (is_of_node(child)) {
62 rc = of_mdiobus_phy_device_register(bus, phy, to_of_node(child), addr);
63 if (rc) {
64 unregister_mii_timestamper(mii_ts);
65 phy_device_free(phy);
66 return rc;
67 }
68 }
69
70 /* phy->mii_ts may already be defined by the PHY driver. A
71 * mii_timestamper probed via the device tree will still have
72 * precedence.
73 */
74 if (mii_ts)
75 phy->mii_ts = mii_ts;
76 return 0;
77 }
78 EXPORT_SYMBOL(fwnode_mdiobus_register_phy);
79
80 /**
81 * fwnode_mdiobus_register - Register mii_bus and create PHYs from fwnode
82 * @mdio: pointer to mii_bus structure
83 * @fwnode: pointer to fwnode of MDIO bus.
84 *
85 * This function returns of_mdiobus_register() for DT and
86 * acpi_mdiobus_register() for ACPI.
87 */
88 int fwnode_mdiobus_register(struct mii_bus *mdio, struct
fwnode_handle *fwnode)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org