[kbuild-all] Re: [PATCH net-next 2/2] net: snmp: add snmp tracepoint support for udp

Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/menglong8-dong-gmail-com/net-snm... base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 84882cf72cd774cf16fd338bdbf00f69ac9f9194 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/15def40653e2754aa06d5af35d8fccd51... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review menglong8-dong-gmail-com/net-snmp-tracepoint-support-for-snmp/20211111-213642 git checkout 15def40653e2754aa06d5af35d8fccd51ea903d2 # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.c:5: drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:25:43: error: expected ')' before 'const' 25 | DECLARE_EVENT_CLASS(mlx5e_flower_template, | ^ | ) drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:48:60: error: expected ')' before 'const' 48 | DEFINE_EVENT(mlx5e_flower_template, mlx5e_configure_flower, | ^ | ) drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:53:57: error: expected ')' before 'const' 53 | DEFINE_EVENT(mlx5e_flower_template, mlx5e_delete_flower, | ^ | ) drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:58:32: error: expected ')' before 'const' 58 | TRACE_EVENT(mlx5e_stats_flower, | ^ | ) drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:77:46: error: expected ')' before 'const' 77 | TRACE_EVENT(mlx5e_tc_update_neigh_used_value, | ^ | ) In file included from include/trace/define_trace.h:95, from drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:114, from drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.c:5: drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:25:43: error: expected ')' before 'const' 25 | DECLARE_EVENT_CLASS(mlx5e_flower_template, | ^ | ) In file included from <command-line>: 15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__ | ^~~~~~~ include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE' 59 | #define ___PASTE(a,b) a##b | ^ include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~ include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/static_call.h:146:39: note: in expansion of macro 'STATIC_CALL_TRAMP' 146 | #define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name) | ^~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:303:24: note: in expansion of macro 'STATIC_CALL_TRAMP_ADDR' 303 | .static_call_tramp = STATIC_CALL_TRAMP_ADDR(tp_func_##_name), \ | ^~~~~~~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:328:2: note: in expansion of macro 'DEFINE_TRACE_FN' 328 | DEFINE_TRACE_FN(name, NULL, NULL, PARAMS(proto), PARAMS(args)); | ^~~~~~~~~~~~~~~ include/trace/define_trace.h:57:2: note: in expansion of macro 'DEFINE_TRACE' 57 | DEFINE_TRACE(name, PARAMS(proto), PARAMS(args)) | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:48:1: note: in expansion of macro 'DEFINE_EVENT' 48 | DEFINE_EVENT(mlx5e_flower_template, mlx5e_configure_flower, | ^~~~~~~~~~~~ 15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__ | ^~~~~~~ include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE' 59 | #define ___PASTE(a,b) a##b | ^ include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~ include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/static_call.h:146:39: note: in expansion of macro 'STATIC_CALL_TRAMP' 146 | #define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name) | ^~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:303:24: note: in expansion of macro 'STATIC_CALL_TRAMP_ADDR' 303 | .static_call_tramp = STATIC_CALL_TRAMP_ADDR(tp_func_##_name), \ | ^~~~~~~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:328:2: note: in expansion of macro 'DEFINE_TRACE_FN' 328 | DEFINE_TRACE_FN(name, NULL, NULL, PARAMS(proto), PARAMS(args)); | ^~~~~~~~~~~~~~~ include/trace/define_trace.h:57:2: note: in expansion of macro 'DEFINE_TRACE' 57 | DEFINE_TRACE(name, PARAMS(proto), PARAMS(args)) | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:53:1: note: in expansion of macro 'DEFINE_EVENT' 53 | DEFINE_EVENT(mlx5e_flower_template, mlx5e_delete_flower, | ^~~~~~~~~~~~ 15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__ | ^~~~~~~ include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE' 59 | #define ___PASTE(a,b) a##b | ^ include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~ include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/static_call.h:146:39: note: in expansion of macro 'STATIC_CALL_TRAMP' 146 | #define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name) | ^~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:303:24: note: in expansion of macro 'STATIC_CALL_TRAMP_ADDR' 303 | .static_call_tramp = STATIC_CALL_TRAMP_ADDR(tp_func_##_name), \ | ^~~~~~~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:328:2: note: in expansion of macro 'DEFINE_TRACE_FN' 328 | DEFINE_TRACE_FN(name, NULL, NULL, PARAMS(proto), PARAMS(args)); | ^~~~~~~~~~~~~~~ include/trace/define_trace.h:28:2: note: in expansion of macro 'DEFINE_TRACE' 28 | DEFINE_TRACE(name, PARAMS(proto), PARAMS(args)) | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:58:1: note: in expansion of macro 'TRACE_EVENT' 58 | TRACE_EVENT(mlx5e_stats_flower, | ^~~~~~~~~~~ 15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__ | ^~~~~~~ include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE' 59 | #define ___PASTE(a,b) a##b | ^ include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~ include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX' 18 | #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) | ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/static_call.h:146:39: note: in expansion of macro 'STATIC_CALL_TRAMP' 146 | #define STATIC_CALL_TRAMP_ADDR(name) &STATIC_CALL_TRAMP(name) | ^~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:303:24: note: in expansion of macro 'STATIC_CALL_TRAMP_ADDR' 303 | .static_call_tramp = STATIC_CALL_TRAMP_ADDR(tp_func_##_name), \ | ^~~~~~~~~~~~~~~~~~~~~~ include/linux/tracepoint.h:328:2: note: in expansion of macro 'DEFINE_TRACE_FN' 328 | DEFINE_TRACE_FN(name, NULL, NULL, PARAMS(proto), PARAMS(args)); | ^~~~~~~~~~~~~~~ include/trace/define_trace.h:28:2: note: in expansion of macro 'DEFINE_TRACE' 28 | DEFINE_TRACE(name, PARAMS(proto), PARAMS(args)) | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:77:1: note: in expansion of macro 'TRACE_EVENT' 77 | TRACE_EVENT(mlx5e_tc_update_neigh_used_value, | ^~~~~~~~~~~ In file included from include/trace/define_trace.h:102, from drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.h:114, from drivers/net/ethernet/mellanox/mlx5/core/diag/en_tc_tracepoint.c:5: drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h: In function 'ftrace_test_probe_mlx5e_configure_flower': include/trace/trace_events.h:757:2: error: implicit declaration of function 'check_trace_callback_type_mlx5e_configure_flower' [-Werror=implicit-function-declaration] 757 | check_trace_callback_type_##call(trace_event_raw_event_##template); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:48:1: note: in expansion of macro 'DEFINE_EVENT' 48 | DEFINE_EVENT(mlx5e_flower_template, mlx5e_configure_flower, | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h: In function 'ftrace_test_probe_mlx5e_delete_flower': include/trace/trace_events.h:757:2: error: implicit declaration of function 'check_trace_callback_type_mlx5e_delete_flower'; did you mean 'check_trace_callback_type_snmp_udplite'? [-Werror=implicit-function-declaration] 757 | check_trace_callback_type_##call(trace_event_raw_event_##template); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:53:1: note: in expansion of macro 'DEFINE_EVENT' 53 | DEFINE_EVENT(mlx5e_flower_template, mlx5e_delete_flower, | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h: In function 'ftrace_test_probe_mlx5e_stats_flower': include/trace/trace_events.h:757:2: error: implicit declaration of function 'check_trace_callback_type_mlx5e_stats_flower'; did you mean 'check_trace_callback_type_snmp_udplite'? [-Werror=implicit-function-declaration] 757 | check_trace_callback_type_##call(trace_event_raw_event_##template); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/trace/trace_events.h:81:2: note: in expansion of macro 'DEFINE_EVENT' 81 | DEFINE_EVENT(name, name, PARAMS(proto), PARAMS(args)); | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:58:1: note: in expansion of macro 'TRACE_EVENT' 58 | TRACE_EVENT(mlx5e_stats_flower, | ^~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h: In function 'ftrace_test_probe_mlx5e_tc_update_neigh_used_value': include/trace/trace_events.h:757:2: error: implicit declaration of function 'check_trace_callback_type_mlx5e_tc_update_neigh_used_value'; did you mean 'trace_raw_output_mlx5e_tc_update_neigh_used_value'? [-Werror=implicit-function-declaration] 757 | check_trace_callback_type_##call(trace_event_raw_event_##template); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/trace/trace_events.h:81:2: note: in expansion of macro 'DEFINE_EVENT' 81 | DEFINE_EVENT(name, name, PARAMS(proto), PARAMS(args)); | ^~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/./diag/en_tc_tracepoint.h:77:1: note: in expansion of macro 'TRACE_EVENT' 77 | TRACE_EVENT(mlx5e_tc_update_neigh_used_value, | ^~~~~~~~~~~ cc1: all warnings being treated as errors vim +15 include/linux/static_call_types.h 115284d89a436e9 Josh Poimboeuf 2020-08-18 14 115284d89a436e9 Josh Poimboeuf 2020-08-18 @15 #define STATIC_CALL_TRAMP_PREFIX __SCT__ 115284d89a436e9 Josh Poimboeuf 2020-08-18 16 #define STATIC_CALL_TRAMP_PREFIX_STR __stringify(STATIC_CALL_TRAMP_PREFIX) 9183c3f9ed710a8 Josh Poimboeuf 2020-08-18 17 #define STATIC_CALL_TRAMP_PREFIX_LEN (sizeof(STATIC_CALL_TRAMP_PREFIX_STR) - 1) 115284d89a436e9 Josh Poimboeuf 2020-08-18 18 #define STATIC_CALL_TRAMP(name) __PASTE(STATIC_CALL_TRAMP_PREFIX, name) 115284d89a436e9 Josh Poimboeuf 2020-08-18 19 #define STATIC_CALL_TRAMP_STR(name) __stringify(STATIC_CALL_TRAMP(name)) 115284d89a436e9 Josh Poimboeuf 2020-08-18 20 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org