11:19 a.m.
Hi Guangbin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Guangbin-Huang/ethtool-add-suppo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
62803fec52f80e4dd375de2dd76510c405792928
config: powerpc64-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/da4c6abe75add01de642c7b12fd4268cd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Guangbin-Huang/ethtool-add-support-to-set-get-tx-copybreak-buf-size-and-rx-buf-len/20211117-100258
git checkout da4c6abe75add01de642c7b12fd4268cd9c5f14e
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=powerpc SHELL=/bin/bash arch/powerpc/platforms/cell/ drivers/net/ethernet/toshiba/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/net/ethernet/toshiba/spider_net_ethtool.c:114:34: error:
expected ';', ',' or ')' before 'struct'
114 |
struct kernel_ethtool_ringparam *kernel_ering,
| ^~~~~~
> drivers/net/ethernet/toshiba/spider_net_ethtool.c:168:35: error:
'spider_net_ethtool_get_ringparam' undeclared here (not in a function); did you
mean 'spider_net_ethtool_get_msglevel'?
168 | .get_ringparam
= spider_net_ethtool_get_ringparam,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| spider_net_ethtool_get_msglevel
vim +114 drivers/net/ethernet/toshiba/spider_net_ethtool.c
110
111 static void
112 spider_net_ethtool_get_ringparam(struct net_device *netdev,
113 struct ethtool_ringparam *ering
114 struct kernel_ethtool_ringparam *kernel_ering,
115 struct netlink_ext_ack *extack)
116 {
117 struct spider_net_card *card = netdev_priv(netdev);
118
119 ering->tx_max_pending = SPIDER_NET_TX_DESCRIPTORS_MAX;
120 ering->tx_pending = card->tx_chain.num_desc;
121 ering->rx_max_pending = SPIDER_NET_RX_DESCRIPTORS_MAX;
122 ering->rx_pending = card->rx_chain.num_desc;
123 }
124
125 static int spider_net_get_sset_count(struct net_device *netdev, int sset)
126 {
127 switch (sset) {
128 case ETH_SS_STATS:
129 return ARRAY_SIZE(ethtool_stats_keys);
130 default:
131 return -EOPNOTSUPP;
132 }
133 }
134
135 static void spider_net_get_ethtool_stats(struct net_device *netdev,
136 struct ethtool_stats *stats, u64 *data)
137 {
138 struct spider_net_card *card = netdev_priv(netdev);
139
140 data[0] = netdev->stats.tx_packets;
141 data[1] = netdev->stats.tx_bytes;
142 data[2] = netdev->stats.rx_packets;
143 data[3] = netdev->stats.rx_bytes;
144 data[4] = netdev->stats.tx_errors;
145 data[5] = netdev->stats.tx_dropped;
146 data[6] = netdev->stats.rx_dropped;
147 data[7] = card->spider_stats.rx_desc_error;
148 data[8] = card->spider_stats.tx_timeouts;
149 data[9] = card->spider_stats.alloc_rx_skb_error;
150 data[10] = card->spider_stats.rx_iommu_map_error;
151 data[11] = card->spider_stats.tx_iommu_map_error;
152 data[12] = card->spider_stats.rx_desc_unk_state;
153 }
154
155 static void spider_net_get_strings(struct net_device *netdev, u32 stringset,
156 u8 *data)
157 {
158 memcpy(data, ethtool_stats_keys, sizeof(ethtool_stats_keys));
159 }
160
161 const struct ethtool_ops spider_net_ethtool_ops = {
162 .get_drvinfo = spider_net_ethtool_get_drvinfo,
163 .get_wol = spider_net_ethtool_get_wol,
164 .get_msglevel = spider_net_ethtool_get_msglevel,
165 .set_msglevel = spider_net_ethtool_set_msglevel,
166 .get_link = ethtool_op_get_link,
167 .nway_reset = spider_net_ethtool_nway_reset,
168 .get_ringparam = spider_net_ethtool_get_ringparam,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org