11:38 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.9
head: 5bdb21a02abe7e0cabf09a6a8e652f03b2ac7056
commit: 622a4c5237e31802a14ef46f2458572c553b06e0 [113/117] net: qed: RDMA personality
shouldn't fail VF load
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
#
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-4.9
git checkout 622a4c5237e31802a14ef46f2458572c553b06e0
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/qlogic/qed/qed_sriov.c: In function 'qed_sp_vf_start':
> drivers/net/ethernet/qlogic/qed/qed_sriov.c:54:7: error:
'QED_PCI_ETH_IWARP' undeclared (first use in this function); did you mean
'QED_PCI_ETH_ROCE'?
case QED_PCI_ETH_IWARP:
^~~~~~~~~~~~~~~~~
QED_PCI_ETH_ROCE
drivers/net/ethernet/qlogic/qed/qed_sriov.c:54:7: note: each undeclared identifier is
reported only once for each function it appears in
In file included from drivers/net/ethernet/qlogic/qed/qed_cxt.h:15:0,
from drivers/net/ethernet/qlogic/qed/qed_sriov.c:12:
At top level:
drivers/net/ethernet/qlogic/qed/qed_hsi.h:3453:25: warning: 'iro_arr' defined
but not used [-Wunused-const-variable=]
static const struct iro iro_arr[47] = {
^~~~~~~
vim +54 drivers/net/ethernet/qlogic/qed/qed_sriov.c
22
23 /* IOV ramrods */
24 static int qed_sp_vf_start(struct qed_hwfn *p_hwfn, struct qed_vf_info *p_vf)
25 {
26 struct vf_start_ramrod_data *p_ramrod = NULL;
27 struct qed_spq_entry *p_ent = NULL;
28 struct qed_sp_init_data init_data;
29 int rc = -EINVAL;
30 u8 fp_minor;
31
32 /* Get SPQ entry */
33 memset(&init_data, 0, sizeof(init_data));
34 init_data.cid = qed_spq_get_cid(p_hwfn);
35 init_data.opaque_fid = p_vf->opaque_fid;
36 init_data.comp_mode = QED_SPQ_MODE_EBLOCK;
37
38 rc = qed_sp_init_request(p_hwfn, &p_ent,
39 COMMON_RAMROD_VF_START,
40 PROTOCOLID_COMMON, &init_data);
41 if (rc)
42 return rc;
43
44 p_ramrod = &p_ent->ramrod.vf_start;
45
46 p_ramrod->vf_id = GET_FIELD(p_vf->concrete_fid, PXP_CONCRETE_FID_VFID);
47 p_ramrod->opaque_fid = cpu_to_le16(p_vf->opaque_fid);
48
49 switch (p_hwfn->hw_info.personality) {
50 case QED_PCI_ETH:
51 p_ramrod->personality = PERSONALITY_ETH;
52 break;
53 case QED_PCI_ETH_ROCE:
54 case QED_PCI_ETH_IWARP:
55 p_ramrod->personality =
PERSONALITY_RDMA_AND_ETH;
56 break;
57 default:
58 DP_NOTICE(p_hwfn, "Unknown VF personality %d\n",
59 p_hwfn->hw_info.personality);
60 return -EINVAL;
61 }
62
63 fp_minor = p_vf->acquire.vfdev_info.eth_fp_hsi_minor;
64 if (fp_minor > ETH_HSI_VER_MINOR &&
65 fp_minor != ETH_HSI_VER_NO_PKT_LEN_TUNN) {
66 DP_VERBOSE(p_hwfn,
67 QED_MSG_IOV,
68 "VF [%d] - Requested fp hsi %02x.%02x which is slightly newer than
PF's %02x.%02x; Configuring PFs version\n",
69 p_vf->abs_vf_id,
70 ETH_HSI_VER_MAJOR,
71 fp_minor, ETH_HSI_VER_MAJOR, ETH_HSI_VER_MINOR);
72 fp_minor = ETH_HSI_VER_MINOR;
73 }
74
75 p_ramrod->hsi_fp_ver.major_ver_arr[ETH_VER_KEY] = ETH_HSI_VER_MAJOR;
76 p_ramrod->hsi_fp_ver.minor_ver_arr[ETH_VER_KEY] = fp_minor;
77
78 DP_VERBOSE(p_hwfn, QED_MSG_IOV,
79 "VF[%d] - Starting using HSI %02x.%02x\n",
80 p_vf->abs_vf_id, ETH_HSI_VER_MAJOR, fp_minor);
81
82 return qed_spq_post(p_hwfn, p_ent, NULL);
83 }
84
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org