7:57 a.m.
Hi JaeSang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on v5.17-rc3 next-20220208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/JaeSang-Yoo/trace-param-fix-tp_p...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: x86_64-randconfig-m001
(https://download.01.org/0day-ci/archive/20220209/202202090421.PMWXYPxl-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/2f6eb784171798586c7fde6d2f2e445ac...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
JaeSang-Yoo/trace-param-fix-tp_printk-option-related-with-tp_printk_stop_on_boot/20220209-003316
git checkout 2f6eb784171798586c7fde6d2f2e445ac5a344c3
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/trace/trace.c: In function 'set_tracepoint_printk':
> kernel/trace/trace.c:256:11: error: expected ';' before
'if'
256 | return 0
| ^
| ;
257 | if ((strcmp(str, "=0") != 0 && strcmp(str, "=off")
!= 0))
| ~~
kernel/trace/trace.c: In function 'trace_check_vprintf':
kernel/trace/trace.c:3824:3: warning: function 'trace_check_vprintf' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
3824 | trace_seq_vprintf(&iter->seq, iter->fmt, ap);
| ^~~~~~~~~~~~~~~~~
kernel/trace/trace.c:3891:3: warning: function 'trace_check_vprintf' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
3891 | trace_seq_vprintf(&iter->seq, p, ap);
| ^~~~~~~~~~~~~~~~~
At top level:
kernel/trace/trace.c:1672:37: warning: 'tracing_max_lat_fops' defined but not
used [-Wunused-const-variable=]
1672 | static const struct file_operations tracing_max_lat_fops;
| ^~~~~~~~~~~~~~~~~~~~
vim +256 kernel/trace/trace.c
252
253 static int __init set_tracepoint_printk(char *str)
254 {
255 if (*str == '_')
256 return 0
257 if ((strcmp(str, "=0") != 0
&& strcmp(str, "=off") != 0))
258 tracepoint_printk = 1;
259 return 1;
260 }
261 __setup("tp_printk", set_tracepoint_printk);
262
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org