4:22 p.m.
Hi Maximilian,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20210211]
[cannot apply to linus/master v5.11-rc7 v5.11-rc6 v5.11-rc5 v5.11-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Maximilian-Luz/platform-surface-...
base: 671176b0016c80b3943cb5387312c886aba3308d
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/32e4dc2a84e7cfca40f6efbf16ba50e29...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Maximilian-Luz/platform-surface-Add-Surface-Aggregator-device-registry/20210212-035100
git checkout 32e4dc2a84e7cfca40f6efbf16ba50e294c70f1c
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:93,
from include/linux/bug.h:5,
from include/linux/cpumask.h:14,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/mutex.h:17,
from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from drivers/platform/surface/surface_aggregator_registry.c:12:
drivers/platform/surface/surface_aggregator_registry.c: In function
'__ssam_base_hub_update':
> include/linux/lockdep.h:281:52: error: invalid type argument of
'->' (have 'struct mutex')
281 | #define
lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
| ^~
include/asm-generic/bug.h:119:25: note: in definition of macro 'WARN_ON'
119 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~
include/linux/lockdep.h:305:27: note: in expansion of macro 'lockdep_is_held'
305 | WARN_ON(debug_locks && !lockdep_is_held(l)); \
| ^~~~~~~~~~~~~~~
drivers/platform/surface/surface_aggregator_registry.c:266:2: note: in expansion of
macro 'lockdep_assert_held'
266 | lockdep_assert_held(hub->lock);
| ^~~~~~~~~~~~~~~~~~~
vim +281 include/linux/lockdep.h
f607c668577481 Peter Zijlstra 2009-07-20 280
f8319483f57f1c Peter Zijlstra 2016-11-30 @281 #define
lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
f8319483f57f1c Peter Zijlstra 2016-11-30 282 #define lockdep_is_held_type(lock,
r) lock_is_held_type(&(lock)->dep_map, (r))
f607c668577481 Peter Zijlstra 2009-07-20 283
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org