[kbuild-all] Re: [PATCH RFC] bus: mhi: core: Enable unique QRTR node ID support

Hi Gokul, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on linus/master] [also build test ERROR on v5.9 next-20201016] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Gokul-Sriram-Palanisamy/bus-mhi-... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9ff9b0d392ea08090cd1780fb196f36dbb586529 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7a9b56e151211022c138dff2099281fa1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Gokul-Sriram-Palanisamy/bus-mhi-core-Enable-unique-QRTR-node-ID-support/20201017-030555 git checkout 7a9b56e151211022c138dff2099281fa12103f00 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/bus/mhi/core/boot.c: In function 'mhi_fw_load_handler': 467 | ret = of_property_read_u32(mhi_cntrl->cntrl_dev->of_node, | ^~~~~~~~~~~~~~~~~~~~ drivers/bus/mhi/core/boot.c:468:30: error: 'instance' undeclared (first use in this function) 468 | "qrtr-instance-id", &instance); | ^~~~~~~~ drivers/bus/mhi/core/boot.c:468:30: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors vim +/of_property_read_u32 +467 drivers/bus/mhi/core/boot.c 388 389 void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) 390 { 391 const struct firmware *firmware = NULL; 392 struct image_info *image_info; 393 struct device *dev = &mhi_cntrl->mhi_dev->dev; 394 const char *fw_name; 395 void *buf; 396 dma_addr_t dma_addr; 397 size_t size; 398 int i, ret; 399 400 if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) { 401 dev_err(dev, "Device MHI is not in valid state\n"); 402 return; 403 } 404 405 /* save hardware info from BHI */ 406 ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->bhi, BHI_SERIALNU, 407 &mhi_cntrl->serial_number); 408 if (ret) 409 dev_err(dev, "Could not capture serial number via BHI\n"); 410 411 for (i = 0; i < ARRAY_SIZE(mhi_cntrl->oem_pk_hash); i++) { 412 ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->bhi, BHI_OEMPKHASH(i), 413 &mhi_cntrl->oem_pk_hash[i]); 414 if (ret) { 415 dev_err(dev, "Could not capture OEM PK HASH via BHI\n"); 416 break; 417 } 418 } 419 420 /* If device is in pass through, do reset to ready state transition */ 421 if (mhi_cntrl->ee == MHI_EE_PTHRU) 422 goto fw_load_ee_pthru; 423 424 fw_name = (mhi_cntrl->ee == MHI_EE_EDL) ? 425 mhi_cntrl->edl_image : mhi_cntrl->fw_image; 426 427 if (!fw_name || (mhi_cntrl->fbc_download && (!mhi_cntrl->sbl_size || 428 !mhi_cntrl->seg_len))) { 429 dev_err(dev, 430 "No firmware image defined or !sbl_size || !seg_len\n"); 431 return; 432 } 433 434 ret = request_firmware(&firmware, fw_name, dev); 435 if (ret) { 436 dev_err(dev, "Error loading firmware: %d\n", ret); 437 return; 438 } 439 440 size = (mhi_cntrl->fbc_download) ? mhi_cntrl->sbl_size : firmware->size; 441 442 /* SBL size provided is maximum size, not necessarily the image size */ 443 if (size > firmware->size) 444 size = firmware->size; 445 446 buf = mhi_alloc_coherent(mhi_cntrl, size, &dma_addr, GFP_KERNEL); 447 if (!buf) { 448 release_firmware(firmware); 449 return; 450 } 451 452 /* Download SBL image */ 453 memcpy(buf, firmware->data, size); 454 ret = mhi_fw_load_sbl(mhi_cntrl, dma_addr, size); 455 mhi_free_coherent(mhi_cntrl, size, buf, dma_addr); 456 457 if (!mhi_cntrl->fbc_download || ret || mhi_cntrl->ee == MHI_EE_EDL) 458 release_firmware(firmware); 459 460 /* Error or in EDL mode, we're done */ 461 if (ret) { 462 dev_err(dev, "MHI did not load SBL, ret:%d\n", ret); 463 return; 464 } 465 466 if (!ret && mhi_cntrl->cntrl_dev->of_node) { --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org