[kbuild-all] Re: [PATCH v9 21/24] coresight: cti: allow cti to be built as a module

Hi Tingwei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20200819] [cannot apply to stm32/stm32-next soc/for-next linus/master v5.9-rc1 v5.8 v5.8-rc7 v5.9-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Tingwei-Zhang/coresight-allow-to... base: 8eb858df0a5f6bcd371b5d5637255c987278b8c9 config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): 562 | void cti_add_assoc_to_csdev(struct coresight_device *csdev) | ^~~~~~~~~~~~~~~~~~~~~~ 600 | void cti_remove_assoc_from_csdev(struct coresight_device *csdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ # https://github.com/0day-ci/linux/commit/12056bd06fed024dafde4b2937e601f9a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tingwei-Zhang/coresight-allow-to-build-coresight-as-modules/20200820-135428 git checkout 12056bd06fed024dafde4b2937e601f9ac958ca9 vim +/cti_add_assoc_to_csdev +562 drivers/hwtracing/coresight/coresight-cti-core.c 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 556 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 557 /* 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 558 * Search the cti list to add an associated CTI into the supplied CS device 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 559 * This will set the association if CTI declared before the CS device. 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 560 * (called from coresight_register() with coresight_mutex locked). 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 561 */ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 @562 void cti_add_assoc_to_csdev(struct coresight_device *csdev) 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 563 { 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 564 struct cti_drvdata *ect_item; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 565 struct cti_device *ctidev; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 566 const char *node_name = NULL; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 567 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 568 /* protect the list */ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 569 mutex_lock(&ect_mutex); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 570 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 571 /* exit if current is an ECT device.*/ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 572 if ((csdev->type == CORESIGHT_DEV_TYPE_ECT) || list_empty(&ect_net)) 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 573 goto cti_add_done; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 574 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 575 /* if we didn't find the csdev previously we used the fwnode name */ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 576 node_name = cti_plat_get_node_name(dev_fwnode(csdev->dev.parent)); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 577 if (!node_name) 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 578 goto cti_add_done; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 579 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 580 /* for each CTI in list... */ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 581 list_for_each_entry(ect_item, &ect_net, node) { 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 582 ctidev = &ect_item->ctidev; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 583 if (cti_match_fixup_csdev(ctidev, node_name, csdev)) { 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 584 /* 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 585 * if we found a matching csdev then update the ECT 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 586 * association pointer for the device with this CTI. 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 587 */ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 588 csdev->ect_dev = ect_item->csdev; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 589 break; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 590 } 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 591 } 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 592 cti_add_done: 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 593 mutex_unlock(&ect_mutex); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 594 } 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 595 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 596 /* 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 597 * Removing the associated devices is easier. 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 598 * A CTI will not have a value for csdev->ect_dev. 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 599 */ 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 @600 void cti_remove_assoc_from_csdev(struct coresight_device *csdev) 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 601 { 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 602 struct cti_drvdata *ctidrv; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 603 struct cti_trig_con *tc; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 604 struct cti_device *ctidev; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 605 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 606 mutex_lock(&ect_mutex); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 607 if (csdev->ect_dev) { 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 608 ctidrv = csdev_to_cti_drvdata(csdev->ect_dev); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 609 ctidev = &ctidrv->ctidev; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 610 list_for_each_entry(tc, &ctidev->trig_cons, node) { e2f7f25cf0f7159 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-08-20 611 if (tc->con_dev == csdev) { 773a0a19acaf1b1 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-08-20 612 cti_remove_sysfs_link(ctidrv, tc); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 613 tc->con_dev = NULL; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 614 break; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 615 } 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 616 } 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 617 csdev->ect_dev = NULL; 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 618 } 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 619 mutex_unlock(&ect_mutex); 177af8285b59a38 drivers/hwtracing/coresight/coresight-cti.c Mike Leach 2020-03-20 620 } 79231847141a5a8 drivers/hwtracing/coresight/coresight-cti.c Tingwei Zhang 2020-08-20 621 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org