[kbuild-all] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:122:11: warning: missing braces around initializer

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 358feceebbf68f33c44c6650d14455389e65282d commit: 20f2ffe504728612d7b0c34e4f8280e34251e704 drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN (v3) date: 3 months ago config: i386-randconfig-a014-20200624 (attached as .config) compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit... git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 20f2ffe504728612d7b0c34e4f8280e34251e704 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:96:6: warning: no previous prototype for 'vg_update_clocks' [-Wmissing-prototypes] void vg_update_clocks(struct clk_mgr *clk_mgr_base, ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c: In function 'vg_update_clocks': union display_idle_optimization_u idle_info = { 0 }; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:122:11: warning: (near initialization for 'idle_info.idle_info') [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:135:10: warning: missing braces around initializer [-Wmissing-braces] union display_idle_optimization_u idle_info = { 0 }; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:135:10: warning: (near initialization for 'idle_info.idle_info') [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c: At top level: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:375:6: warning: no previous prototype for 'vg_get_clk_states' [-Wmissing-prototypes] void vg_get_clk_states(struct clk_mgr *clk_mgr_base, struct clk_states *s) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:393:6: warning: no previous prototype for 'vg_init_clocks' [-Wmissing-prototypes] void vg_init_clocks(struct clk_mgr *clk_mgr) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:710:15: warning: missing braces around initializer [-Wmissing-braces] static struct watermarks dummy_wms = { 0 }; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c:710:15: warning: (near initialization for 'dummy_wms.WatermarkRow') [-Wmissing-braces] -- drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/dcn301_smu.c:91:5: warning: no previous prototype for 'dcn301_smu_send_msg_with_param' [-Wmissing-prototypes] int dcn301_smu_send_msg_with_param( ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/dcn301_smu.c: In function 'dcn301_smu_enable_phy_refclk_pwrdwn': union display_idle_optimization_u idle_info = { 0 }; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/dcn301_smu.c:198:8: warning: (near initialization for 'idle_info.idle_info') [-Wmissing-braces] -- drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c: In function 'dcn30_mmhubbub_warmup': struct mcif_warmup_params warmup_params = {0}; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c:264:9: warning: (near initialization for 'warmup_params.start_address') [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c: In function 'dcn30_enable_writeback': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c:322:27: warning: variable 'optc' set but not used [-Wunused-but-set-variable] struct timing_generator *optc; ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c: In function 'dcn30_update_info_frame': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_hwseq.c:654:7: warning: variable 'is_dp' set but not used [-Wunused-but-set-variable] bool is_dp; ^ -- stream_enc_regs(0), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:447:2: warning: (near initialization for 'stream_enc_regs[0].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:447:2: warning: (near initialization for 'stream_enc_regs[0].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:447:2: warning: (near initialization for 'stream_enc_regs[0].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:448:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:448:2: warning: (near initialization for 'stream_enc_regs[1].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:448:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:448:2: warning: (near initialization for 'stream_enc_regs[1].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:448:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:448:2: warning: (near initialization for 'stream_enc_regs[1].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:449:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(2), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:449:2: warning: (near initialization for 'stream_enc_regs[2].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:449:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:449:2: warning: (near initialization for 'stream_enc_regs[2].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:449:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:449:2: warning: (near initialization for 'stream_enc_regs[2].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:450:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(3), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:450:2: warning: (near initialization for 'stream_enc_regs[3].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:450:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:450:2: warning: (near initialization for 'stream_enc_regs[3].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:450:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:450:2: warning: (near initialization for 'stream_enc_regs[3].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:451:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(4), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:451:2: warning: (near initialization for 'stream_enc_regs[4].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:451:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:451:2: warning: (near initialization for 'stream_enc_regs[4].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:451:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:451:2: warning: (near initialization for 'stream_enc_regs[4].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:452:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(5) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:452:2: warning: (near initialization for 'stream_enc_regs[5].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:452:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:452:2: warning: (near initialization for 'stream_enc_regs[5].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:452:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:452:2: warning: (near initialization for 'stream_enc_regs[5].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:501:2: warning: initialized field overwritten [-Woverride-init] DCN_AUX_MASK_SH_LIST(__SHIFT) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:501:2: warning: (near initialization for 'aux_shift.AUX_SW_AUTOINCREMENT_DISABLE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:505:2: warning: initialized field overwritten [-Woverride-init] DCN_AUX_MASK_SH_LIST(_MASK) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:505:2: warning: (near initialization for 'aux_mask.AUX_SW_AUTOINCREMENT_DISABLE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:509:2: warning: initialized field overwritten [-Woverride-init] link_regs(0, A), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:509:2: warning: (near initialization for 'link_enc_regs[0].TMDS_CTL_BITS') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:510:2: warning: initialized field overwritten [-Woverride-init] link_regs(1, B), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:510:2: warning: (near initialization for 'link_enc_regs[1].TMDS_CTL_BITS') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:511:2: warning: initialized field overwritten [-Woverride-init] link_regs(2, C), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:511:2: warning: (near initialization for 'link_enc_regs[2].TMDS_CTL_BITS') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:512:2: warning: initialized field overwritten [-Woverride-init] link_regs(3, D), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:512:2: warning: (near initialization for 'link_enc_regs[3].TMDS_CTL_BITS') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:513:2: warning: initialized field overwritten [-Woverride-init] link_regs(4, E), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:513:2: warning: (near initialization for 'link_enc_regs[4].TMDS_CTL_BITS') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:514:2: warning: initialized field overwritten [-Woverride-init] link_regs(5, F) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:514:2: warning: (near initialization for 'link_enc_regs[5].TMDS_CTL_BITS') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:518:2: warning: initialized field overwritten [-Woverride-init] LINK_ENCODER_MASK_SH_LIST_DCN30(__SHIFT),\ ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:518:2: warning: (near initialization for 'le_shift.TMDS_CTL0') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:523:2: warning: initialized field overwritten [-Woverride-init] LINK_ENCODER_MASK_SH_LIST_DCN30(_MASK),\ ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:523:2: warning: (near initialization for 'le_mask.TMDS_CTL0') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:546:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(0), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:546:2: warning: (near initialization for 'dpp_regs[0].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:546:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:546:2: warning: (near initialization for 'dpp_regs[0].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:546:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:546:2: warning: (near initialization for 'dpp_regs[0].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:547:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:547:2: warning: (near initialization for 'dpp_regs[1].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:547:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:547:2: warning: (near initialization for 'dpp_regs[1].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:547:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:547:2: warning: (near initialization for 'dpp_regs[1].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:548:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(2), ^ -- stream_enc_regs(0), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:447:2: warning: (near initialization for 'stream_enc_regs[0].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:447:2: warning: (near initialization for 'stream_enc_regs[0].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:447:2: warning: (near initialization for 'stream_enc_regs[0].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:448:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:448:2: warning: (near initialization for 'stream_enc_regs[1].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:448:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:448:2: warning: (near initialization for 'stream_enc_regs[1].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:448:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:448:2: warning: (near initialization for 'stream_enc_regs[1].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:449:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(2), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:449:2: warning: (near initialization for 'stream_enc_regs[2].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:449:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:449:2: warning: (near initialization for 'stream_enc_regs[2].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:449:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:449:2: warning: (near initialization for 'stream_enc_regs[2].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:450:2: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(3), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:450:2: warning: (near initialization for 'stream_enc_regs[3].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:450:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:450:2: warning: (near initialization for 'stream_enc_regs[3].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:450:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:450:2: warning: (near initialization for 'stream_enc_regs[3].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:493:2: warning: initialized field overwritten [-Woverride-init] DCN_AUX_MASK_SH_LIST(__SHIFT) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:493:2: warning: (near initialization for 'aux_shift.AUX_SW_AUTOINCREMENT_DISABLE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:497:2: warning: initialized field overwritten [-Woverride-init] DCN_AUX_MASK_SH_LIST(_MASK) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:497:2: warning: (near initialization for 'aux_mask.AUX_SW_AUTOINCREMENT_DISABLE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:508:2: warning: initialized field overwritten [-Woverride-init] LINK_ENCODER_MASK_SH_LIST_DCN301(__SHIFT) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:508:2: warning: (near initialization for 'le_shift.TMDS_CTL0') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:512:2: warning: initialized field overwritten [-Woverride-init] LINK_ENCODER_MASK_SH_LIST_DCN301(_MASK) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:512:2: warning: (near initialization for 'le_mask.TMDS_CTL0') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:539:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(0), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:539:2: warning: (near initialization for 'dpp_regs[0].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:539:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:539:2: warning: (near initialization for 'dpp_regs[0].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:539:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:539:2: warning: (near initialization for 'dpp_regs[0].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:540:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:540:2: warning: (near initialization for 'dpp_regs[1].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:540:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:540:2: warning: (near initialization for 'dpp_regs[1].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:540:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:540:2: warning: (near initialization for 'dpp_regs[1].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:541:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(2), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:541:2: warning: (near initialization for 'dpp_regs[2].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:541:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:541:2: warning: (near initialization for 'dpp_regs[2].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:541:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:541:2: warning: (near initialization for 'dpp_regs[2].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:542:2: warning: initialized field overwritten [-Woverride-init] dpp_regs(3), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:542:2: warning: (near initialization for 'dpp_regs[3].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:542:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:542:2: warning: (near initialization for 'dpp_regs[3].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:542:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:542:2: warning: (near initialization for 'dpp_regs[3].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:546:3: warning: initialized field overwritten [-Woverride-init] DPP_REG_LIST_SH_MASK_DCN30(__SHIFT) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:546:3: warning: (near initialization for 'tf_shift.CM_3DLUT_MODE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:550:3: warning: initialized field overwritten [-Woverride-init] DPP_REG_LIST_SH_MASK_DCN30(_MASK) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:550:3: warning: (near initialization for 'tf_mask.CM_3DLUT_MODE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:634:2: warning: initialized field overwritten [-Woverride-init] DSC_REG_LIST_SH_MASK_DCN20(__SHIFT) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:634:2: warning: (near initialization for 'dsc_shift.PIC_WIDTH') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:634:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:634:2: warning: (near initialization for 'dsc_shift.PIC_HEIGHT') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:638:2: warning: initialized field overwritten [-Woverride-init] DSC_REG_LIST_SH_MASK_DCN20(_MASK) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:638:2: warning: (near initialization for 'dsc_mask.PIC_WIDTH') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:638:2: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:638:2: warning: (near initialization for 'dsc_mask.PIC_HEIGHT') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:647:3: warning: initialized field overwritten [-Woverride-init] MPC_OUT_MUX_REG_LIST_DCN3_0(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:647:3: warning: (near initialization for 'mpc_regs.MPC_OUT_CSC_COEF_FORMAT') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn301/dcn301_resource.c:648:3: warning: initialized field overwritten [-Woverride-init] MPC_OUT_MUX_REG_LIST_DCN3_0(2), ^ -- stream_enc_regs(0), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:505:3: warning: (near initialization for 'stream_enc_regs[0].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:505:3: warning: (near initialization for 'stream_enc_regs[0].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:505:3: warning: (near initialization for 'stream_enc_regs[0].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:506:3: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:506:3: warning: (near initialization for 'stream_enc_regs[1].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:506:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:506:3: warning: (near initialization for 'stream_enc_regs[1].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:506:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:506:3: warning: (near initialization for 'stream_enc_regs[1].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:507:3: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(2), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:507:3: warning: (near initialization for 'stream_enc_regs[2].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:507:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:507:3: warning: (near initialization for 'stream_enc_regs[2].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:507:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:507:3: warning: (near initialization for 'stream_enc_regs[2].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:508:3: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(3), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:508:3: warning: (near initialization for 'stream_enc_regs[3].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:508:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:508:3: warning: (near initialization for 'stream_enc_regs[3].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:508:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:508:3: warning: (near initialization for 'stream_enc_regs[3].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:509:3: warning: initialized field overwritten [-Woverride-init] stream_enc_regs(4) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:509:3: warning: (near initialization for 'stream_enc_regs[4].DP_SEC_METADATA_TRANSMISSION') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:509:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:509:3: warning: (near initialization for 'stream_enc_regs[4].HDMI_METADATA_PACKET_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:509:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:509:3: warning: (near initialization for 'stream_enc_regs[4].DIG_FE_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:585:3: warning: initialized field overwritten [-Woverride-init] HWSEQ_DCN302_REG_LIST() ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:585:3: warning: (near initialization for 'hwseq_reg.DCFCLK_CNTL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: initialized field overwritten [-Woverride-init] HUBP_MASK_SH_LIST_DCN30(__SHIFT) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: (near initialization for 'hubp_shift.REFCYC_PER_REQ_DELIVERY') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: (near initialization for 'hubp_shift.QoS_LEVEL_FIXED') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: (near initialization for 'hubp_shift.QoS_RAMP_DISABLE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:621:3: warning: (near initialization for 'hubp_shift.REFCYC_PER_REQ_DELIVERY_PRE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: initialized field overwritten [-Woverride-init] HUBP_MASK_SH_LIST_DCN30(_MASK) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: (near initialization for 'hubp_mask.REFCYC_PER_REQ_DELIVERY') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: (near initialization for 'hubp_mask.QoS_LEVEL_FIXED') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: (near initialization for 'hubp_mask.QoS_RAMP_DISABLE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:625:3: warning: (near initialization for 'hubp_mask.REFCYC_PER_REQ_DELIVERY_PRE') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:647:3: warning: initialized field overwritten [-Woverride-init] dpp_regs(0), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:647:3: warning: (near initialization for 'dpp_regs[0].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:647:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:647:3: warning: (near initialization for 'dpp_regs[0].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:647:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:647:3: warning: (near initialization for 'dpp_regs[0].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:648:3: warning: initialized field overwritten [-Woverride-init] dpp_regs(1), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:648:3: warning: (near initialization for 'dpp_regs[1].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:648:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:648:3: warning: (near initialization for 'dpp_regs[1].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:648:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:648:3: warning: (near initialization for 'dpp_regs[1].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:649:3: warning: initialized field overwritten [-Woverride-init] dpp_regs(2), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:649:3: warning: (near initialization for 'dpp_regs[2].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:649:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:649:3: warning: (near initialization for 'dpp_regs[2].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:649:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:649:3: warning: (near initialization for 'dpp_regs[2].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:650:3: warning: initialized field overwritten [-Woverride-init] dpp_regs(3), ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:650:3: warning: (near initialization for 'dpp_regs[3].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:650:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:650:3: warning: (near initialization for 'dpp_regs[3].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:650:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:650:3: warning: (near initialization for 'dpp_regs[3].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:651:3: warning: initialized field overwritten [-Woverride-init] dpp_regs(4) ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:651:3: warning: (near initialization for 'dpp_regs[4].CM_GAMCOR_LUT_INDEX') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:651:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:651:3: warning: (near initialization for 'dpp_regs[4].CURSOR_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:651:3: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:651:3: warning: (near initialization for 'dpp_regs[4].CM_BLNDGAM_CONTROL') [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn302/dcn302_resource.c:655:3: warning: initialized field overwritten [-Woverride-init] DPP_REG_LIST_SH_MASK_DCN30(__SHIFT) ^ vim +122 drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.c 3a83e4e64bb152 Roman Li 2020-09-29 95 3a83e4e64bb152 Roman Li 2020-09-29 96 void vg_update_clocks(struct clk_mgr *clk_mgr_base, 3a83e4e64bb152 Roman Li 2020-09-29 97 struct dc_state *context, 3a83e4e64bb152 Roman Li 2020-09-29 98 bool safe_to_lower) 3a83e4e64bb152 Roman Li 2020-09-29 99 { 3a83e4e64bb152 Roman Li 2020-09-29 100 struct clk_mgr_internal *clk_mgr = TO_CLK_MGR_INTERNAL(clk_mgr_base); 3a83e4e64bb152 Roman Li 2020-09-29 101 struct dc_clocks *new_clocks = &context->bw_ctx.bw.dcn.clk; 3a83e4e64bb152 Roman Li 2020-09-29 102 struct dc *dc = clk_mgr_base->ctx->dc; 3a83e4e64bb152 Roman Li 2020-09-29 103 int display_count; 3a83e4e64bb152 Roman Li 2020-09-29 104 bool update_dppclk = false; 3a83e4e64bb152 Roman Li 2020-09-29 105 bool update_dispclk = false; 3a83e4e64bb152 Roman Li 2020-09-29 106 bool dpp_clock_lowered = false; 3a83e4e64bb152 Roman Li 2020-09-29 107 3a83e4e64bb152 Roman Li 2020-09-29 108 if (dc->work_arounds.skip_clock_update) 3a83e4e64bb152 Roman Li 2020-09-29 109 return; 3a83e4e64bb152 Roman Li 2020-09-29 110 3a83e4e64bb152 Roman Li 2020-09-29 111 /* 3a83e4e64bb152 Roman Li 2020-09-29 112 * if it is safe to lower, but we are already in the lower state, we don't have to do anything 3a83e4e64bb152 Roman Li 2020-09-29 113 * also if safe to lower is false, we just go in the higher state 3a83e4e64bb152 Roman Li 2020-09-29 114 */ 3a83e4e64bb152 Roman Li 2020-09-29 115 if (safe_to_lower) { 3a83e4e64bb152 Roman Li 2020-09-29 116 /* check that we're not already in lower */ 3a83e4e64bb152 Roman Li 2020-09-29 117 if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_LOW_POWER) { 3a83e4e64bb152 Roman Li 2020-09-29 118 3a83e4e64bb152 Roman Li 2020-09-29 119 display_count = vg_get_active_display_cnt_wa(dc, context); 3a83e4e64bb152 Roman Li 2020-09-29 120 /* if we can go lower, go lower */ 3a83e4e64bb152 Roman Li 2020-09-29 121 if (display_count == 0) { 3a83e4e64bb152 Roman Li 2020-09-29 @122 union display_idle_optimization_u idle_info = { 0 }; 3a83e4e64bb152 Roman Li 2020-09-29 123 3a83e4e64bb152 Roman Li 2020-09-29 124 idle_info.idle_info.df_request_disabled = 1; 3a83e4e64bb152 Roman Li 2020-09-29 125 idle_info.idle_info.phy_ref_clk_off = 1; 3a83e4e64bb152 Roman Li 2020-09-29 126 3a83e4e64bb152 Roman Li 2020-09-29 127 dcn301_smu_set_display_idle_optimization(clk_mgr, idle_info.data); 3a83e4e64bb152 Roman Li 2020-09-29 128 /* update power state */ 3a83e4e64bb152 Roman Li 2020-09-29 129 clk_mgr_base->clks.pwr_state = DCN_PWR_STATE_LOW_POWER; 3a83e4e64bb152 Roman Li 2020-09-29 130 } 3a83e4e64bb152 Roman Li 2020-09-29 131 } 3a83e4e64bb152 Roman Li 2020-09-29 132 } else { 3a83e4e64bb152 Roman Li 2020-09-29 133 /* check that we're not already in D0 */ 3a83e4e64bb152 Roman Li 2020-09-29 134 if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_MISSION_MODE) { 3a83e4e64bb152 Roman Li 2020-09-29 135 union display_idle_optimization_u idle_info = { 0 }; 3a83e4e64bb152 Roman Li 2020-09-29 136 3a83e4e64bb152 Roman Li 2020-09-29 137 dcn301_smu_set_display_idle_optimization(clk_mgr, idle_info.data); 3a83e4e64bb152 Roman Li 2020-09-29 138 /* update power state */ 3a83e4e64bb152 Roman Li 2020-09-29 139 clk_mgr_base->clks.pwr_state = DCN_PWR_STATE_MISSION_MODE; 3a83e4e64bb152 Roman Li 2020-09-29 140 } 3a83e4e64bb152 Roman Li 2020-09-29 141 } 3a83e4e64bb152 Roman Li 2020-09-29 142 3a83e4e64bb152 Roman Li 2020-09-29 143 if (should_set_clock(safe_to_lower, new_clocks->dcfclk_khz, clk_mgr_base->clks.dcfclk_khz)) { 3a83e4e64bb152 Roman Li 2020-09-29 144 clk_mgr_base->clks.dcfclk_khz = new_clocks->dcfclk_khz; 3a83e4e64bb152 Roman Li 2020-09-29 145 dcn301_smu_set_hard_min_dcfclk(clk_mgr, clk_mgr_base->clks.dcfclk_khz); 3a83e4e64bb152 Roman Li 2020-09-29 146 } 3a83e4e64bb152 Roman Li 2020-09-29 147 3a83e4e64bb152 Roman Li 2020-09-29 148 if (should_set_clock(safe_to_lower, 3a83e4e64bb152 Roman Li 2020-09-29 149 new_clocks->dcfclk_deep_sleep_khz, clk_mgr_base->clks.dcfclk_deep_sleep_khz)) { 3a83e4e64bb152 Roman Li 2020-09-29 150 clk_mgr_base->clks.dcfclk_deep_sleep_khz = new_clocks->dcfclk_deep_sleep_khz; 3a83e4e64bb152 Roman Li 2020-09-29 151 dcn301_smu_set_min_deep_sleep_dcfclk(clk_mgr, clk_mgr_base->clks.dcfclk_deep_sleep_khz); 3a83e4e64bb152 Roman Li 2020-09-29 152 } 3a83e4e64bb152 Roman Li 2020-09-29 153 3a83e4e64bb152 Roman Li 2020-09-29 154 // workaround: Limit dppclk to 100Mhz to avoid lower eDP panel switch to plus 4K monitor underflow. 3a83e4e64bb152 Roman Li 2020-09-29 155 if (!IS_DIAG_DC(dc->ctx->dce_environment)) { 3a83e4e64bb152 Roman Li 2020-09-29 156 if (new_clocks->dppclk_khz < 100000) 3a83e4e64bb152 Roman Li 2020-09-29 157 new_clocks->dppclk_khz = 100000; 3a83e4e64bb152 Roman Li 2020-09-29 158 } 3a83e4e64bb152 Roman Li 2020-09-29 159 3a83e4e64bb152 Roman Li 2020-09-29 160 if (should_set_clock(safe_to_lower, new_clocks->dppclk_khz, clk_mgr->base.clks.dppclk_khz)) { 3a83e4e64bb152 Roman Li 2020-09-29 161 if (clk_mgr->base.clks.dppclk_khz > new_clocks->dppclk_khz) 3a83e4e64bb152 Roman Li 2020-09-29 162 dpp_clock_lowered = true; 3a83e4e64bb152 Roman Li 2020-09-29 163 clk_mgr_base->clks.dppclk_khz = new_clocks->dppclk_khz; 3a83e4e64bb152 Roman Li 2020-09-29 164 update_dppclk = true; 3a83e4e64bb152 Roman Li 2020-09-29 165 } 3a83e4e64bb152 Roman Li 2020-09-29 166 3a83e4e64bb152 Roman Li 2020-09-29 167 if (should_set_clock(safe_to_lower, new_clocks->dispclk_khz, clk_mgr_base->clks.dispclk_khz)) { 3a83e4e64bb152 Roman Li 2020-09-29 168 clk_mgr_base->clks.dispclk_khz = new_clocks->dispclk_khz; 3a83e4e64bb152 Roman Li 2020-09-29 169 dcn301_smu_set_dispclk(clk_mgr, clk_mgr_base->clks.dispclk_khz); 3a83e4e64bb152 Roman Li 2020-09-29 170 3a83e4e64bb152 Roman Li 2020-09-29 171 update_dispclk = true; 3a83e4e64bb152 Roman Li 2020-09-29 172 } 3a83e4e64bb152 Roman Li 2020-09-29 173 3a83e4e64bb152 Roman Li 2020-09-29 174 if (dpp_clock_lowered) { 3a83e4e64bb152 Roman Li 2020-09-29 175 // increase per DPP DTO before lowering global dppclk 3a83e4e64bb152 Roman Li 2020-09-29 176 dcn20_update_clocks_update_dpp_dto(clk_mgr, context, safe_to_lower); 3a83e4e64bb152 Roman Li 2020-09-29 177 dcn301_smu_set_dppclk(clk_mgr, clk_mgr_base->clks.dppclk_khz); 3a83e4e64bb152 Roman Li 2020-09-29 178 } else { 3a83e4e64bb152 Roman Li 2020-09-29 179 // increase global DPPCLK before lowering per DPP DTO 3a83e4e64bb152 Roman Li 2020-09-29 180 if (update_dppclk || update_dispclk) 3a83e4e64bb152 Roman Li 2020-09-29 181 dcn301_smu_set_dppclk(clk_mgr, clk_mgr_base->clks.dppclk_khz); 3a83e4e64bb152 Roman Li 2020-09-29 182 // always update dtos unless clock is lowered and not safe to lower 3a83e4e64bb152 Roman Li 2020-09-29 183 if (new_clocks->dppclk_khz >= dc->current_state->bw_ctx.bw.dcn.clk.dppclk_khz) 3a83e4e64bb152 Roman Li 2020-09-29 184 dcn20_update_clocks_update_dpp_dto(clk_mgr, context, safe_to_lower); 3a83e4e64bb152 Roman Li 2020-09-29 185 } 3a83e4e64bb152 Roman Li 2020-09-29 186 } 3a83e4e64bb152 Roman Li 2020-09-29 187 :::::: The code at line 122 was first introduced by commit :::::: 3a83e4e64bb1522ddac67ffc787d1c38291e1a65 drm/amd/display: Add dcn3.01 support to DC (v2) :::::: TO: Roman Li <Roman.Li(a)amd.com&gt; :::::: CC: Alex Deucher <alexander.deucher(a)amd.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org