tree:
https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/cleanup
head: 4175235011656e04fd490a748b020763f437b721
commit: 4175235011656e04fd490a748b020763f437b721 [3/3] rcu/tree: Use
irq_work_queue_remote()
config: arm-randconfig-r022-20210112 (attached as .config)
compiler: clang version 12.0.0 (
https://github.com/llvm/llvm-project
32bcfcda4e28375e5a85268d2acfabcfcc011abf)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
#
https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue
https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/cleanup
git checkout 4175235011656e04fd490a748b020763f437b721
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> kernel/rcu/tree.c:1329:5: error: implicit declaration of function
'irq_work_queue_remote' [-Werror,-Wimplicit-function-declaration]
irq_work_queue_remote(rdp->cpu, &rdp->rcu_iw);
^
kernel/rcu/tree.c:1329:5: note: did you mean 'irq_work_queue_on'?
include/linux/irq_work.h:52:6: note: 'irq_work_queue_on' declared here
bool irq_work_queue_on(struct irq_work *work, int cpu);
^
1 error generated.
vim +/irq_work_queue_remote +1329 kernel/rcu/tree.c
1204
1205 /*
1206 * Return true if the specified CPU has passed through a quiescent
1207 * state by virtue of being in or having passed through an dynticks
1208 * idle state since the last call to dyntick_save_progress_counter()
1209 * for this same CPU, or by virtue of having been offline.
1210 */
1211 static int rcu_implicit_dynticks_qs(struct rcu_data *rdp)
1212 {
1213 unsigned long jtsq;
1214 bool *rnhqp;
1215 bool *ruqp;
1216 struct rcu_node *rnp = rdp->mynode;
1217
1218 raw_lockdep_assert_held_rcu_node(rnp);
1219
1220 /*
1221 * If the CPU passed through or entered a dynticks idle phase with
1222 * no active irq/NMI handlers, then we can safely pretend that the CPU
1223 * already acknowledged the request to pass through a quiescent
1224 * state. Either way, that CPU cannot possibly be in an RCU
1225 * read-side critical section that started before the beginning
1226 * of the current RCU grace period.
1227 */
1228 if (rcu_dynticks_in_eqs_since(rdp, rdp->dynticks_snap)) {
1229 trace_rcu_fqs(rcu_state.name, rdp->gp_seq, rdp->cpu,
TPS("dti"));
1230 rcu_gpnum_ovf(rnp, rdp);
1231 return 1;
1232 }
1233
1234 /*
1235 * Complain if a CPU that is considered to be offline from RCU's
1236 * perspective has not yet reported a quiescent state. After all,
1237 * the offline CPU should have reported a quiescent state during
1238 * the CPU-offline process, or, failing that, by rcu_gp_init()
1239 * if it ran concurrently with either the CPU going offline or the
1240 * last task on a leaf rcu_node structure exiting its RCU read-side
1241 * critical section while all CPUs corresponding to that structure
1242 * are offline. This added warning detects bugs in any of these
1243 * code paths.
1244 *
1245 * The rcu_node structure's ->lock is held here, which excludes
1246 * the relevant portions the CPU-hotplug code, the grace-period
1247 * initialization code, and the rcu_read_unlock() code paths.
1248 *
1249 * For more detail, please refer to the "Hotplug CPU" section
1250 * of RCU's Requirements documentation.
1251 */
1252 if (WARN_ON_ONCE(!(rdp->grpmask & rcu_rnp_online_cpus(rnp)))) {
1253 bool onl;
1254 struct rcu_node *rnp1;
1255
1256 pr_info("%s: grp: %d-%d level: %d ->gp_seq %ld ->completedqs
%ld\n",
1257 __func__, rnp->grplo, rnp->grphi, rnp->level,
1258 (long)rnp->gp_seq, (long)rnp->completedqs);
1259 for (rnp1 = rnp; rnp1; rnp1 = rnp1->parent)
1260 pr_info("%s: %d:%d ->qsmask %#lx ->qsmaskinit %#lx
->qsmaskinitnext %#lx ->rcu_gp_init_mask %#lx\n",
1261 __func__, rnp1->grplo, rnp1->grphi, rnp1->qsmask, rnp1->qsmaskinit,
rnp1->qsmaskinitnext, rnp1->rcu_gp_init_mask);
1262 onl = !!(rdp->grpmask & rcu_rnp_online_cpus(rnp));
1263 pr_info("%s %d: %c online: %ld(%d) offline: %ld(%d)\n",
1264 __func__, rdp->cpu, ".o"[onl],
1265 (long)rdp->rcu_onl_gp_seq, rdp->rcu_onl_gp_flags,
1266 (long)rdp->rcu_ofl_gp_seq, rdp->rcu_ofl_gp_flags);
1267 return 1; /* Break things loose after complaining. */
1268 }
1269
1270 /*
1271 * A CPU running for an extended time within the kernel can
1272 * delay RCU grace periods: (1) At age jiffies_to_sched_qs,
1273 * set .rcu_urgent_qs, (2) At age 2*jiffies_to_sched_qs, set
1274 * both .rcu_need_heavy_qs and .rcu_urgent_qs. Note that the
1275 * unsynchronized assignments to the per-CPU rcu_need_heavy_qs
1276 * variable are safe because the assignments are repeated if this
1277 * CPU failed to pass through a quiescent state. This code
1278 * also checks .jiffies_resched in case jiffies_to_sched_qs
1279 * is set way high.
1280 */
1281 jtsq = READ_ONCE(jiffies_to_sched_qs);
1282 ruqp = per_cpu_ptr(&rcu_data.rcu_urgent_qs, rdp->cpu);
1283 rnhqp = &per_cpu(rcu_data.rcu_need_heavy_qs, rdp->cpu);
1284 if (!READ_ONCE(*rnhqp) &&
1285 (time_after(jiffies, rcu_state.gp_start + jtsq * 2) ||
1286 time_after(jiffies, rcu_state.jiffies_resched) ||
1287 rcu_state.cbovld)) {
1288 WRITE_ONCE(*rnhqp, true);
1289 /* Store rcu_need_heavy_qs before rcu_urgent_qs. */
1290 smp_store_release(ruqp, true);
1291 } else if (time_after(jiffies, rcu_state.gp_start + jtsq)) {
1292 WRITE_ONCE(*ruqp, true);
1293 }
1294
1295 /*
1296 * NO_HZ_FULL CPUs can run in-kernel without rcu_sched_clock_irq!
1297 * The above code handles this, but only for straight cond_resched().
1298 * And some in-kernel loops check need_resched() before calling
1299 * cond_resched(), which defeats the above code for CPUs that are
1300 * running in-kernel with scheduling-clock interrupts disabled.
1301 * So hit them over the head with the resched_cpu() hammer!
1302 */
1303 if (tick_nohz_full_cpu(rdp->cpu) &&
1304 (time_after(jiffies, READ_ONCE(rdp->last_fqs_resched) + jtsq * 3) ||
1305 rcu_state.cbovld)) {
1306 WRITE_ONCE(*ruqp, true);
1307 resched_cpu(rdp->cpu);
1308 WRITE_ONCE(rdp->last_fqs_resched, jiffies);
1309 }
1310
1311 /*
1312 * If more than halfway to RCU CPU stall-warning time, invoke
1313 * resched_cpu() more frequently to try to loosen things up a bit.
1314 * Also check to see if the CPU is getting hammered with interrupts,
1315 * but only once per grace period, just to keep the IPIs down to
1316 * a dull roar.
1317 */
1318 if (time_after(jiffies, rcu_state.jiffies_resched)) {
1319 if (time_after(jiffies,
1320 READ_ONCE(rdp->last_fqs_resched) + jtsq)) {
1321 resched_cpu(rdp->cpu);
1322 WRITE_ONCE(rdp->last_fqs_resched, jiffies);
1323 }
1324 if (!rdp->rcu_iw_pending && rdp->rcu_iw_gp_seq != rnp->gp_seq
&&
1325 (rnp->ffmask & rdp->grpmask)) {
1326 rdp->rcu_iw_gp_seq = rnp->gp_seq;
1327 if (likely(rdp->cpu != smp_processor_id())) {
1328 rdp->rcu_iw_pending = true;
1329 irq_work_queue_remote(rdp->cpu, &rdp->rcu_iw);
1330 }
1331 }
1332 }
1333
1334 return 0;
1335 }
1336
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org