[kbuild-all] [brauner:idmapped_mounts 16/42] fs/xattr.c:623:2: warning: this 'if' clause does not guard...

tree: https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git idmapped_mounts head: 68489ddb268414e49a819222cd2cd853b4e676d8 commit: e1ad57afed599152f4681d1ed69abdfd4854b105 [16/42] xattr: handle idmapped mounts config: h8300-randconfig-r025-20210120 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/... git remote add brauner https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git git fetch --no-tags brauner idmapped_mounts git checkout e1ad57afed599152f4681d1ed69abdfd4854b105 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): fs/xattr.c: In function '__do_sys_fsetxattr': 623 | if (!error) | ^~ fs/xattr.c:627:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 627 | mnt_drop_write_file(f.file); | ^~~~~~~~~~~~~~~~~~~ vim +/if +623 fs/xattr.c 612 613 SYSCALL_DEFINE5(fsetxattr, int, fd, const char __user *, name, 614 const void __user *,value, size_t, size, int, flags) 615 { 616 struct fd f = fdget(fd); 617 int error = -EBADF; 618 619 if (!f.file) 620 return error; 621 audit_file(f.file); 622 error = mnt_want_write_file(f.file); 624 error = setxattr(file_mnt_user_ns(f.file), 625 f.file->f_path.dentry, name, 626 value, size, flags); 627 mnt_drop_write_file(f.file); 628 fdput(f); 629 return error; 630 } 631 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org