[kbuild-all] Re: [PATCHv4 2/2] arm64/io: Add a header for mmio access instrumentation

Hi Sai, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rostedt-trace/for-next] [also build test WARNING on arm64/for-next/core arm-perf/for-next/perf v5.16-rc1 next-20211118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sai-Prakash-Ranjan/tracing-rwmmi... base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next config: csky-randconfig-r005-20211118 (attached as .config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b3765baa5dcf19d695332a310cf29d7ab... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sai-Prakash-Ranjan/tracing-rwmmio-arm64-Add-support-to-trace-register-reads-writes/20211115-193645 git checkout b3765baa5dcf19d695332a310cf29d7abd39ad73 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash kernel/trace/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from include/linux/bitops.h:33, from include/linux/kernel.h:12, from include/linux/interrupt.h:6, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: arch/csky/include/asm/bitops.h:77: warning: "__clear_bit" redefined 77 | #define __clear_bit(nr, vaddr) clear_bit(nr, vaddr) | In file included from arch/csky/include/asm/bitops.h:76, from include/linux/bitops.h:33, from include/linux/kernel.h:12, from include/linux/interrupt.h:6, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/bitops/non-atomic.h:34: note: this is the location of the previous definition 34 | #define __clear_bit arch___clear_bit | In file included from kernel/trace/trace_readwrite.c:9: 32 | #define __raw_writeb(v, a) __raw_write((v), a, b) | In file included from arch/csky/include/asm/io.h:42, from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from ./arch/csky/include/generated/asm/hardirq.h:1, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/io.h:108: note: this is the location of the previous definition 108 | #define __raw_writeb __raw_writeb | In file included from kernel/trace/trace_readwrite.c:9: 33 | #define __raw_writew(v, a) __raw_write((v), a, w) | In file included from arch/csky/include/asm/io.h:42, from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from ./arch/csky/include/generated/asm/hardirq.h:1, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/io.h:116: note: this is the location of the previous definition 116 | #define __raw_writew __raw_writew | In file included from kernel/trace/trace_readwrite.c:9: 34 | #define __raw_writel(v, a) __raw_write((v), a, l) | In file included from arch/csky/include/asm/io.h:42, from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from ./arch/csky/include/generated/asm/hardirq.h:1, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/io.h:124: note: this is the location of the previous definition 124 | #define __raw_writel __raw_writel | In file included from kernel/trace/trace_readwrite.c:9: 46 | #define __raw_readb(a) __raw_read((a), b, u8) | In file included from arch/csky/include/asm/io.h:42, from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from ./arch/csky/include/generated/asm/hardirq.h:1, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/io.h:74: note: this is the location of the previous definition 74 | #define __raw_readb __raw_readb | In file included from kernel/trace/trace_readwrite.c:9: 47 | #define __raw_readw(a) __raw_read((a), w, u16) | In file included from arch/csky/include/asm/io.h:42, from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from ./arch/csky/include/generated/asm/hardirq.h:1, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/io.h:82: note: this is the location of the previous definition 82 | #define __raw_readw __raw_readw | In file included from kernel/trace/trace_readwrite.c:9: 48 | #define __raw_readl(a) __raw_read((a), l, u32) | In file included from arch/csky/include/asm/io.h:42, from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from ./arch/csky/include/generated/asm/hardirq.h:1, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from include/linux/trace_recursion.h:5, from include/linux/ftrace.h:10, from kernel/trace/trace_readwrite.c:8: include/asm-generic/io.h:90: note: this is the location of the previous definition 90 | #define __raw_readl __raw_readl | In file included from include/trace/define_trace.h:102, from include/trace/events/rwmmio.h:59, from kernel/trace/trace_readwrite.c:13: include/trace/events/rwmmio.h: In function 'trace_event_raw_event_rwmmio_write': 27 | __entry->addr = (u64)(void *)addr; | ^ include/trace/trace_events.h:743:11: note: in definition of macro 'DECLARE_EVENT_CLASS' 743 | { assign; } \ | ^~~~~~ include/trace/trace_events.h:79:30: note: in expansion of macro 'PARAMS' 79 | PARAMS(assign), \ | ^~~~~~ include/trace/events/rwmmio.h:13:1: note: in expansion of macro 'TRACE_EVENT' 13 | TRACE_EVENT(rwmmio_write, | ^~~~~~~~~~~ include/trace/events/rwmmio.h:25:9: note: in expansion of macro 'TP_fast_assign' 25 | TP_fast_assign( | ^~~~~~~~~~~~~~ include/trace/events/rwmmio.h: In function 'trace_event_raw_event_rwmmio_read': include/trace/events/rwmmio.h:49:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 49 | __entry->addr = (u64)(void *)addr; | ^ include/trace/trace_events.h:743:11: note: in definition of macro 'DECLARE_EVENT_CLASS' 743 | { assign; } \ | ^~~~~~ include/trace/trace_events.h:79:30: note: in expansion of macro 'PARAMS' 79 | PARAMS(assign), \ | ^~~~~~ include/trace/events/rwmmio.h:35:1: note: in expansion of macro 'TRACE_EVENT' 35 | TRACE_EVENT(rwmmio_read, | ^~~~~~~~~~~ include/trace/events/rwmmio.h:47:9: note: in expansion of macro 'TP_fast_assign' 47 | TP_fast_assign( | ^~~~~~~~~~~~~~ vim +/__raw_writeb +32 include/linux/mmio-instrumented.h 24 25 #define __raw_write(v, a, _l) ({ \ 26 volatile void __iomem *_a = (a); \ 27 if (tracepoint_enabled(rwmmio_write)) \ 28 log_write_mmio(__stringify(write##_l), _a); \ 29 arch_raw_write##_l((v), _a); \ 30 }) 31 35 #define __raw_writeq(v, a) __raw_write((v), a, q) 36 37 #define __raw_read(a, _l, _t) ({ \ 38 _t __a; \ 39 const volatile void __iomem *_a = (a); \ 40 if (tracepoint_enabled(rwmmio_read)) \ 41 log_read_mmio(__stringify(read##_l), _a); \ 42 __a = arch_raw_read##_l(_a); \ 43 __a; \ 44 }) 45 49 #define __raw_readq(a) __raw_read((a), q, u64) 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org