[kbuild-all] [android-common:android12-5.4 17/24] drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code.

tree: https://android.googlesource.com/kernel/common android12-5.4 head: bbf5a2eaba8de3602c3bc903f2477739ff89c631 commit: e618a51f562f1f038f31b6a4b4a250c062d70eab [17/24] ANDROID: Delete the DMA-BUF attachment sysfs statistics config: i386-randconfig-m021-20210715 (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; smatch warnings: drivers/dma-buf/dma-buf.c:728 dma_buf_attach() warn: ignoring unreachable code. vim +728 drivers/dma-buf/dma-buf.c d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 696 struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf, d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 697 struct device *dev) d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 698 { d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 699 struct dma_buf_attachment *attach; d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 700 int ret; d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 701 d1aa06a1eaf5f7 drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 702 if (WARN_ON(!dmabuf || !dev)) d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 703 return ERR_PTR(-EINVAL); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 704 db7942b6292306 drivers/dma-buf/dma-buf.c Markus Elfring 2017-05-08 705 attach = kzalloc(sizeof(*attach), GFP_KERNEL); 34d84ec4881d13 drivers/dma-buf/dma-buf.c Markus Elfring 2017-05-08 706 if (!attach) a9fbc3b73127ef drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 707 return ERR_PTR(-ENOMEM); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 708 d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 709 attach->dev = dev; d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 710 attach->dmabuf = dmabuf; 2ed9201bdd9a8e drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 711 2ed9201bdd9a8e drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 712 mutex_lock(&dmabuf->lock); 2ed9201bdd9a8e drivers/base/dma-buf.c Laurent Pinchart 2012-01-26 713 d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 714 if (dmabuf->ops->attach) { a19741e5e5a9f1 drivers/dma-buf/dma-buf.c Christian König 2018-05-28 715 ret = dmabuf->ops->attach(dmabuf, attach); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 716 if (ret) d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 717 goto err_attach; d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 718 } d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 719 list_add(&attach->node, &dmabuf->attachments); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 720 d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 721 return attach; d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 722 d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 723 err_attach: d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 724 kfree(attach); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 725 mutex_unlock(&dmabuf->lock); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 726 return ERR_PTR(ret); ^^^^^^^^^^^^^^^^^^^ 90935b28546d2c drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01 727 90935b28546d2c drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01 @728 dma_buf_detach(dmabuf, attach); Unreachable code. There is no error path where it is attached so this code can just be deleted. Also if ->attach() dif fail then we would have to remove it from the &dmabuf->attachments list. 90935b28546d2c drivers/dma-buf/dma-buf.c Hridya Valsaraju 2021-02-01 729 return ERR_PTR(ret); d15bd7ee445d07 drivers/base/dma-buf.c Sumit Semwal 2011-12-26 730 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org