5:52 p.m.
Hi Aloka,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mac80211-next/master]
[also build test WARNING on next-20200522]
[cannot apply to mac80211/master v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Aloka-Dixit/FILS-discovery-and-b...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: arm-randconfig-r024-20200524 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
> net/wireless/nl80211.c:4747:43: warning: overlapping comparisons
always evaluate to false [-Wtautological-overlap-compare]
if
(params->chandef.center_freq1 <= 5940 &&
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
1 warning generated.
vim +4747 net/wireless/nl80211.c
4737
4738 static int nl80211_parse_fd_bcastpresp(struct genl_info *info,
4739 struct cfg80211_ap_settings *params)
4740 {
4741 struct nlattr *tmpl;
4742 struct nlattr *tb[NL80211_FD_BCASTPRESP_ATTR_MAX + 1];
4743 int ret;
4744 struct cfg80211_beacon_data *beacon = ¶ms->beacon;
4745 struct cfg80211_fd_bcastpresp *cfg;
4746
4747 if (params->chandef.center_freq1 <= 5940 &&
4748 params->chandef.center_freq1 >= 7105)
4749 return -EOPNOTSUPP;
4750
4751 ret = nla_parse_nested(tb, NL80211_FD_BCASTPRESP_ATTR_MAX,
4752 info->attrs[NL80211_ATTR_FD_BCASTPRESP_CFG],
4753 fd_bcastpresp_policy, NULL);
4754 if (ret)
4755 return ret;
4756
4757 if (!tb[NL80211_FD_BCASTPRESP_ATTR_TYPE] ||
4758 !tb[NL80211_FD_BCASTPRESP_ATTR_INT])
4759 return -EINVAL;
4760
4761 cfg = ¶ms->fd_bcastpresp;
4762 cfg->type = nla_get_u8(tb[NL80211_FD_BCASTPRESP_ATTR_TYPE]);
4763 cfg->interval = nla_get_u32(tb[NL80211_FD_BCASTPRESP_ATTR_INT]);
4764
4765 tmpl = tb[NL80211_FD_BCASTPRESP_ATTR_TMPL];
4766 if (!tmpl && !beacon->fils_disc_len &&
!beacon->bcast_presp_len)
4767 return -EINVAL;
4768
4769 if (cfg->type == CFG80211_TYPE_FILS_DISCOVERY) {
4770 beacon->fils_disc = nla_data(tmpl);
4771 beacon->fils_disc_len = nla_len(tmpl);
4772 } else if (cfg->type == CFG80211_TYPE_BCAST_PROBE_RESP) {
4773 beacon->bcast_presp = nla_data(tmpl);
4774 beacon->bcast_presp_len = nla_len(tmpl);
4775 }
4776
4777 return 0;
4778 }
4779
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org