[kbuild-all] Re: [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver

Hi Jussi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jussi-Maki/XDP-bonding-support/2... base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-a011-20210617 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/61fabab38aec5b8e0cdc33867e35ea974... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jussi-Maki/XDP-bonding-support/20210617-053146 git checkout 61fabab38aec5b8e0cdc33867e35ea9740da84c8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): bond_xdp_get_xmit_slave(struct net_device *bond_dev, struct xdp_buff *xdp) ^ drivers/net/bonding/bond_main.c:4925:1: note: declare 'static' if the function is not intended to be used outside of this translation unit struct net_device * ^ static 1 warning generated. -- vim +/bond_xdp_get_xmit_slave +4926 drivers/net/bonding/bond_main.c 4924 4925 struct net_device * 4927 { 4928 struct bonding *bond = netdev_priv(bond_dev); 4929 struct slave *slave; 4930 4931 /* Caller needs to hold rcu_read_lock() */ 4932 4933 switch (BOND_MODE(bond)) { 4934 case BOND_MODE_ROUNDROBIN: 4935 slave = bond_xdp_xmit_roundrobin_slave_get(bond, xdp); 4936 break; 4937 4938 case BOND_MODE_ACTIVEBACKUP: 4939 slave = bond_xmit_activebackup_slave_get(bond); 4940 break; 4941 4942 case BOND_MODE_8023AD: 4943 case BOND_MODE_XOR: 4944 slave = bond_xdp_xmit_3ad_xor_slave_get(bond, xdp); 4945 break; 4946 4947 default: 4948 /* Should never happen. Mode guarded by bond_xdp_check() */ 4949 netdev_err(bond_dev, "Unknown bonding mode %d for xdp xmit\n", BOND_MODE(bond)); 4950 WARN_ON_ONCE(1); 4951 return NULL; 4952 } 4953 4954 if (slave) 4955 return slave->dev; 4956 4957 return NULL; 4958 } 4959 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org