9:48 a.m.
Hi Sandeep,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/testing/next]
[also build test WARNING on robh/for-next v5.8-rc4 next-20200708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Sandeep-Maheswaram/usb-dwc3-Host...
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/usb/dwc3/dwc3-qcom.c:304:20: warning: converting the
result of '<<' to a boolean always evaluates to true
[-Wtautological-constant-compare]
genpd->flags &=
!GENPD_FLAG_ACTIVE_WAKEUP;
^
include/linux/pm_domain.h:62:38: note: expanded from macro
'GENPD_FLAG_ACTIVE_WAKEUP'
#define GENPD_FLAG_ACTIVE_WAKEUP (1U << 3)
^
1 warning generated.
vim +304 drivers/usb/dwc3/dwc3-qcom.c
295
296 static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
297 {
298 int ret;
299 int i;
300 struct generic_pm_domain *genpd;
301
302 genpd = pd_to_genpd(qcom->dev->pm_domain);
303 if (genpd)
304 genpd->flags &= !GENPD_FLAG_ACTIVE_WAKEUP;
305
306 if (!qcom->is_suspended)
307 return 0;
308
309 dwc3_qcom_disable_interrupts(qcom);
310
311 for (i = 0; i < qcom->num_clocks; i++) {
312 ret = clk_prepare_enable(qcom->clks[i]);
313 if (ret < 0) {
314 while (--i >= 0)
315 clk_disable_unprepare(qcom->clks[i]);
316 return ret;
317 }
318 }
319
320 /* Clear existing events from PHY related to L2 in/out */
321 dwc3_qcom_setbits(qcom->qscratch_base, PWR_EVNT_IRQ_STAT_REG,
322 PWR_EVNT_LPM_IN_L2_MASK | PWR_EVNT_LPM_OUT_L2_MASK);
323
324 qcom->is_suspended = false;
325
326 return 0;
327 }
328
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org