5:45 p.m.
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20200721]
[also build test ERROR on v5.8-rc6]
[cannot apply to linus/master v5.8-rc6 v5.8-rc5 v5.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/hongbo-wang-nxp-com/net-dsa-ocel...
base: de2e69cfe54a8f2ed4b75f09d3110c514f45d38e
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/dsa/ocelot/felix.c: In function 'felix_vlan_add':
> drivers/net/dsa/ocelot/felix.c:139:10: error: 'const struct
switchdev_obj_port_vlan' has no member named 'proto'
139 | if
(vlan->proto == ETH_P_8021AD)
| ^~
drivers/net/dsa/ocelot/felix.c: In function 'felix_vlan_del':
drivers/net/dsa/ocelot/felix.c:165:10: error: 'const struct
switchdev_obj_port_vlan' has no member named 'proto'
165 | if (vlan->proto == ETH_P_8021AD)
| ^~
vim +139 drivers/net/dsa/ocelot/felix.c
129
130 static void felix_vlan_add(struct dsa_switch *ds, int port,
131 const struct switchdev_obj_port_vlan *vlan)
132 {
133 struct ocelot *ocelot = ds->priv;
134 u16 flags = vlan->flags;
135 struct ocelot_port *ocelot_port = ocelot->ports[port];
136 u16 vid;
137 int err;
138
139 if (vlan->proto == ETH_P_8021AD)
140 ocelot_port->qinq_mode = true;
141
142 if (dsa_is_cpu_port(ds, port))
143 flags &= ~BRIDGE_VLAN_INFO_UNTAGGED;
144
145 for (vid = vlan->vid_begin; vid <= vlan->vid_end; vid++) {
146 err = ocelot_vlan_add(ocelot, port, vid,
147 flags & BRIDGE_VLAN_INFO_PVID,
148 flags & BRIDGE_VLAN_INFO_UNTAGGED);
149 if (err) {
150 dev_err(ds->dev, "Failed to add VLAN %d to port %d: %d\n",
151 vid, port, err);
152 return;
153 }
154 }
155 }
156
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org