From d8fa5e61187dbe851b8da9c65a5df5ec5809f8ea Mon Sep 17 00:00:00 2001 From: Hannes Reinecke Date: Wed, 18 Nov 2020 08:08:41 +0100 Subject: [PATCH] megaraid_sas: use scsi_device_busy() instead of direct access to atomic counter It's always a bad style to access structure internals, especially if there is an accessor for it. So convert to use scsi_device_busy() intead of accessing the atomic counter directly. Cc: Kashyap Desai Cc: Sumanesh Samanta Signed-off-by: Hannes Reinecke --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index fd607287608e..272ff123bc6b 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -362,7 +362,7 @@ megasas_get_msix_index(struct megasas_instance *instance, /* TBD - if sml remove device_busy in future, driver * should track counter in internal structure. */ - sdev_busy = atomic_read(&scmd->device->device_busy); + sdev_busy = scsi_device_busy(scmd->device); if (instance->perf_mode == MR_BALANCED_PERF_MODE && sdev_busy > (data_arms * MR_DEVICE_HIGH_IOPS_DEPTH)) { -- 2.26.2