10:46 p.m.
Hi Wyatt,
FYI, the error/warning still remains.
tree: https://github.com/intel/linux-intel-lts.git 5.10/yocto
head: 1941d4b82f36cc6ecc513f3e496ad62726d00514
commit: 42e7487e09a6c68c1e22340048eb99a987e986f5 [16678/20368] drm/amd/display: Add ETW
log to dmub_psr_get_state
config: x86_64-randconfig-a011
(https://download.01.org/0day-ci/archive/20220114/202201141941.Xz1wEOGq-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/intel/linux-intel-lts/commit/42e7487e09a6c68c1e2234004...
git remote add intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-lts 5.10/yocto
git checkout 42e7487e09a6c68c1e22340048eb99a987e986f5
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/ drivers/gpu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c: In function
'dmub_psr_get_state':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:25:
warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
113 | *state, retry_count);
| ^
vim +/else +113 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c
78
79 /*
80 * Get PSR state from firmware.
81 */
82 static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state,
uint8_t panel_inst)
83 {
84 struct dmub_srv *srv = dmub->ctx->dmub_srv->dmub;
85 uint32_t raw_state = 0;
86 uint32_t retry_count = 0;
87 enum dmub_status status;
88
89 do {
90 // Send gpint command and wait for ack
91 status = dmub_srv_send_gpint_command(srv, DMUB_GPINT__GET_PSR_STATE, panel_inst,
30);
92
93 if (status == DMUB_STATUS_OK) {
94 // GPINT was executed, get response
95 dmub_srv_get_gpint_response(srv, &raw_state);
96 *state = convert_psr_state(raw_state);
97 } else
98 // Return invalid state when GPINT times out
99 *state = PSR_STATE_INVALID;
100
101 } while (++retry_count <= 1000 && *state == PSR_STATE_INVALID);
102
103 // Assert if max retry hit
104 if (retry_count >= 1000 && *state == PSR_STATE_INVALID) {
105 ASSERT(0);
106 DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
107 WPP_BIT_FLAG_Firmware_PsrState,
108 "Unable to get PSR state from FW.");
109 } else
110 DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_VERBOSE,
111 WPP_BIT_FLAG_Firmware_PsrState,
112 "Got PSR state from FW. PSR state: %d, Retry count: %d",
113 *state, retry_count);
114 }
115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org