8:11 a.m.
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.7-rc3 next-20200430]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/ALSA-hda-realtek-I...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: i386-randconfig-e002-20200430 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: sound/pci/hda/patch_realtek.o: in function `alc_fixup_hp_gpio_led':
> sound/pci/hda/patch_realtek.c:4146: undefined reference to
`ledtrig_audio_get'
ld: sound/pci/hda/patch_realtek.o: in function
`devm_led_classdev_register':
> include/linux/leds.h:193: undefined reference to
`devm_led_classdev_register_ext'
vim +4146 sound/pci/hda/patch_realtek.c
4124
4125 /* setup mute and mic-mute GPIO bits, add hooks appropriately */
4126 static void alc_fixup_hp_gpio_led(struct hda_codec *codec,
4127 int action,
4128 unsigned int mute_mask,
4129 unsigned int micmute_mask)
4130 {
4131 struct alc_spec *spec = codec->spec;
4132 int err;
4133
4134 alc_fixup_gpio(codec, action, mute_mask | micmute_mask);
4135
4136 if (action != HDA_FIXUP_ACT_PRE_PROBE)
4137 return;
4138 if (mute_mask) {
4139 spec->gpio_mute_led_mask = mute_mask;
4140 spec->gen.vmaster_mute.hook = alc_fixup_gpio_mute_hook;
4141 }
4142 if (micmute_mask) {
4143 spec->gpio_mic_led_mask = micmute_mask;
4144 snd_hda_gen_add_micmute_led(codec, alc_gpio_micmute_update);
4145
4146 micmute_led_cdev.brightness =
ledtrig_audio_get(LED_AUDIO_MICMUTE);
4147 err =
devm_led_classdev_register(&codec->core.dev, &micmute_led_cdev);
4148 if (err)
4149 codec_warn(codec, "failed to register micmute LED\n");
4150 }
4151 }
4152
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org