[kbuild-all] Re: [PATCH v3 3/7] drivers: thermal: tsens: add ipq8064 support

Hi Ansuel, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on clk/clk-next linus/master v5.8-rc5 next-20200715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/Add-support-for-ipq... base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: x86_64-allyesconfig (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/thermal/qcom/tsens.c:385:13: warning: no previous prototype for function 'tsens_critical_irq_thread' [-Wmissing-prototypes] irqreturn_t tsens_critical_irq_thread(int irq, void *data) ^ drivers/thermal/qcom/tsens.c:385:1: note: declare 'static' if the function is not intended to be used outside of this translation unit irqreturn_t tsens_critical_irq_thread(int irq, void *data) ^ static drivers/thermal/qcom/tsens.c:455:13: warning: no previous prototype for function 'tsens_irq_thread' [-Wmissing-prototypes] irqreturn_t tsens_irq_thread(int irq, void *data) ^ drivers/thermal/qcom/tsens.c:455:1: note: declare 'static' if the function is not intended to be used outside of this translation unit irqreturn_t tsens_irq_thread(int irq, void *data) ^ static drivers/thermal/qcom/tsens.c:523:5: warning: no previous prototype for function 'tsens_set_trips' [-Wmissing-prototypes] int tsens_set_trips(void *_sensor, int low, int high) ^ drivers/thermal/qcom/tsens.c:523:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int tsens_set_trips(void *_sensor, int low, int high) ^ static drivers/thermal/qcom/tsens.c:560:5: warning: no previous prototype for function 'tsens_enable_irq' [-Wmissing-prototypes] int tsens_enable_irq(struct tsens_priv *priv) ^ drivers/thermal/qcom/tsens.c:560:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int tsens_enable_irq(struct tsens_priv *priv) ^ static drivers/thermal/qcom/tsens.c:573:6: warning: no previous prototype for function 'tsens_disable_irq' [-Wmissing-prototypes] void tsens_disable_irq(struct tsens_priv *priv) ^ drivers/thermal/qcom/tsens.c:573:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void tsens_disable_irq(struct tsens_priv *priv) ^ static .data = &data_8060, ^~~~~~~~~ data_8960 drivers/thermal/qcom/tsens.h:585:31: note: 'data_8960' declared here extern struct tsens_plat_data data_8960; ^ } { ^ drivers/thermal/qcom/tsens.c:896:50: note: to match this '{' static const struct of_device_id tsens_table[] = { ^ 5 warnings and 2 errors generated. vim +911 drivers/thermal/qcom/tsens.c 895 896 static const struct of_device_id tsens_table[] = { 897 { 898 .compatible = "qcom,msm8916-tsens", 899 .data = &data_8916, 900 }, { 901 .compatible = "qcom,msm8974-tsens", 902 .data = &data_8974, 903 }, { 904 .compatible = "qcom,msm8976-tsens", 905 .data = &data_8976, 906 }, { 907 .compatible = "qcom,msm8996-tsens", 908 .data = &data_8996, 909 }, { 910 .compatible = "qcom,ipq8064-tsens", 913 .compatible = "qcom,tsens-v1", 914 .data = &data_tsens_v1, 915 }, { 916 .compatible = "qcom,tsens-v2", 917 .data = &data_tsens_v2, 918 }, 919 {} 920 }; 921 MODULE_DEVICE_TABLE(of, tsens_table); 922 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org