[kbuild-all] Re: [PATCH v6 5/5] media: platform: mtk-mdp3: Add Mediatek MDP3 driver

Hi Moudy, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on robh/for-next linus/master mediatek/for-next v5.14-rc6 next-20210819] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Moudy-Ho/media-mediatek-support-... base: git://linuxtv.org/media_tree.git master config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6e61c65aed8f518d32d648e1cbda294c1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Moudy-Ho/media-mediatek-support-mdp3-on-mt8183-platform/20210819-151256 git checkout 6e61c65aed8f518d32d648e1cbda294c13be2a20 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): 171 | .pixelformat = V4L2_PIX_FMT_MM21, | ^~~~~~~~~~~~~~~~~ | V4L2_PIX_FMT_MT21C -- drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c: In function 'mdp_path_config_subfrm': 26 | ((ctx)->comp->ops && (ctx)->comp->ops->(op)) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:10: note: in expansion of macro 'has_op' 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:255:23: note: in expansion of macro 'call_op' 255 | ret = call_op(ctx, config_subfrm, cmd, count); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:46: error: expected identifier before '(' token 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:255:23: note: in expansion of macro 'call_op' 255 | ret = call_op(ctx, config_subfrm, cmd, count); | ^~~~~~~ 26 | ((ctx)->comp->ops && (ctx)->comp->ops->(op)) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:10: note: in expansion of macro 'has_op' 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:268:23: note: in expansion of macro 'call_op' 268 | ret = call_op(ctx, wait_comp_event, cmd); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:46: error: expected identifier before '(' token 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:268:23: note: in expansion of macro 'call_op' 268 | ret = call_op(ctx, wait_comp_event, cmd); | ^~~~~~~ 26 | ((ctx)->comp->ops && (ctx)->comp->ops->(op)) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:10: note: in expansion of macro 'has_op' 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:275:23: note: in expansion of macro 'call_op' 275 | ret = call_op(ctx, advance_subfrm, cmd, count); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:46: error: expected identifier before '(' token 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:275:23: note: in expansion of macro 'call_op' 275 | ret = call_op(ctx, advance_subfrm, cmd, count); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c: In function 'mdp_path_config': 26 | ((ctx)->comp->ops && (ctx)->comp->ops->(op)) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:10: note: in expansion of macro 'has_op' 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:298:23: note: in expansion of macro 'call_op' 298 | ret = call_op(ctx, init_comp, cmd); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:46: error: expected identifier before '(' token 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:298:23: note: in expansion of macro 'call_op' 298 | ret = call_op(ctx, init_comp, cmd); | ^~~~~~~ 26 | ((ctx)->comp->ops && (ctx)->comp->ops->(op)) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:10: note: in expansion of macro 'has_op' 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:308:23: note: in expansion of macro 'call_op' 308 | ret = call_op(ctx, config_frame, cmd, compose); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:46: error: expected identifier before '(' token 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:308:23: note: in expansion of macro 'call_op' 308 | ret = call_op(ctx, config_frame, cmd, compose); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:304:41: warning: unused variable 'compose' [-Wunused-variable] 304 | const struct v4l2_rect *compose = | ^~~~~~~ 26 | ((ctx)->comp->ops && (ctx)->comp->ops->(op)) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:10: note: in expansion of macro 'has_op' 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:322:23: note: in expansion of macro 'call_op' 322 | ret = call_op(ctx, post_process, cmd); | ^~~~~~~ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:28:46: error: expected identifier before '(' token 28 | (has_op(ctx, op) ? (ctx)->comp->ops->(op)(ctx, ##__VA_ARGS__) : 0) | ^ drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c:322:23: note: in expansion of macro 'call_op' 322 | ret = call_op(ctx, post_process, cmd); | ^~~~~~~ vim +171 drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c 12 13 static const struct mdp_format mdp_formats[] = { 14 { 15 .pixelformat = V4L2_PIX_FMT_GREY, 16 .mdp_color = MDP_COLOR_GREY, 17 .depth = { 8 }, 18 .row_depth = { 8 }, 19 .num_planes = 1, 20 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 21 }, { 22 .pixelformat = V4L2_PIX_FMT_RGB565X, 23 .mdp_color = MDP_COLOR_RGB565, 24 .depth = { 16 }, 25 .row_depth = { 16 }, 26 .num_planes = 1, 27 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 28 }, { 29 .pixelformat = V4L2_PIX_FMT_RGB565, 30 .mdp_color = MDP_COLOR_BGR565, 31 .depth = { 16 }, 32 .row_depth = { 16 }, 33 .num_planes = 1, 34 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 35 }, { 36 .pixelformat = V4L2_PIX_FMT_RGB24, 37 .mdp_color = MDP_COLOR_RGB888, 38 .depth = { 24 }, 39 .row_depth = { 24 }, 40 .num_planes = 1, 41 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 42 }, { 43 .pixelformat = V4L2_PIX_FMT_BGR24, 44 .mdp_color = MDP_COLOR_BGR888, 45 .depth = { 24 }, 46 .row_depth = { 24 }, 47 .num_planes = 1, 48 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 49 }, { 50 .pixelformat = V4L2_PIX_FMT_ABGR32, 51 .mdp_color = MDP_COLOR_BGRA8888, 52 .depth = { 32 }, 53 .row_depth = { 32 }, 54 .num_planes = 1, 55 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 56 }, { 57 .pixelformat = V4L2_PIX_FMT_ARGB32, 58 .mdp_color = MDP_COLOR_ARGB8888, 59 .depth = { 32 }, 60 .row_depth = { 32 }, 61 .num_planes = 1, 62 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 63 }, { 64 .pixelformat = V4L2_PIX_FMT_UYVY, 65 .mdp_color = MDP_COLOR_UYVY, 66 .depth = { 16 }, 67 .row_depth = { 16 }, 68 .num_planes = 1, 69 .walign = 1, 70 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 71 }, { 72 .pixelformat = V4L2_PIX_FMT_VYUY, 73 .mdp_color = MDP_COLOR_VYUY, 74 .depth = { 16 }, 75 .row_depth = { 16 }, 76 .num_planes = 1, 77 .walign = 1, 78 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 79 }, { 80 .pixelformat = V4L2_PIX_FMT_YUYV, 81 .mdp_color = MDP_COLOR_YUYV, 82 .depth = { 16 }, 83 .row_depth = { 16 }, 84 .num_planes = 1, 85 .walign = 1, 86 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 87 }, { 88 .pixelformat = V4L2_PIX_FMT_YVYU, 89 .mdp_color = MDP_COLOR_YVYU, 90 .depth = { 16 }, 91 .row_depth = { 16 }, 92 .num_planes = 1, 93 .walign = 1, 94 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 95 }, { 96 .pixelformat = V4L2_PIX_FMT_YUV420, 97 .mdp_color = MDP_COLOR_I420, 98 .depth = { 12 }, 99 .row_depth = { 8 }, 100 .num_planes = 1, 101 .walign = 1, 102 .halign = 1, 103 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 104 }, { 105 .pixelformat = V4L2_PIX_FMT_YVU420, 106 .mdp_color = MDP_COLOR_YV12, 107 .depth = { 12 }, 108 .row_depth = { 8 }, 109 .num_planes = 1, 110 .walign = 1, 111 .halign = 1, 112 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 113 }, { 114 .pixelformat = V4L2_PIX_FMT_NV12, 115 .mdp_color = MDP_COLOR_NV12, 116 .depth = { 12 }, 117 .row_depth = { 8 }, 118 .num_planes = 1, 119 .walign = 1, 120 .halign = 1, 121 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 122 }, { 123 .pixelformat = V4L2_PIX_FMT_NV21, 124 .mdp_color = MDP_COLOR_NV21, 125 .depth = { 12 }, 126 .row_depth = { 8 }, 127 .num_planes = 1, 128 .walign = 1, 129 .halign = 1, 130 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 131 }, { 132 .pixelformat = V4L2_PIX_FMT_NV16, 133 .mdp_color = MDP_COLOR_NV16, 134 .depth = { 16 }, 135 .row_depth = { 8 }, 136 .num_planes = 1, 137 .walign = 1, 138 .flags = MDP_FMT_FLAG_OUTPUT, 139 }, { 140 .pixelformat = V4L2_PIX_FMT_NV61, 141 .mdp_color = MDP_COLOR_NV61, 142 .depth = { 16 }, 143 .row_depth = { 8 }, 144 .num_planes = 1, 145 .walign = 1, 146 .flags = MDP_FMT_FLAG_OUTPUT, 147 }, { 148 .pixelformat = V4L2_PIX_FMT_NV24, 149 .mdp_color = MDP_COLOR_NV24, 150 .depth = { 24 }, 151 .row_depth = { 8 }, 152 .num_planes = 1, 153 .flags = MDP_FMT_FLAG_OUTPUT, 154 }, { 155 .pixelformat = V4L2_PIX_FMT_NV42, 156 .mdp_color = MDP_COLOR_NV42, 157 .depth = { 24 }, 158 .row_depth = { 8 }, 159 .num_planes = 1, 160 .flags = MDP_FMT_FLAG_OUTPUT, 161 }, { 162 .pixelformat = V4L2_PIX_FMT_MT21C, 163 .mdp_color = MDP_COLOR_420_BLK_UFO, 164 .depth = { 8, 4 }, 165 .row_depth = { 8, 8 }, 166 .num_planes = 2, 167 .walign = 4, 168 .halign = 5, 169 .flags = MDP_FMT_FLAG_OUTPUT, 170 }, { 172 .mdp_color = MDP_COLOR_420_BLK, 173 .depth = { 8, 4 }, 174 .row_depth = { 8, 8 }, 175 .num_planes = 2, 176 .walign = 4, 177 .halign = 5, 178 .flags = MDP_FMT_FLAG_OUTPUT, 179 }, { 180 .pixelformat = V4L2_PIX_FMT_NV12M, 181 .mdp_color = MDP_COLOR_NV12, 182 .depth = { 8, 4 }, 183 .row_depth = { 8, 8 }, 184 .num_planes = 2, 185 .walign = 1, 186 .halign = 1, 187 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 188 }, { 189 .pixelformat = V4L2_PIX_FMT_NV21M, 190 .mdp_color = MDP_COLOR_NV21, 191 .depth = { 8, 4 }, 192 .row_depth = { 8, 8 }, 193 .num_planes = 2, 194 .walign = 1, 195 .halign = 1, 196 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 197 }, { 198 .pixelformat = V4L2_PIX_FMT_NV16M, 199 .mdp_color = MDP_COLOR_NV16, 200 .depth = { 8, 8 }, 201 .row_depth = { 8, 8 }, 202 .num_planes = 2, 203 .walign = 1, 204 .flags = MDP_FMT_FLAG_OUTPUT, 205 }, { 206 .pixelformat = V4L2_PIX_FMT_NV61M, 207 .mdp_color = MDP_COLOR_NV61, 208 .depth = { 8, 8 }, 209 .row_depth = { 8, 8 }, 210 .num_planes = 2, 211 .walign = 1, 212 .flags = MDP_FMT_FLAG_OUTPUT, 213 }, { 214 .pixelformat = V4L2_PIX_FMT_YUV420M, 215 .mdp_color = MDP_COLOR_I420, 216 .depth = { 8, 2, 2 }, 217 .row_depth = { 8, 4, 4 }, 218 .num_planes = 3, 219 .walign = 1, 220 .halign = 1, 221 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 222 }, { 223 .pixelformat = V4L2_PIX_FMT_YVU420M, 224 .mdp_color = MDP_COLOR_YV12, 225 .depth = { 8, 2, 2 }, 226 .row_depth = { 8, 4, 4 }, 227 .num_planes = 3, 228 .walign = 1, 229 .halign = 1, 230 .flags = MDP_FMT_FLAG_OUTPUT | MDP_FMT_FLAG_CAPTURE, 231 } 232 }; 233 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org