3:30 p.m.
Hi "Gautham,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.10-rc7 next-20201209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/Extend-Parsing-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-r035-20201209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
1968804ac726e7674d5de22bc2204b45857da344)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
#
https://github.com/0day-ci/linux/commit/61bc65c11bf36fdc3827c6d6f4f555fba...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Gautham-R-Shenoy/Extend-Parsing-ibm-thread-groups-for-Shared-L2-information/20201210-011226
git checkout 61bc65c11bf36fdc3827c6d6f4f555fba5306bd9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro
'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:233:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/kernel/smp.c:22:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:10:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro
'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:235:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/kernel/smp.c:22:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:10:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro
'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:2:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/kernel/smp.c:22:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:10:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro
'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:4:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from arch/powerpc/kernel/smp.c:22:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:10:
In file included from arch/powerpc/include/asm/hardirq.h:6:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro
'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:6:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
arch/powerpc/kernel/smp.c:569:6: warning: no previous prototype for function
'tick_broadcast' [-Wmissing-prototypes]
void tick_broadcast(const struct cpumask *mask)
^
arch/powerpc/kernel/smp.c:569:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
void tick_broadcast(const struct cpumask *mask)
^
static
arch/powerpc/kernel/smp.c:579:6: warning: no previous prototype for function
'debugger_ipi_callback' [-Wmissing-prototypes]
void debugger_ipi_callback(struct pt_regs *regs)
^
arch/powerpc/kernel/smp.c:579:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
void debugger_ipi_callback(struct pt_regs *regs)
^
static
> arch/powerpc/kernel/smp.c:905:11: warning: variable
'mask' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
else if (cache_property ==
THREAD_GROUP_SHARE_L2)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/kernel/smp.c:908:26: note: uninitialized use occurs here
zalloc_cpumask_var_node(mask, GFP_KERNEL, cpu_to_node(cpu));
^~~~
arch/powerpc/kernel/smp.c:905:7: note: remove the 'if' if its condition is
always true
else if (cache_property == THREAD_GROUP_SHARE_L2)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/kernel/smp.c:886:21: note: initialize the variable 'mask' to
silence this warning
cpumask_var_t *mask;
^
= NULL
15 warnings generated.
vim +905 arch/powerpc/kernel/smp.c
881
882 {
883 int first_thread = cpu_first_thread_sibling(cpu);
884 int i, cpu_group_start = -1, err = 0;
885 struct thread_groups *tg = NULL;
886 cpumask_var_t *mask;
887
888 if (cache_property != THREAD_GROUP_SHARE_L1 &&
889 cache_property != THREAD_GROUP_SHARE_L2)
890 return -EINVAL;
891
892 tg = get_thread_groups(cpu, cache_property, &err);
893 if (!tg)
894 return err;
895
896 cpu_group_start = get_cpu_thread_group_start(cpu, tg);
897
898 if (unlikely(cpu_group_start == -1)) {
899 WARN_ON_ONCE(1);
900 return -ENODATA;
901 }
902
903 if (cache_property == THREAD_GROUP_SHARE_L1)
904 mask = &per_cpu(thread_group_l1_cache_map, cpu);
905 else if (cache_property == THREAD_GROUP_SHARE_L2)
906 mask = &per_cpu(thread_group_l2_cache_map, cpu);
907
908 zalloc_cpumask_var_node(mask, GFP_KERNEL, cpu_to_node(cpu));
909
910 for (i = first_thread; i < first_thread + threads_per_core; i++) {
911 int i_group_start = get_cpu_thread_group_start(i, tg);
912
913 if (unlikely(i_group_start == -1)) {
914 WARN_ON_ONCE(1);
915 return -ENODATA;
916 }
917
918 if (i_group_start == cpu_group_start)
919 cpumask_set_cpu(i, *mask);
920 }
921
922 return 0;
923 }
924
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org