[kbuild-all] Re: [PATCH net-next v5 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

Hi Alex, I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-qualcomm-rmnet-st... base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2117fce81f6b862aac0673abe8df0c60dca64bfa config: sparc64-randconfig-m031-20210315 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/34a8cce42717e61eeef72fb1ec8ebd8dc... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Alex-Elder/net-qualcomm-rmnet-stop-using-C-bit-fields/20210316-025323 git checkout 34a8cce42717e61eeef72fb1ec8ebd8dc1a4764c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_ipv4_ul_csum_header': >> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:204:13: error: 'struct rmnet_map_ul_csum_header' has no member named 'csum_insert_offset'; did you mean 'csum_start_offset'? 204 | ul_header->csum_insert_offset = skb->csum_offset; | ^~~~~~~~~~~~~~~~~~ | csum_start_offset >> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:205:11: error: 'struct rmnet_map_ul_csum_header' has no member named 'csum_enabled' 205 | ul_header->csum_enabled = 1; | ^~ >> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:207:12: error: 'struct rmnet_map_ul_csum_header' has no member named 'udp_ind' 207 | ul_header->udp_ind = 1; | ^~ drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:209:12: error: 'struct rmnet_map_ul_csum_header' has no member named 'udp_ind' 209 | ul_header->udp_ind = 0; | ^~ drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_ipv6_ul_csum_header': drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:244:13: error: 'struct rmnet_map_ul_csum_header' has no member named 'csum_insert_offset'; did you mean 'csum_start_offset'? 244 | ul_header->csum_insert_offset = skb->csum_offset; | ^~~~~~~~~~~~~~~~~~ | csum_start_offset drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:245:11: error: 'struct rmnet_map_ul_csum_header' has no member named 'csum_enabled' 245 | ul_header->csum_enabled = 1; | ^~ drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:248:12: error: 'struct rmnet_map_ul_csum_header' has no member named 'udp_ind' 248 | ul_header->udp_ind = 1; | ^~ drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:250:12: error: 'struct rmnet_map_ul_csum_header' has no member named 'udp_ind' 250 | ul_header->udp_ind = 0; | ^~ drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_checksum_uplink_packet': drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:423:13: error: 'struct rmnet_map_ul_csum_header' has no member named 'csum_insert_offset'; did you mean 'csum_start_offset'? 423 | ul_header->csum_insert_offset = 0; | ^~~~~~~~~~~~~~~~~~ | csum_start_offset drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:424:11: error: 'struct rmnet_map_ul_csum_header' has no member named 'csum_enabled' 424 | ul_header->csum_enabled = 0; | ^~ drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:425:11: error: 'struct rmnet_map_ul_csum_header' has no member named 'udp_ind' 425 | ul_header->udp_ind = 0; | ^~ vim +204 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 194 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 195 static void 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 196 rmnet_map_ipv4_ul_csum_header(void *iphdr, 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 197 struct rmnet_map_ul_csum_header *ul_header, 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 198 struct sk_buff *skb) 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 199 { 8626cbb3cd11f6 Alex Elder 2021-03-15 200 __be16 *hdr = (__be16 *)ul_header; 8626cbb3cd11f6 Alex Elder 2021-03-15 201 struct iphdr *ip4h = iphdr; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 202 8626cbb3cd11f6 Alex Elder 2021-03-15 203 ul_header->csum_start_offset = htons(skb_network_header_len(skb)); 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 @204 ul_header->csum_insert_offset = skb->csum_offset; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 @205 ul_header->csum_enabled = 1; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 206 if (ip4h->protocol == IPPROTO_UDP) a7cf3d24ee6081 Subash Abhinov Kasiviswanathan 2019-07-25 @207 ul_header->udp_ind = 1; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 208 else a7cf3d24ee6081 Subash Abhinov Kasiviswanathan 2019-07-25 209 ul_header->udp_ind = 0; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 210 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 211 /* Changing remaining fields to network order */ 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 212 hdr++; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 213 *hdr = htons((__force u16)*hdr); 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 214 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 215 skb->ip_summed = CHECKSUM_NONE; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 216 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 217 rmnet_map_complement_ipv4_txporthdr_csum_field(iphdr); 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 218 } 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 219 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org