[kbuild-all] [chrome-os:chromeos-5.4 7/19] drivers/misc/cardreader/rtsx_pcr.c:1354:2: error: implicit declaration of function 'rtsx_pci_write_config_byte'; did you mean 'pci_write_config_byte'?

Tuesday, 18 May 2021

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head:   978e7fbbffc83bacc3ff20e528999d15b8f0782a
commit: 65ab8281c6a478b8de248fdcea221ad033bb5069 [7/19] BACKPORT: misc: rtsx: Remove
rtsx_pci_read/write_config() wrappers
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add chrome-os
https://chromium.googlesource.com/chromiumos/third_party/kernel
        git fetch --no-tags chrome-os chromeos-5.4
        git checkout 65ab8281c6a478b8de248fdcea221ad033bb5069
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

Note: the chrome-os/chromeos-5.4 HEAD 978e7fbbffc83bacc3ff20e528999d15b8f0782a builds
fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/misc/cardreader/rtsx_pcr.c: In function 'rtsx_pci_init_hw':
...
> drivers/misc/cardreader/rtsx_pcr.c:1354:2: error: implicit
declaration of function 'rtsx_pci_write_config_byte'; did you mean
'pci_write_config_byte'? [-Werror=implicit-function-declaration]     1354 | 
rtsx_pci_write_config_byte(pcr, pcr->pcie_cap + PCI_EXP_LNKCTL + 1, 1);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |  pci_write_config_byte
   drivers/misc/cardreader/rtsx_pcr.c:1354:37: error: 'struct rtsx_pcr' has no
member named 'pcie_cap'
    1354 |  rtsx_pci_write_config_byte(pcr, pcr->pcie_cap + PCI_EXP_LNKCTL + 1, 1);
         |                                     ^~
...
> drivers/misc/cardreader/rtsx_pcr.c:1356:24: error: 'pdev'
undeclared (first use in this function); did you mean 'cdev'?     1356 | 
pci_write_config_byte(pdev, 0x70F, 0x5B);
         |                        ^~~~
         |                        cdev
   drivers/misc/cardreader/rtsx_pcr.c:1356:24: note: each undeclared identifier is
reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +1354 drivers/misc/cardreader/rtsx_pcr.c

5da4e04ae480aa drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2017-11-29  1251  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1252  static int
rtsx_pci_init_hw(struct rtsx_pcr *pcr)
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1253  {
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1254  	int err;
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1255  
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1256  	if
(PCI_PID(pcr) == PID_5228)
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1257 
		rtsx_pci_write_register(pcr, RTS5228_LDO1_CFG1, RTS5228_LDO1_SR_TIME_MASK,
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1258 
				RTS5228_LDO1_SR_0_5);
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1259  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1260 
	rtsx_pci_writel(pcr, RTSX_HCBAR, pcr->host_cmds_addr);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1261  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1262 
	rtsx_pci_enable_bus_int(pcr);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1263  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1264  	/* Power
on SSC */
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1265  	if
(PCI_PID(pcr) == PID_5261) {
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1266  		/*
Gating real mcu clock */
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1267  		err =
rtsx_pci_write_register(pcr, RTS5261_FW_CFG1,
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1268 
			RTS5261_MCU_CLOCK_GATING, 0);
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1269  		err =
rtsx_pci_write_register(pcr, RTS5261_REG_FPDCTL,
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1270 
			SSC_POWER_DOWN, 0);
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1271  	} else {
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1272  		err =
rtsx_pci_write_register(pcr, FPDCTL, SSC_POWER_DOWN, 0);
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1273  	}
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1274  	if (err
< 0)
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1275  		return
err;
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1276  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1277  	/* Wait
SSC power stable */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1278 
	udelay(200);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1279  
19f3bd548f2750 drivers/mfd/rtsx_pcr.c             Micky Ching 2015-02-25  1280 
	rtsx_pci_disable_aspm(pcr);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1281  	if
(pcr->ops->optimize_phy) {
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1282  		err =
pcr->ops->optimize_phy(pcr);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1283  		if (err
< 0)
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1284  			return
err;
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1285  	}
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1286  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1287 
	rtsx_pci_init_cmd(pcr);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1288  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1289  	/* Set
mcu_cnt to 7 to ensure data can be sampled properly */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1290 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CLK_DIV, 0x07, 0x07);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1291  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1292 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, HOST_SLEEP_STATE, 0x03, 0x00);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1293  	/*
Disable card clock */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1294 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CARD_CLK_EN, 0x1E, 0);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1295  	/* Reset
delink mode */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1296 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CHANGE_LINK_STATE, 0x0A, 0);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1297  	/* Card
driving select */
773ccdfd9cc6f9 drivers/mfd/rtsx_pcr.c             Wei WANG    2013-08-20  1298 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CARD_DRIVE_SEL,
773ccdfd9cc6f9 drivers/mfd/rtsx_pcr.c             Wei WANG    2013-08-20  1299  			0xFF,
pcr->card_drive_sel);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1300  	/* Enable
SSC Clock */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1301 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, SSC_CTL1,
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1302  			0xFF,
SSC_8X_EN | SSC_SEL_4M);
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1303  	if
(PCI_PID(pcr) == PID_5261)
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1304 
		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, SSC_CTL2, 0xFF,
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1305 
			RTS5261_SSC_DEPTH_2M);
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1306  	else if
(PCI_PID(pcr) == PID_5228)
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1307 
		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, SSC_CTL2, 0xFF,
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1308 
			RTS5228_SSC_DEPTH_2M);
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1309  	else
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1310 
		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, SSC_CTL2, 0xFF, 0x12);
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1311  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1312  	/*
Disable cd_pwr_save */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1313 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CHANGE_LINK_STATE, 0x16, 0x10);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1314  	/* Clear
Link Ready Interrupt */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1315 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, IRQSTAT0,
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1316 
			LINK_RDY_INT, LINK_RDY_INT);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1317  	/*
Enlarge the estimation window of PERST# glitch
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1318  	 * to
reduce the chance of invalid card interrupt
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1319  	 */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1320 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PERST_GLITCH_WIDTH, 0xFF, 0x80);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1321  	/* Update
RC oscillator to 400k
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1322  	 * bit[0]
F_HIGH: for RC oscillator, Rst_value is 1'b1
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1323  	 *       
        1: 2M  0: 400k
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1324  	 */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1325 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, RCCTL, 0x01, 0x00);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1326  	/* Set
interrupt write clear
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1327  	 * bit 1:
U_elbi_if_rd_clr_en
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1328  	 *	1:
Enable ELBI interrupt[31:22] & [7:0] flag read clear
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1329  	 *	0:
ELBI interrupt flag[31:22] & [7:0] only can be write clear
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1330  	 */
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1331 
	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, NFTS_TX_CTRL, 0x02, 0);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1332  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1333  	err =
rtsx_pci_send_cmd(pcr, 100);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1334  	if (err
< 0)
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1335  		return
err;
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1336  
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1337  	switch
(PCI_PID(pcr)) {
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1338  	case
PID_5250:
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1339  	case
PID_524A:
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1340  	case
PID_525A:
5da4e04ae480aa drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2017-11-29  1341  	case
PID_5260:
47d31170aeff3f drivers/misc/cardreader/rtsx_pcr.c Rui Feng    2019-10-21  1342  	case
PID_5261:
873a40a0c637f3 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-11  1343  	case
PID_5228:
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1344 
		rtsx_pci_write_register(pcr, PM_CLK_FORCE_CTL, 1, 1);
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1345  		break;
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1346  	default:
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1347  		break;
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1348  	}
8275b77a151316 drivers/mfd/rtsx_pcr.c             Rui Feng    2017-09-07  1349  
bede03a579b3b4 drivers/misc/cardreader/rtsx_pcr.c RickyWu     2019-02-19  1350  	/*init
ocp*/
bede03a579b3b4 drivers/misc/cardreader/rtsx_pcr.c RickyWu     2019-02-19  1351 
	rtsx_pci_init_ocp(pcr);
bede03a579b3b4 drivers/misc/cardreader/rtsx_pcr.c RickyWu     2019-02-19  1352  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1353  	/* Enable
clk_request_n to enable clock power management */
19f3bd548f2750 drivers/mfd/rtsx_pcr.c             Micky Ching 2015-02-25 @1354 
	rtsx_pci_write_config_byte(pcr, pcr->pcie_cap + PCI_EXP_LNKCTL + 1, 1);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1355  	/* Enter
L1 when host tx idle */
65ab8281c6a478 drivers/misc/cardreader/rtsx_pcr.c Ricky Wu    2021-05-12 @1356 
	pci_write_config_byte(pdev, 0x70F, 0x5B);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1357  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1358  	if
(pcr->ops->extra_init_hw) {
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1359  		err =
pcr->ops->extra_init_hw(pcr);
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1360  		if (err
< 0)
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1361  			return
err;
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1362  	}
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1363  
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1364  	/* No CD
interrupt if probing driver with card inserted.
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1365  	 * So we
need to initialize pcr->card_exist here.
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1366  	 */
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1367  	if
(pcr->ops->cd_deglitch)
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1368 
		pcr->card_exist = pcr->ops->cd_deglitch(pcr);
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1369  	else
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1370 
		pcr->card_exist = rtsx_pci_readl(pcr, RTSX_BIPR) & CARD_EXIST;
c3481955f6c78c drivers/mfd/rtsx_pcr.c             Wei WANG    2013-02-08  1371  
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1372  	return
0;
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1373  }
ada8a8a13b13a2 drivers/mfd/rtsx_pcr.c             Wei WANG    2012-10-29  1374  

:::::: The code at line 1354 was first introduced by commit
:::::: 19f3bd548f2750a8a7e4e6d2f25fdc5f8e2c3ee9 mfd: rtsx: Remove LCTLR defination

:::::: TO: Micky Ching <micky_ching(a)realsil.com.cn&gt;
:::::: CC: Lee Jones <lee.jones(a)linaro.org&gt;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019

[kbuild-all] [chrome-os:chromeos-5.4 7/19] drivers/misc/cardreader/rtsx_pcr.c:1354:2: error: implicit declaration of function 'rtsx_pci_write_config_byte'; did you mean 'pci_write_config_byte'?