[kbuild-all] drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:354:9: warning: Identical condition 'ret', second condition is always false

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dc06fe51d26efc100ac74121607c01a454867c91 commit: dfd57dbf44ddc70c90c76f83b2deb46e5dd40ce3 drm/amdgpu: add JPEG3.0 support for Sienna_Cichlid date: 6 weeks ago compiler: alpha-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; cppcheck warnings: (new ones prefixed by >>) In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/ci_smumgr.c: result = ci_get_dependency_volt_by_clk(hwmgr, ^ drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:413:9: note: Variable 'result' is reassigned a value before the old one has been used. result = ci_calculate_sclk_params(hwmgr, clock, level); ^ drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:416:9: note: Variable 'result' is reassigned a value before the old one has been used. result = ci_get_dependency_volt_by_clk(hwmgr, ^ drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:2235:9: warning: Variable 'result' is reassigned a value before the old one has been used. [redundantAssignment] result = ci_update_and_upload_mc_reg_table(hwmgr); ^ drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:2225:10: note: Variable 'result' is reassigned a value before the old one has been used. result = ci_copy_bytes_to_smc( ^ drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:2235:9: note: Variable 'result' is reassigned a value before the old one has been used. result = ci_update_and_upload_mc_reg_table(hwmgr); ^ return ret; ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:2116:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:2125:9: note: second condition return ret; ^ size += sprintf(buf + size, "Current ppfeatures: 0x%016llxn", features_enabled); ^ size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3314:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3332:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3362:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3452:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "SCLK: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3452:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "SCLK: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3458:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "MCLK: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3458:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "MCLK: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3469:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "VDDC_CURVE_SCLK[0]: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3469:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "VDDC_CURVE_SCLK[0]: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3475:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "VDDC_CURVE_SCLK[1]: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3475:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "VDDC_CURVE_SCLK[1]: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3481:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "VDDC_CURVE_SCLK[2]: %7uMhz %10uMhzn", ^ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3481:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] size += sprintf(buf + size, "VDDC_CURVE_SCLK[2]: %7uMhz %10uMhzn", ^ size += sprintf(buf + size, "%2d %14s%s:n", ^ return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:716:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:719:9: note: second condition return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1689:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit] return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1686:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1689:9: note: second condition return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1833:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit] return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1828:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1833:9: note: second condition return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1844:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit] return ret; ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1841:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1844:9: note: second condition return ret; ^ return ret; ^ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1048:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1053:9: note: second condition return ret; ^ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1073:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit] return ret; ^ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1067:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1073:9: note: second condition return ret; ^ size += sprintf(buf + size, "%2d %14s%sn", ^ size = sprintf(sn, "%llx", id); ^ return ret; ^ drivers/gpu/drm/amd/powerplay/renoir_ppt.c:402:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/renoir_ppt.c:411:9: note: second condition return ret; ^ drivers/gpu/drm/amd/powerplay/renoir_ppt.c:726:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit] return ret; ^ drivers/gpu/drm/amd/powerplay/renoir_ppt.c:723:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/powerplay/renoir_ppt.c:726:9: note: second condition return ret; ^ size += sprintf(buf + size, "%2d %14s%sn", ^ object_id = object_id_from_bios_object_id(id); ^ drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:162:0: note: Variable 'object_id' is reassigned a value before the old one has been used. struct graphics_object_id object_id = dal_graphics_object_id_init( ^ drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:184:12: note: Variable 'object_id' is reassigned a value before the old one has been used. object_id = object_id_from_bios_object_id(id); ^ result = BP_RESULT_OK; ^ drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:1043:10: note: Variable 'result' is reassigned a value before the old one has been used. result = BP_RESULT_NORECORD; ^ drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:1064:10: note: Variable 'result' is reassigned a value before the old one has been used. result = BP_RESULT_OK; ^ present = (gpio_result == GPIO_RESULT_OK) && !clock_pin; ^ drivers/gpu/drm/amd/display/dc/core/dc_link.c:359:0: note: Variable 'present' is reassigned a value before the old one has been used. bool present = ^ drivers/gpu/drm/amd/display/dc/core/dc_link.c:400:10: note: Variable 'present' is reassigned a value before the old one has been used. present = (gpio_result == GPIO_RESULT_OK) && !clock_pin; ^ if (link_stream->dpms_off) ^ return ret; ^ drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:351:6: note: first condition if (ret) ^ drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:354:9: note: second condition return ret; ^ vim +/ret +354 drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c 342 343 static int jpeg_v3_0_wait_for_idle(void *handle) 344 { 345 struct amdgpu_device *adev = (struct amdgpu_device *)handle; 346 int ret = 0; 347 348 SOC15_WAIT_ON_RREG(JPEG, 0, mmUVD_JRBC_STATUS, 349 UVD_JRBC_STATUS__RB_JOB_DONE_MASK, 350 UVD_JRBC_STATUS__RB_JOB_DONE_MASK, ret); 351 if (ret) 352 return ret; 353 355 } 356 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org