Hi Vijendar,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.7-rc6 next-20200518]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Vijendar-Mukunda/Add-Renoir-ACP-...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
sound/soc/amd/renoir/acp3x-pdm-dma.c: In function 'stop_pdm_dma':
> sound/soc/amd/renoir/acp3x-pdm-dma.c:153:34: warning: variable
'pdm_fifo_flush' set but not used [-Wunused-but-set-variable]
u32
pdm_enable, pdm_dma_enable, pdm_fifo_flush;
^~~~~~~~~~~~~~
vim +/pdm_fifo_flush +153 sound/soc/amd/renoir/acp3x-pdm-dma.c
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 150
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 151 static int stop_pdm_dma(void __iomem
*acp_base)
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 152 {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 @153 u32 pdm_enable, pdm_dma_enable,
pdm_fifo_flush;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 154 int timeout;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 155
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 156 pdm_enable = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 157 pdm_dma_enable = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 158 pdm_fifo_flush = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 159
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 160 pdm_enable = rn_readl(acp_base +
ACP_WOV_PDM_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 161 pdm_dma_enable = rn_readl(acp_base +
ACP_WOV_PDM_DMA_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 162 if (pdm_dma_enable & 0x01) {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 163 pdm_dma_enable = 0x02;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 164 rn_writel(pdm_dma_enable, acp_base +
ACP_WOV_PDM_DMA_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 165 pdm_dma_enable = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 166 timeout = 0;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 167 while (++timeout < ACP_COUNTER) {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 168 pdm_dma_enable = rn_readl(acp_base +
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 169 ACP_WOV_PDM_DMA_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 170 if ((pdm_dma_enable & 0x02) ==
0x00)
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 171 break;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 172 udelay(DELAY_US);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 173 }
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 174 if (timeout == ACP_COUNTER)
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 175 return -ETIMEDOUT;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 176 }
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 177 if (pdm_enable == ACP_PDM_ENABLE) {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 178 pdm_enable = ACP_PDM_DISABLE;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 179 rn_writel(pdm_enable, acp_base +
ACP_WOV_PDM_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 180 }
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 181 rn_writel(0x01, acp_base +
ACP_WOV_PDM_FIFO_FLUSH);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 182 return 0;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 183 }
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 184
:::::: The code at line 153 was first introduced by commit
:::::: 041ae75cda4ae7035ab23ccf422dc5229871e720 ASoC: amd: add ACP PDM DMA driver dai ops
:::::: TO: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com>
:::::: CC: 0day robot <lkp(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org