9 a.m.
Hi Linus,
I love your patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[also build test ERROR on v5.8-rc6 next-20200721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Linus-Walleij/gpio-Retire-the-ex...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/bcma/driver_gpio.c: In function 'bcma_gpio_irq_init':
> drivers/bcma/driver_gpio.c:139:9: error: implicit declaration of
function 'gpiochip_irqchip_add'; did you mean
'gpiochip_irqchip_add_domain'? [-Werror=implicit-function-declaration]
139 | err = gpiochip_irqchip_add(chip,
| ^~~~~~~~~~~~~~~~~~~~
| gpiochip_irqchip_add_domain
cc1: some warnings being treated as errors
vim +139 drivers/bcma/driver_gpio.c
2997609eb4c9e2 Rafał Miłecki 2013-12-12 121
74f4e0cc61080f Linus Walleij 2015-08-14 122 static int bcma_gpio_irq_init(struct
bcma_drv_cc *cc)
2997609eb4c9e2 Rafał Miłecki 2013-12-12 123 {
2997609eb4c9e2 Rafał Miłecki 2013-12-12 124 struct gpio_chip *chip =
&cc->gpio;
74f4e0cc61080f Linus Walleij 2015-08-14 125 int hwirq, err;
2997609eb4c9e2 Rafał Miłecki 2013-12-12 126
2997609eb4c9e2 Rafał Miłecki 2013-12-12 127 if (cc->core->bus->hosttype !=
BCMA_HOSTTYPE_SOC)
2997609eb4c9e2 Rafał Miłecki 2013-12-12 128 return 0;
2997609eb4c9e2 Rafał Miłecki 2013-12-12 129
85eb92e81801d6 Hauke Mehrtens 2014-11-01 130 hwirq = bcma_core_irq(cc->core, 0);
2997609eb4c9e2 Rafał Miłecki 2013-12-12 131 err = request_irq(hwirq,
bcma_gpio_irq_handler, IRQF_SHARED, "gpio",
2997609eb4c9e2 Rafał Miłecki 2013-12-12 132 cc);
2997609eb4c9e2 Rafał Miłecki 2013-12-12 133 if (err)
74f4e0cc61080f Linus Walleij 2015-08-14 134 return err;
2997609eb4c9e2 Rafał Miłecki 2013-12-12 135
978e55d2d83b60 Hauke Mehrtens 2014-01-02 136 bcma_chipco_gpio_intmask(cc, ~0, 0);
2997609eb4c9e2 Rafał Miłecki 2013-12-12 137 bcma_cc_set32(cc, BCMA_CC_IRQMASK,
BCMA_CC_IRQ_GPIO);
2997609eb4c9e2 Rafał Miłecki 2013-12-12 138
74f4e0cc61080f Linus Walleij 2015-08-14 @139 err = gpiochip_irqchip_add(chip,
74f4e0cc61080f Linus Walleij 2015-08-14 140 &bcma_gpio_irq_chip,
74f4e0cc61080f Linus Walleij 2015-08-14 141 0,
74f4e0cc61080f Linus Walleij 2015-08-14 142 handle_simple_irq,
74f4e0cc61080f Linus Walleij 2015-08-14 143 IRQ_TYPE_NONE);
74f4e0cc61080f Linus Walleij 2015-08-14 144 if (err) {
74f4e0cc61080f Linus Walleij 2015-08-14 145 free_irq(hwirq, cc);
2997609eb4c9e2 Rafał Miłecki 2013-12-12 146 return err;
2997609eb4c9e2 Rafał Miłecki 2013-12-12 147 }
2997609eb4c9e2 Rafał Miłecki 2013-12-12 148
74f4e0cc61080f Linus Walleij 2015-08-14 149 return 0;
74f4e0cc61080f Linus Walleij 2015-08-14 150 }
2997609eb4c9e2 Rafał Miłecki 2013-12-12 151
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org