[kbuild-all] Re: [PATCH v11 1/3] fpga: mgr: Use standard dev_release for class driver

Hi Russ, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.15-rc1 next-20210913] [cannot apply to xlnx/master linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Russ-Weight/fpga-Use-standard-cl... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 316346243be6df12799c0b64b788e06bad97c30b config: alpha-randconfig-r023-20210913 (attached as .config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/95210e9dca466b2328f05698748a5d78c... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Russ-Weight/fpga-Use-standard-class-dev_release-function/20210914-072216 git checkout 95210e9dca466b2328f05698748a5d78cb391e2c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/fpga/versal-fpga.c: In function 'versal_fpga_probe': drivers/fpga/versal-fpga.c:57:15: error: implicit declaration of function 'devm_fpga_mgr_create'; did you mean 'devm_fpga_mgr_register'? [-Werror=implicit-function-declaration] 57 | mgr = devm_fpga_mgr_create(dev, "Xilinx Versal FPGA Manager", | ^~~~~~~~~~~~~~~~~~~~ | devm_fpga_mgr_register 57 | mgr = devm_fpga_mgr_create(dev, "Xilinx Versal FPGA Manager", | ^ drivers/fpga/versal-fpga.c:62:44: error: passing argument 2 of 'devm_fpga_mgr_register' from incompatible pointer type [-Werror=incompatible-pointer-types] 62 | return devm_fpga_mgr_register(dev, mgr); | ^~~ | | | struct fpga_manager * In file included from drivers/fpga/versal-fpga.c:7: include/linux/fpga/fpga-mgr.h:224:59: note: expected 'const char *' but argument is of type 'struct fpga_manager *' 224 | devm_fpga_mgr_register(struct device *parent, const char *name, | ~~~~~~~~~~~~^~~~ drivers/fpga/versal-fpga.c:62:16: error: too few arguments to function 'devm_fpga_mgr_register' 62 | return devm_fpga_mgr_register(dev, mgr); | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/fpga/versal-fpga.c:7: include/linux/fpga/fpga-mgr.h:224:1: note: declared here 224 | devm_fpga_mgr_register(struct device *parent, const char *name, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/fpga/versal-fpga.c:63:1: error: control reaches end of non-void function [-Werror=return-type] 63 | } | ^ At top level: drivers/fpga/versal-fpga.c:65:34: warning: 'versal_fpga_of_match' defined but not used [-Wunused-const-variable=] 65 | static const struct of_device_id versal_fpga_of_match[] = { | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +57 drivers/fpga/versal-fpga.c 01c54e628932c6 Nava kishore Manne 2021-06-26 44 01c54e628932c6 Nava kishore Manne 2021-06-26 45 static int versal_fpga_probe(struct platform_device *pdev) 01c54e628932c6 Nava kishore Manne 2021-06-26 46 { 01c54e628932c6 Nava kishore Manne 2021-06-26 47 struct device *dev = &pdev->dev; 01c54e628932c6 Nava kishore Manne 2021-06-26 48 struct fpga_manager *mgr; 01c54e628932c6 Nava kishore Manne 2021-06-26 49 int ret; 01c54e628932c6 Nava kishore Manne 2021-06-26 50 01c54e628932c6 Nava kishore Manne 2021-06-26 51 ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); 01c54e628932c6 Nava kishore Manne 2021-06-26 52 if (ret < 0) { 01c54e628932c6 Nava kishore Manne 2021-06-26 53 dev_err(dev, "no usable DMA configuration\n"); 01c54e628932c6 Nava kishore Manne 2021-06-26 54 return ret; 01c54e628932c6 Nava kishore Manne 2021-06-26 55 } 01c54e628932c6 Nava kishore Manne 2021-06-26 56 01c54e628932c6 Nava kishore Manne 2021-06-26 @57 mgr = devm_fpga_mgr_create(dev, "Xilinx Versal FPGA Manager", 01c54e628932c6 Nava kishore Manne 2021-06-26 58 &versal_fpga_ops, NULL); 01c54e628932c6 Nava kishore Manne 2021-06-26 59 if (!mgr) 01c54e628932c6 Nava kishore Manne 2021-06-26 60 return -ENOMEM; 01c54e628932c6 Nava kishore Manne 2021-06-26 61 01c54e628932c6 Nava kishore Manne 2021-06-26 62 return devm_fpga_mgr_register(dev, mgr); 01c54e628932c6 Nava kishore Manne 2021-06-26 63 } 01c54e628932c6 Nava kishore Manne 2021-06-26 64 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org