12:40 a.m.
On 16/07/20 15:09, Valentin Schneider wrote:
On 16/07/20 14:41, Peter Zijlstra wrote:
>> Bah, I'm a hopeless idiot; that very much wants to be
>>
>> *topology*_set_thermal_pressure().
>>
>> Surprising a non W=1 build didn't catch that. In any case, I'll go find
>> myself a stinking trout and send a v3.
>
> Ok, updated the patch, next time I push out it should be fixed, unless
> i'm an idiot too and made it worse ;-)
Thanks! The more I look into it the less I get *how* that even compiles,
let alone boot. Looks like despite only having the prototype of
topology_set_thermal_pressure(), cpufreq_cooling.c is happy to call into
it (via #define arch_set_thermal_pressure topology_set_thermal_pressure)?!
So that
#define arch_set_thermal_pressure topology_set_thermal_pressure
in arm/arm64 asm/topology.h turns the declaration of
arch_set_thermal_pressure() { foo; }
into
topology_set_thermal_pressure() { foo; }
IOW, the *compiled* code was okay, but the way we got there was heretical.