12:26 a.m.
Hi "Marek,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on next-20210413]
[cannot apply to net-next/master ipvs/master linus/master v5.12-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Marek-Beh-n/net-phy-marvell-some...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
ccb39c6285581992f0225c45e4de704028a8ec17
config: x86_64-randconfig-a011-20210413 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/594b70c48fa643c6864722ab488bbfba0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Marek-Beh-n/net-phy-marvell-some-HWMON-updates/20210413-155751
git checkout 594b70c48fa643c6864722ab488bbfba0b210852
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/net/phy/marvell.c:2416:3: error: fallthrough annotation
does not directly precede switch label
fallthrough;
^
include/linux/compiler_attributes.h:208:41: note: expanded from macro
'fallthrough'
# define fallthrough __attribute__((__fallthrough__))
^
1 error generated.
vim +2416 drivers/net/phy/marvell.c
2394
2395 static int marvell_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
2396 u32 attr, int channel, long *temp)
2397 {
2398 struct phy_device *phydev = dev_get_drvdata(dev);
2399 const struct marvell_hwmon_ops *ops = to_marvell_hwmon_ops(phydev);
2400 int err = -EOPNOTSUPP;
2401
2402 switch (attr) {
2403 case hwmon_temp_input:
2404 if (ops->get_temp)
2405 err = ops->get_temp(phydev, temp);
2406 break;
2407 case hwmon_temp_crit:
2408 if (ops->get_temp_critical)
2409 err = ops->get_temp_critical(phydev, temp);
2410 break;
2411 case hwmon_temp_max_alarm:
2412 if (ops->get_temp_alarm)
2413 err = ops->get_temp_alarm(phydev, temp);
2414 break;
2415 default:
2416 fallthrough;
2417 }
2418
2419 return err;
2420 }
2421
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org