[kbuild-all] Re: [SPAM?]Re: arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared

On 12/2/21 8:05 pm, Arnd Bergmann wrote: > On Fri, Feb 12, 2021 at 6:48 AM kernel test robot <lkp(a)intel.com&gt; wrote: >> FYI, the error/warning still remains. > >> | ^~~~~~~~~~~~ >> arch/m68k/68000/dragen2.c: In function 'init_dragen2': >>>> arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared (first use in this function) >> 73 | LSSA = (long) screen_bits; >> | ^~~~~~~~~~~ >> arch/m68k/68000/dragen2.c:73:16: note: each undeclared identifier is reported only once for each function it appears in > > This problem existed before my patch, I just moved the line to another file. > To fix it, one needs to test on real hardware and figure out what is supposed > to go in there. > > The bug was apparently introduced in linux-2.5.70 in this commit: > > commit 2b1a7e97c8c2d6330a432cbcaf83a0ef5fab848e > Author: gerg <gerg> > Date: Mon May 26 16:45:57 2003 +0000 > > [PATCH] fix m68knommu DragonEngine2 target setup code > > Numerous fixes for the m68knommu DragonEngine2 setup code. > > It was out of date relative to more recent kernels. Original patches > from Georges Menie. > > BKrev: 3ed244c5dPVeFKP63b4kkeS_rEshag Digging around a bit I think the screen_bits data structure was originally in a screen.h file that was generated from a screen.xbm file. That was removed in commit 0c0e6db80683 ("m68k: drop unused parts of 68VZ328 Makefile"). Obviously no one seems to be using this, that has been broken for a long time now. I could restore the generated screen.h here, so this could compile at least. I don't have any of the hardware supported in the arch/m68k/68000 directory, so I can't test anything we fix in there.

The other option is to remove the dragen code altogether.