[kbuild-all] [linux-stable-rc:linux-5.10.y 644/2670] drivers/staging/comedi/drivers/comedi_isadma.c:25:17: error: implicit declaration of function 'claim_dma_lock'

Hi Arnd, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y head: f6a609e247c6d6f15ec8c4a87c9aef37b7c8e5a5 commit: 87ae522e467e17a13b796e2cb595f9c3943e4d5e [644/2670] m68knommu: only set CONFIG_ISA_DMA_API for ColdFire sub-arch config: m68k-randconfig-r001-20211213 (https://download.01.org/0day-ci/archive/20211214/202112141146.SF4ebTTl-lk...) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi... git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git fetch --no-tags linux-stable-rc linux-5.10.y git checkout 87ae522e467e17a13b796e2cb595f9c3943e4d5e # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/comedi/drivers/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/staging/comedi/drivers/comedi_isadma.c:7: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:50: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:9: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:17: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/staging/comedi/drivers/comedi_isadma.c: In function 'comedi_isadma_program': 25 | flags = claim_dma_lock(); | ^~~~~~~~~~~~~~ 31 | release_dma_lock(flags); | ^~~~~~~~~~~~~~~~ | release_task cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on DISCONTIGMEM || NUMA Selected by - SINGLE_MEMORY_CHUNK && MMU vim +/claim_dma_lock +25 drivers/staging/comedi/drivers/comedi_isadma.c 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 16 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 17 /** 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 18 * comedi_isadma_program - program and enable an ISA DMA transfer 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 19 * @desc: the ISA DMA cookie to program and enable 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 20 */ 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 21 void comedi_isadma_program(struct comedi_isadma_desc *desc) 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 22 { 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 23 unsigned long flags; 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 24 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 @25 flags = claim_dma_lock(); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 26 clear_dma_ff(desc->chan); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 27 set_dma_mode(desc->chan, desc->mode); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 28 set_dma_addr(desc->chan, desc->hw_addr); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 29 set_dma_count(desc->chan, desc->size); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 30 enable_dma(desc->chan); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 @31 release_dma_lock(flags); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 32 } 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 33 EXPORT_SYMBOL_GPL(comedi_isadma_program); 20a1ea7d6ba184 H Hartley Sweeten 2015-01-14 34 :::::: The code at line 25 was first introduced by commit :::::: 20a1ea7d6ba184a1f6e25e85786738003387cada staging: comedi: comedi_isadma: introduce helper module for ISA DMA :::::: TO: H Hartley Sweeten <hsweeten(a)visionengravers.com&gt; :::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org