8:57 a.m.
Hi Andres,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200714]
[cannot apply to mkp-scsi/for-next scsi/for-next linux/master linus/master v5.8-rc5
v5.8-rc4 v5.8-rc3 v5.8-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Andres-Beltran/Drivers-hv-vmbus-...
base: 5fb3d60423873c969058f16b94bca3ef304a68fb
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/storvsc_drv.c: In function 'storvsc_connect_to_vsp':
> drivers/scsi/storvsc_drv.c:1310:25: warning: variable
'stor_device' set but not used [-Wunused-but-set-variable]
1310 |
struct storvsc_device *stor_device;
| ^~~~~~~~~~~
vim +/stor_device +1310 drivers/scsi/storvsc_drv.c
1304
1305 static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
1306 bool is_fc)
1307 {
1308 struct vmstorage_channel_properties props;
1309 int ret;
1310 struct storvsc_device *stor_device;
1311
1312 memset(&props, 0, sizeof(struct vmstorage_channel_properties));
1313 stor_device = get_out_stor_device(device);
1314 device->channel->max_pkt_size = STORVSC_MAX_PKT_SIZE;
1315
1316 /*
1317 * The size of vmbus_requestor is an upper bound on the number of requests
1318 * that can be in-progress at any one time across all channels.
1319 */
1320 device->channel->rqstor_size = scsi_driver.can_queue;
1321
1322 ret = vmbus_open(device->channel,
1323 ring_size,
1324 ring_size,
1325 (void *)&props,
1326 sizeof(struct vmstorage_channel_properties),
1327 storvsc_on_channel_callback, device->channel);
1328
1329 if (ret != 0)
1330 return ret;
1331
1332 ret = storvsc_channel_init(device, is_fc);
1333
1334 return ret;
1335 }
1336
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org