[kbuild-all] [chrome-os:chromeos-5.10 30/94] drivers/bluetooth/btusb.c:2840:30: error: unused variable 'features'

Hi Joseph, FYI, the error/warning still remains. tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10 head: 7259ec5dffcf820990fc9ab144ab094f604e0d19 commit: 6c7fd7681669fa0354948a9a7ad0cf861a44c603 [30/94] CHROMIUM: Bluetooth: disable Intel quality report feature by default config: arm-chromiumos-arm-customedconfig-chrome-os:chromeos-5.10:cfb2dbbbef971d7f4e3953d426a0c05302b4c204 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel git fetch --no-tags chrome-os chromeos-5.10 git checkout 6c7fd7681669fa0354948a9a7ad0cf861a44c603 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/bluetooth/btusb.c: In function 'btusb_setup_intel_new': 2840 | struct intel_debug_features features; | ^~~~~~~~ cc1: all warnings being treated as errors vim +/features +2840 drivers/bluetooth/btusb.c 5a5fc00f3fbe1e Luiz Augusto von Dentz 2021-03-23 2831 5ea7c81a4f34e4 Kiran K 2020-06-25 2832 static int btusb_setup_intel_new(struct hci_dev *hdev) 5ea7c81a4f34e4 Kiran K 2020-06-25 2833 { 5ea7c81a4f34e4 Kiran K 2020-06-25 2834 struct btusb_data *data = hci_get_drvdata(hdev); 5ea7c81a4f34e4 Kiran K 2020-06-25 2835 struct intel_version ver; 5ea7c81a4f34e4 Kiran K 2020-06-25 2836 struct intel_boot_params params; 5ea7c81a4f34e4 Kiran K 2020-06-25 2837 u32 boot_param; 5ea7c81a4f34e4 Kiran K 2020-06-25 2838 char ddcname[64]; 5ea7c81a4f34e4 Kiran K 2020-06-25 2839 int err; 5ea7c81a4f34e4 Kiran K 2020-06-25 @2840 struct intel_debug_features features; 5ea7c81a4f34e4 Kiran K 2020-06-25 2841 5ea7c81a4f34e4 Kiran K 2020-06-25 2842 BT_DBG("%s", hdev->name); 5ea7c81a4f34e4 Kiran K 2020-06-25 2843 5ea7c81a4f34e4 Kiran K 2020-06-25 2844 /* Set the default boot parameter to 0x0 and it is updated to 5ea7c81a4f34e4 Kiran K 2020-06-25 2845 * SKU specific boot parameter after reading Intel_Write_Boot_Params 5ea7c81a4f34e4 Kiran K 2020-06-25 2846 * command while downloading the firmware. 5ea7c81a4f34e4 Kiran K 2020-06-25 2847 */ 5ea7c81a4f34e4 Kiran K 2020-06-25 2848 boot_param = 0x00000000; 5ea7c81a4f34e4 Kiran K 2020-06-25 2849 5ea7c81a4f34e4 Kiran K 2020-06-25 2850 /* Read the Intel version information to determine if the device 5ea7c81a4f34e4 Kiran K 2020-06-25 2851 * is in bootloader mode or if it already has operational firmware 5ea7c81a4f34e4 Kiran K 2020-06-25 2852 * loaded. 5ea7c81a4f34e4 Kiran K 2020-06-25 2853 */ 5ea7c81a4f34e4 Kiran K 2020-06-25 2854 err = btintel_read_version(hdev, &ver); 5ea7c81a4f34e4 Kiran K 2020-06-25 2855 if (err) { 5ea7c81a4f34e4 Kiran K 2020-06-25 2856 bt_dev_err(hdev, "Intel Read version failed (%d)", err); 5ea7c81a4f34e4 Kiran K 2020-06-25 2857 btintel_reset_to_bootloader(hdev); 5ea7c81a4f34e4 Kiran K 2020-06-25 2858 return err; 5ea7c81a4f34e4 Kiran K 2020-06-25 2859 } 5ea7c81a4f34e4 Kiran K 2020-06-25 2860 45d025d65f3572 Luiz Augusto von Dentz 2021-03-23 2861 err = btintel_version_info(hdev, &ver); 45d025d65f3572 Luiz Augusto von Dentz 2021-03-23 2862 if (err) 45d025d65f3572 Luiz Augusto von Dentz 2021-03-23 2863 return err; 45d025d65f3572 Luiz Augusto von Dentz 2021-03-23 2864 dc45d375cfa567 Kiran K 2020-08-26 2865 err = btusb_intel_download_firmware(hdev, &ver, &params, &boot_param); 5ea7c81a4f34e4 Kiran K 2020-06-25 2866 if (err) 5ea7c81a4f34e4 Kiran K 2020-06-25 2867 return err; 5ea7c81a4f34e4 Kiran K 2020-06-25 2868 5ea7c81a4f34e4 Kiran K 2020-06-25 2869 /* controller is already having an operational firmware */ 5ea7c81a4f34e4 Kiran K 2020-06-25 2870 if (ver.fw_variant == 0x23) 5ea7c81a4f34e4 Kiran K 2020-06-25 2871 goto finish; 5ea7c81a4f34e4 Kiran K 2020-06-25 2872 5a5fc00f3fbe1e Luiz Augusto von Dentz 2021-03-23 2873 err = btusb_intel_boot(hdev, boot_param); 5a5fc00f3fbe1e Luiz Augusto von Dentz 2021-03-23 2874 if (err) e5889af62fce08 Tedd Ho-Jeong An 2018-01-24 2875 return err; cda0dd7809f89e Marcel Holtmann 2015-01-26 2876 cda0dd7809f89e Marcel Holtmann 2015-01-26 2877 clear_bit(BTUSB_BOOTLOADER, &data->flags); cda0dd7809f89e Marcel Holtmann 2015-01-26 2878 5ea7c81a4f34e4 Kiran K 2020-06-25 2879 err = btusb_setup_intel_new_get_fw_name(&ver, &params, ddcname, 5ea7c81a4f34e4 Kiran K 2020-06-25 2880 sizeof(ddcname), "ddc"); 5ea7c81a4f34e4 Kiran K 2020-06-25 2881 b772c29f794fed Luiz Augusto von Dentz 2021-03-23 2882 if (err < 0) { 5ea7c81a4f34e4 Kiran K 2020-06-25 2883 bt_dev_err(hdev, "Unsupported Intel firmware naming"); 5ea7c81a4f34e4 Kiran K 2020-06-25 2884 } else { 5ea7c81a4f34e4 Kiran K 2020-06-25 2885 /* Once the device is running in operational mode, it needs to 5ea7c81a4f34e4 Kiran K 2020-06-25 2886 * apply the device configuration (DDC) parameters. 52cc916818c86a Tedd Ho-Jeong An 2015-06-12 2887 * 5ea7c81a4f34e4 Kiran K 2020-06-25 2888 * The device can work without DDC parameters, so even if it 5ea7c81a4f34e4 Kiran K 2020-06-25 2889 * fails to load the file, no need to fail the setup. 52cc916818c86a Tedd Ho-Jeong An 2015-06-12 2890 */ 5ea7c81a4f34e4 Kiran K 2020-06-25 2891 btintel_load_ddc_config(hdev, ddcname); 5ea7c81a4f34e4 Kiran K 2020-06-25 2892 } 52cc916818c86a Tedd Ho-Jeong An 2015-06-12 2893 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2894 /* Read the Intel version information after loading the FW */ 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2895 err = btintel_read_version(hdev, &ver); 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2896 if (err) 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2897 return err; 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2898 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2899 btintel_version_info(hdev, &ver); 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2900 7fd673bcdacc85 Marcel Holtmann 2020-04-03 2901 finish: fc04590e3d3921 Miao-chen Chou 2020-04-03 2902 /* All Intel controllers that support the Microsoft vendor fc04590e3d3921 Miao-chen Chou 2020-04-03 2903 * extension are using 0xFC1E for VsMsftOpCode. fc04590e3d3921 Miao-chen Chou 2020-04-03 2904 */ fc04590e3d3921 Miao-chen Chou 2020-04-03 2905 switch (ver.hw_variant) { 1640e21eeaaf8d Miao-chen Chou 2020-12-17 2906 case 0x11: /* JfP */ fc04590e3d3921 Miao-chen Chou 2020-04-03 2907 case 0x12: /* ThP */ 1640e21eeaaf8d Miao-chen Chou 2020-12-17 2908 case 0x13: /* HrP */ 1640e21eeaaf8d Miao-chen Chou 2020-12-17 2909 case 0x14: /* CcP */ fc04590e3d3921 Miao-chen Chou 2020-04-03 2910 hci_set_msft_opcode(hdev, 0xFC1E); fc04590e3d3921 Miao-chen Chou 2020-04-03 2911 break; fc04590e3d3921 Miao-chen Chou 2020-04-03 2912 } fc04590e3d3921 Miao-chen Chou 2020-04-03 2913 213445b2b40e87 Marcel Holtmann 2015-10-21 2914 /* Set the event mask for Intel specific vendor events. This enables 213445b2b40e87 Marcel Holtmann 2015-10-21 2915 * a few extra events that are useful during general operation. It 213445b2b40e87 Marcel Holtmann 2015-10-21 2916 * does not enable any debugging related events. 213445b2b40e87 Marcel Holtmann 2015-10-21 2917 * 213445b2b40e87 Marcel Holtmann 2015-10-21 2918 * The device will function correctly without these events enabled 213445b2b40e87 Marcel Holtmann 2015-10-21 2919 * and thus no need to fail the setup. 213445b2b40e87 Marcel Holtmann 2015-10-21 2920 */ 213445b2b40e87 Marcel Holtmann 2015-10-21 2921 btintel_set_event_mask(hdev, false); 213445b2b40e87 Marcel Holtmann 2015-10-21 2922 cda0dd7809f89e Marcel Holtmann 2015-01-26 2923 return 0; cda0dd7809f89e Marcel Holtmann 2015-01-26 2924 } cda0dd7809f89e Marcel Holtmann 2015-01-26 2925 :::::: The code at line 2840 was first introduced by commit :::::: 5ea7c81a4f34e4dbb9c7bfd0fe18e5fba8a7f8f9 Bluetooth: btusb: Refactor of firmware download flow for Intel conrollers :::::: TO: Kiran K <kiran.k(a)intel.com&gt; :::::: CC: Marcel Holtmann <marcel(a)holtmann.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org