8:31 p.m.
Hi Phillip,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.17-rc1 next-20220124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Phillip-Potter/Cleanup-and-remov...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
fa783154524a71ab74e293cd8251155e5971952b
config: arc-allyesconfig
(https://download.01.org/0day-ci/archive/20220125/202201251730.AgK9qxSH-lk...)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/1724ade2c1f2fa95e0e314ed9229700d6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206
git checkout 1724ade2c1f2fa95e0e314ed9229700d6158fbbc
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=arc SHELL=/bin/bash drivers/staging/r8188eu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
> drivers/staging/r8188eu/os_dep/ioctl_linux.c:1022:13: warning:
variable 'reason' set but not used [-Wunused-but-set-variable]
1022 |
u16 reason;
| ^~~~~~
vim +/reason +1022 drivers/staging/r8188eu/os_dep/ioctl_linux.c
2b42bd58b32155 Phillip Potter 2021-07-28 1016
2b42bd58b32155 Phillip Potter 2021-07-28 1017 static int rtw_wx_set_mlme(struct
net_device *dev,
2b42bd58b32155 Phillip Potter 2021-07-28 1018 struct iw_request_info *info,
2b42bd58b32155 Phillip Potter 2021-07-28 1019 union iwreq_data *wrqu, char
*extra)
2b42bd58b32155 Phillip Potter 2021-07-28 1020 {
2b42bd58b32155 Phillip Potter 2021-07-28 1021 int ret = 0;
2b42bd58b32155 Phillip Potter 2021-07-28 @1022 u16 reason;
2b42bd58b32155 Phillip Potter 2021-07-28 1023 struct adapter *padapter = (struct
adapter *)rtw_netdev_priv(dev);
2b42bd58b32155 Phillip Potter 2021-07-28 1024 struct iw_mlme *mlme = (struct iw_mlme
*)extra;
2b42bd58b32155 Phillip Potter 2021-07-28 1025
d8062f6adca1ef Michael Straube 2021-07-30 1026 if (!mlme)
2b42bd58b32155 Phillip Potter 2021-07-28 1027 return -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1028
2b42bd58b32155 Phillip Potter 2021-07-28 1029 reason = mlme->reason_code;
2b42bd58b32155 Phillip Potter 2021-07-28 1030
2b42bd58b32155 Phillip Potter 2021-07-28 1031 switch (mlme->cmd) {
2b42bd58b32155 Phillip Potter 2021-07-28 1032 case IW_MLME_DEAUTH:
2b42bd58b32155 Phillip Potter 2021-07-28 1033 if
(!rtw_set_802_11_disassociate(padapter))
2b42bd58b32155 Phillip Potter 2021-07-28 1034 ret = -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1035 break;
2b42bd58b32155 Phillip Potter 2021-07-28 1036 case IW_MLME_DISASSOC:
2b42bd58b32155 Phillip Potter 2021-07-28 1037 if
(!rtw_set_802_11_disassociate(padapter))
2b42bd58b32155 Phillip Potter 2021-07-28 1038 ret = -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1039 break;
2b42bd58b32155 Phillip Potter 2021-07-28 1040 default:
2b42bd58b32155 Phillip Potter 2021-07-28 1041 return -EOPNOTSUPP;
2b42bd58b32155 Phillip Potter 2021-07-28 1042 }
2b42bd58b32155 Phillip Potter 2021-07-28 1043 return ret;
2b42bd58b32155 Phillip Potter 2021-07-28 1044 }
2b42bd58b32155 Phillip Potter 2021-07-28 1045
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org