[kbuild-all] Re: [kbuild] [vireshk-pm:opp/linux-next 4/11] drivers/opp/of.c:662:7-14: ERROR: reference preceded by free on line 625

0f438abc246a03 drivers/opp/of.c Georgi Djakov 2020-05-12 635 } 0f438abc246a03 drivers/opp/of.c Georgi Djakov 2020-05-12 636 0f438abc246a03 drivers/opp/of.c Georgi Djakov 2020-05-12 637 ret = of_property_read_u32_array(np, "opp-avg-kBps", avg_bw, 0f438abc246a03 drivers/opp/of.c Georgi Djakov 2020-05-12 638 count); This code is really confusing. This assignment over writes the "ret" variable. I guess that's intended instead of using "found = true;" on this path??? It really feels like this function should be split into multiple functions. If I read it correctly, then if it can find any property then that's counted as a success? I guess we'd like to find them all but if we can find one then that's enough?