9:10 a.m.
Hi Pablo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf/master]
[also build test WARNING on nf-next/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: i386-randconfig-s001-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
#
https://github.com/0day-ci/linux/commit/12cfd8daf813a3f62294bdbe915c1d2cd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Pablo-Neira-Ayuso/netfilter-nf_tables-add-last-expression/20210617-021223
git checkout 12cfd8daf813a3f62294bdbe915c1d2cd6946a30
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> net/netfilter/nft_last.c:59:46: sparse: sparse: incorrect type in
argument 3 (different base types) @@ expected restricted __be32 [usertype] value @@
got restricted __be16 [usertype] @@
net/netfilter/nft_last.c:59:46: sparse:
expected restricted __be32 [usertype] value
net/netfilter/nft_last.c:59:46: sparse: got restricted __be16 [usertype]
vim +59 net/netfilter/nft_last.c
48
49 static int nft_last_dump(struct sk_buff *skb, const struct nft_expr *expr)
50 {
51 struct nft_last_priv *priv = nft_expr_priv(expr);
52 __be64 msecs;
53
54 if (priv->last_set)
55 msecs = nf_jiffies64_to_msecs(jiffies - priv->last_jiffies);
56 else
57 msecs = 0;
58
59 if (nla_put_be32(skb, NFTA_LAST_SET, htons(priv->last_set)) ||
60 nla_put_be64(skb, NFTA_LAST_MSECS, msecs, NFTA_LAST_PAD))
61 goto nla_put_failure;
62
63 return 0;
64
65 nla_put_failure:
66 return -1;
67 }
68
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org