11:18 a.m.
Hi Maxime,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20211020]
[cannot apply to linus/master v5.15-rc6 v5.15-rc5 v5.15-rc4 v5.15-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-bridge-Make-pa...
base: 51dba6e335ff9d1f6f50b5cacced8598956e1437
config: nds32-randconfig-r034-20211021 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/585920edf3c968d2da5a1eeaa56a2a075...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Maxime-Ripard/drm-bridge-Make-panel-and-bridge-probe-order-consistent/20211021-154253
git checkout 585920edf3c968d2da5a1eeaa56a2a075d7067b9
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=nds32 SHELL=/bin/bash drivers/gpu/drm/bridge/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/bridge/parade-ps8640.c: In function 'ps8640_bridge_attach':
> drivers/gpu/drm/bridge/parade-ps8640.c:407:9: error:
'ret' undeclared (first use in this function); did you mean 'net'?
407 | ret = drm_dp_aux_register(&ps_bridge->aux);
| ^~~
| net
drivers/gpu/drm/bridge/parade-ps8640.c:407:9: note: each undeclared identifier is
reported only once for each function it appears in
In file included from include/linux/device.h:15,
from include/linux/acpi.h:15,
from include/linux/i2c.h:13,
from drivers/gpu/drm/bridge/parade-ps8640.c:9:
> drivers/gpu/drm/bridge/parade-ps8640.c:409:25: error:
'dev' undeclared (first use in this function); did you mean 'cdev'?
409 | dev_err(dev, "failed to register DP AUX channel:
%d\n", ret);
| ^~~
include/linux/dev_printk.h:110:25: note: in definition of macro
'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
drivers/gpu/drm/bridge/parade-ps8640.c:409:17: note: in expansion of macro
'dev_err'
409 | dev_err(dev, "failed to register DP AUX channel:
%d\n", ret);
| ^~~~~~~
vim +407 drivers/gpu/drm/bridge/parade-ps8640.c
bc1aee7fc8f05b Jitao Shi 2019-12-30 398
a25b988ff83f3c Laurent Pinchart 2020-02-26 399 static int
ps8640_bridge_attach(struct drm_bridge *bridge,
a25b988ff83f3c Laurent Pinchart 2020-02-26 400 enum drm_bridge_attach_flags
flags)
bc1aee7fc8f05b Jitao Shi 2019-12-30 401 {
bc1aee7fc8f05b Jitao Shi 2019-12-30 402 struct ps8640 *ps_bridge =
bridge_to_ps8640(bridge);
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26 403
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26 404 if (!(flags &
DRM_BRIDGE_ATTACH_NO_CONNECTOR))
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26 405 return -EINVAL;
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26 406
13afcdd7277eff Philip Chen 2021-09-21 @407 ret =
drm_dp_aux_register(&ps_bridge->aux);
13afcdd7277eff Philip Chen 2021-09-21 408 if (ret) {
13afcdd7277eff Philip Chen 2021-09-21 @409 dev_err(dev, "failed to
register DP AUX channel: %d\n", ret);
e1881ac0e79203 Maxime Ripard 2021-10-21 410 return ret;
13afcdd7277eff Philip Chen 2021-09-21 411 }
bc1aee7fc8f05b Jitao Shi 2019-12-30 412
bc1aee7fc8f05b Jitao Shi 2019-12-30 413 /* Attach the panel-bridge to the
dsi bridge */
bc1aee7fc8f05b Jitao Shi 2019-12-30 414 return
drm_bridge_attach(bridge->encoder, ps_bridge->panel_bridge,
a25b988ff83f3c Laurent Pinchart 2020-02-26 415 &ps_bridge->bridge,
flags);
bc1aee7fc8f05b Jitao Shi 2019-12-30 416 }
bc1aee7fc8f05b Jitao Shi 2019-12-30 417
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org