[kbuild-all] Re: [PATCH 1/2] opp: Reorder the code for !target_freq case

Hi Viresh, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Viresh-Kumar/opp-core-add-regula... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1ae7efb388540adc1653a51a3bc3b2c9cef5ec1a If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com&gt; cppcheck warnings: (new ones prefixed by >>) >> drivers/opp/core.c:833:7: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] ret = _set_required_opps(dev, opp_table, NULL); ^ drivers/opp/core.c:830:8: note: ret is assigned ret = -EINVAL; ^ drivers/opp/core.c:833:7: note: ret is overwritten ret = _set_required_opps(dev, opp_table, NULL); ^ vim +/ret +833 drivers/opp/core.c