2:06 p.m.
Hi Wander,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linux/master linus/master v5.16-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Wander-Lairson-Costa/Fix-warning...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: nds32-randconfig-r012-20211210
(https://download.01.org/0day-ci/archive/20211211/202112111053.CFUB5OjZ-lk...)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/78ab0023d3b1ba3f3dc5703b4d4fac1dd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Wander-Lairson-Costa/Fix-warnings-in-blktrace/20211211-044405
git checkout 78ab0023d3b1ba3f3dc5703b4d4fac1dd24aa0c2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=nds32 SHELL=/bin/bash drivers/vfio/ kernel/trace/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/trace/blktrace.c: In function '__trace_note_message':
kernel/trace/blktrace.c:148:63: warning: parameter 'blkcg' set but not used
[-Wunused-but-set-parameter]
148 | void __trace_note_message(struct blk_trace *bt, struct blkcg *blkcg,
| ~~~~~~~~~~~~~~^~~~~
kernel/trace/blktrace.c: In function 'blk_trace_remove_queue':
> kernel/trace/blktrace.c:1611:31: error: passing argument 1 of
'spin_lock_irq' from incompatible pointer type
[-Werror=incompatible-pointer-types]
1611 |
spin_lock_irq(&running_trace_lock);
| ^~~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
In file included from include/linux/wait.h:9,
from include/linux/pid.h:6,
from include/linux/sched.h:14,
from include/linux/blkdev.h:5,
from kernel/trace/blktrace.c:10:
include/linux/spinlock.h:372:55: note: expected 'spinlock_t *' {aka 'struct
spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct
raw_spinlock *'}
372 | static __always_inline void spin_lock_irq(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
> kernel/trace/blktrace.c:1613:33: error: passing argument 1 of
'spin_unlock_irq' from incompatible pointer type
[-Werror=incompatible-pointer-types]
1613 |
spin_unlock_irq(&running_trace_lock);
| ^~~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
In file included from include/linux/wait.h:9,
from include/linux/pid.h:6,
from include/linux/sched.h:14,
from include/linux/blkdev.h:5,
from kernel/trace/blktrace.c:10:
include/linux/spinlock.h:397:57: note: expected 'spinlock_t *' {aka 'struct
spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct
raw_spinlock *'}
397 | static __always_inline void spin_unlock_irq(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
vim +/spin_lock_irq +1611 kernel/trace/blktrace.c
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1599
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1600 static
int blk_trace_remove_queue(struct request_queue *q)
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1601 {
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1602 struct
blk_trace *bt;
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1603
c3dbe541ef7775 kernel/trace/blktrace.c Jan Kara 2020-06-05 1604 bt =
rcu_replace_pointer(q->blk_trace, NULL,
85e0cbbb8a7953 kernel/trace/blktrace.c Luis Chamberlain 2020-06-19 1605
lockdep_is_held(&q->debugfs_mutex));
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1606 if (bt
== NULL)
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1607 return
-EINVAL;
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1608
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1609 if
(bt->trace_state == Blktrace_running) {
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1610
bt->trace_state = Blktrace_stopped;
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 @1611
spin_lock_irq(&running_trace_lock);
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1612
list_del_init(&bt->running_list);
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 @1613
spin_unlock_irq(&running_trace_lock);
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1614
relay_flush(bt->rchan);
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1615 }
5afedf670caf30 kernel/trace/blktrace.c Zhihao Cheng 2021-09-23 1616
a6da0024ffc19e kernel/trace/blktrace.c Jens Axboe 2017-11-05 1617
put_probe_ref();
c780e86dd48ef6 kernel/trace/blktrace.c Jan Kara 2020-02-06 1618
synchronize_rcu();
ad5dd5493a55e4 kernel/trace/blktrace.c Li Zefan 2009-03-27 1619
blk_trace_free(bt);
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1620 return
0;
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1621 }
c71a896154119f block/blktrace.c Arnaldo Carvalho de Melo 2009-01-23 1622
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org