[kbuild-all] Re: [Intel-gfx] [PATCH 1/2] drm/i915: FPGA_DBG is display-specific

Hi Matt, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.11-rc7 next-20210212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matt-Roper/drm-i915-FPGA_DBG-is-... base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-a013-20210209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/e432ad4f289f57cc4b71e03726084f83f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matt-Roper/drm-i915-FPGA_DBG-is-display-specific/20210213-052120 git checkout e432ad4f289f57cc4b71e03726084f83f8109ac8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): if (HAS_FPGA_DBG_UNCLAIMED(i915)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_drv.h:1706:65: note: expanded from macro 'HAS_FPGA_DBG_UNCLAIMED' #define HAS_FPGA_DBG_UNCLAIMED(dev_priv) (INTEL_INFO(dev_priv)->has_fpga_dbg) ~~~~~~~~~~~~~~~~~~~~ ^ In file included from drivers/gpu/drm/i915/intel_uncore.c:2252: if (!HAS_FPGA_DBG_UNCLAIMED(gt->i915) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_drv.h:1706:65: note: expanded from macro 'HAS_FPGA_DBG_UNCLAIMED' #define HAS_FPGA_DBG_UNCLAIMED(dev_priv) (INTEL_INFO(dev_priv)->has_fpga_dbg) ~~~~~~~~~~~~~~~~~~~~ ^ 2 errors generated. vim +1921 drivers/gpu/drm/i915/intel_uncore.c 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1894 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1895 int intel_uncore_init_mmio(struct intel_uncore *uncore) 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1896 { 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1897 struct drm_i915_private *i915 = uncore->i915; 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1898 int ret; 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1899 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1900 ret = uncore_mmio_setup(uncore); 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1901 if (ret) 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1902 return ret; 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1903 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1904 if (INTEL_GEN(i915) > 5 && !intel_vgpu_active(i915)) 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1905 uncore->flags |= UNCORE_HAS_FORCEWAKE; 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1906 f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1907 if (!intel_uncore_has_forcewake(uncore)) { 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1908 uncore_raw_init(uncore); f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1909 } else { f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1910 ret = uncore_forcewake_init(uncore); f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1911 if (ret) f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1912 goto out_mmio_cleanup; f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1913 } 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1914 ccb2aceaaa5f92 Daniele Ceraolo Spurio 2019-06-19 1915 /* make sure fw funcs are set if and only if we have fw*/ ccb2aceaaa5f92 Daniele Ceraolo Spurio 2019-06-19 1916 GEM_BUG_ON(intel_uncore_has_forcewake(uncore) != !!uncore->funcs.force_wake_get); ccb2aceaaa5f92 Daniele Ceraolo Spurio 2019-06-19 1917 GEM_BUG_ON(intel_uncore_has_forcewake(uncore) != !!uncore->funcs.force_wake_put); ccb2aceaaa5f92 Daniele Ceraolo Spurio 2019-06-19 1918 GEM_BUG_ON(intel_uncore_has_forcewake(uncore) != !!uncore->funcs.read_fw_domains); ccb2aceaaa5f92 Daniele Ceraolo Spurio 2019-06-19 1919 GEM_BUG_ON(intel_uncore_has_forcewake(uncore) != !!uncore->funcs.write_fw_domains); ccb2aceaaa5f92 Daniele Ceraolo Spurio 2019-06-19 1920 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 @1921 if (HAS_FPGA_DBG_UNCLAIMED(i915)) 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1922 uncore->flags |= UNCORE_HAS_FPGA_DBG_UNCLAIMED; 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1923 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1924 if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1925 uncore->flags |= UNCORE_HAS_DBG_UNCLAIMED; 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1926 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1927 if (IS_GEN_RANGE(i915, 6, 7)) 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1928 uncore->flags |= UNCORE_HAS_FIFO; 2cf7bf6f2f2067 Daniele Ceraolo Spurio 2019-03-25 1929 2e81bc61d4e3ee Daniele Ceraolo Spurio 2019-06-19 1930 /* clear out unclaimed reg detection bit */ 0a9b26306d6a10 Daniele Ceraolo Spurio 2019-08-09 1931 if (intel_uncore_unclaimed_mmio(uncore)) d0208cfa5f1547 Wambui Karuga 2020-01-07 1932 drm_dbg(&i915->drm, "unclaimed mmio detected on uncore init, clearing\n"); 25286aaca9cee1 Daniele Ceraolo Spurio 2019-03-19 1933 25286aaca9cee1 Daniele Ceraolo Spurio 2019-03-19 1934 return 0; f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1935 f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1936 out_mmio_cleanup: f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1937 uncore_mmio_cleanup(uncore); f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1938 f833cdb06bf7ce Daniele Ceraolo Spurio 2019-06-19 1939 return ret; 0b27448141bbe9 Ben Widawsky 2013-10-04 1940 } 0b27448141bbe9 Ben Widawsky 2013-10-04 1941 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org