3:16 p.m.
Hi,
We have already fixed it before
(https://github.com/smfrench/smb3-kernel/commit/60f4e4de78688253a2d2ceaa69...)
You have probably not tested it on the latest updated branch...
Anyway, Thanks for your test!
-----Original Message-----
From: kernel test robot <lkp(a)intel.com>
Sent: Saturday, March 13, 2021 3:09 AM
To: Namjae Jeon <namjae.jeon(a)samsung.com>
Cc: kbuild-all(a)lists.01.org; Steve French <stfrench(a)microsoft.com>
Subject: [smfrench-smb3-kernel:pr/25 40/94] fs/cifsd/vfs.c:1439:23: error: passing
argument 1 of
'set_posix_acl' from incompatible pointer type
tree: git://github.com/smfrench/smb3-kernel.git pr/25
head: 000c509767ede7cd26919ca7b5acac916964f2d8
commit: a733f866b0fef5a0583d0dedb06f97789f20a761 [40/94] cifsd: add support for ACLs
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://protect2.fireeye.com/v1/url?k=03d5aa60-5c4e932e-03d4212f-0cc47a31...
27dd5828da2e3321&q=1&e=84dd4df2-50a8-4e60-b1fd-
61659da165a2&u=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-
tests%2Fmaster%2Fsbin%2Fmake.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://protect2.fireeye.com/v1/url?k=68d666ed-374d5fa3-68d7eda2-0cc47a31...
0bc313b77c979a31&q=1&e=84dd4df2-50a8-4e60-b1fd-
61659da165a2&u=https%3A%2F%2Fgithub.com%2Fsmfrench%2Fsmb3-
kernel%2Fcommit%2Fa733f866b0fef5a0583d0dedb06f97789f20a761
git remote add smfrench-smb3-kernel git://github.com/smfrench/smb3-kernel.git
git fetch --no-tags smfrench-smb3-kernel pr/25
git checkout a733f866b0fef5a0583d0dedb06f97789f20a761
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the smfrench-smb3-kernel/pr/25 HEAD 000c509767ede7cd26919ca7b5acac916964f2d8 builds
fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
| |
| const char *
In file included from fs/cifsd/vfs.c:13:
include/linux/xattr.h:63:43: note: expected 'struct dentry *' but argument is
of type 'const char
*'
63 | int vfs_setxattr(struct user_namespace *, struct dentry *, const char *,
| ^~~~~~~~~~~~~~~
fs/cifsd/vfs.c:965:7: warning: passing argument 4 of 'vfs_setxattr' makes
pointer from integer
without a cast [-Wint-conversion]
965 | attr_size,
| ^~~~~~~~~
| |
| size_t {aka unsigned int}
In file included from fs/cifsd/vfs.c:13:
include/linux/xattr.h:64:4: note: expected 'const void *' but argument is of
type 'size_t' {aka
'unsigned int'}
64 | const void *, size_t, int);
| ^~~~~~~~~~~~
fs/cifsd/vfs.c:962:8: error: too few arguments to function 'vfs_setxattr'
962 | err = vfs_setxattr(dentry,
| ^~~~~~~~~~~~
In file included from fs/cifsd/vfs.c:13:
include/linux/xattr.h:63:5: note: declared here
63 | int vfs_setxattr(struct user_namespace *, struct dentry *, const char *,
| ^~~~~~~~~~~~
fs/cifsd/vfs.c: In function 'ksmbd_vfs_remove_xattr':
fs/cifsd/vfs.c:1103:25: error: passing argument 1 of 'vfs_removexattr' from
incompatible pointer
type [-Werror=incompatible-pointer-types]
1103 | return vfs_removexattr(dentry, attr_name);
| ^~~~~~
| |
| struct dentry *
In file included from fs/cifsd/vfs.c:13:
include/linux/xattr.h:68:21: note: expected 'struct user_namespace *' but
argument is of type
'struct dentry *'
68 | int vfs_removexattr(struct user_namespace *, struct dentry *, const char *);
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/cifsd/vfs.c:1103:33: error: passing argument 2 of 'vfs_removexattr' from
incompatible pointer
type [-Werror=incompatible-pointer-types]
1103 | return vfs_removexattr(dentry, attr_name);
| ^~~~~~~~~
| |
| char *
In file included from fs/cifsd/vfs.c:13:
include/linux/xattr.h:68:46: note: expected 'struct dentry *' but argument is
of type 'char *'
68 | int vfs_removexattr(struct user_namespace *, struct dentry *, const char *);
| ^~~~~~~~~~~~~~~
fs/cifsd/vfs.c:1103:9: error: too few arguments to function 'vfs_removexattr'
1103 | return vfs_removexattr(dentry, attr_name);
| ^~~~~~~~~~~~~~~
In file included from fs/cifsd/vfs.c:13:
include/linux/xattr.h:68:5: note: declared here
68 | int vfs_removexattr(struct user_namespace *, struct dentry *, const char *);
| ^~~~~~~~~~~~~~~
fs/cifsd/vfs.c: In function 'ksmbd_vfs_unlink':
fs/cifsd/vfs.c:1123:19: error: passing argument 1 of 'vfs_rmdir' from
incompatible pointer type [-
Werror=incompatible-pointer-types]
1123 | err = vfs_rmdir(d_inode(dir), dentry);
| ^~~~~~~~~~~~
| |
| struct inode *
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:1781:15: note: expected 'struct user_namespace *' but
argument is of type
'struct inode *'
1781 | int vfs_rmdir(struct user_namespace *, struct inode *, struct dentry *);
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/cifsd/vfs.c:1123:33: error: passing argument 2 of 'vfs_rmdir' from
incompatible pointer type [-
Werror=incompatible-pointer-types]
1123 | err = vfs_rmdir(d_inode(dir), dentry);
| ^~~~~~
| |
| struct dentry *
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:1781:40: note: expected 'struct inode *' but argument is of
type 'struct dentry
*'
1781 | int vfs_rmdir(struct user_namespace *, struct inode *, struct dentry *);
| ^~~~~~~~~~~~~~
fs/cifsd/vfs.c:1123:9: error: too few arguments to function 'vfs_rmdir'
1123 | err = vfs_rmdir(d_inode(dir), dentry);
| ^~~~~~~~~
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:1781:5: note: declared here
1781 | int vfs_rmdir(struct user_namespace *, struct inode *, struct dentry *);
| ^~~~~~~~~
fs/cifsd/vfs.c:1125:20: error: passing argument 1 of 'vfs_unlink' from
incompatible pointer type [-
Werror=incompatible-pointer-types]
1125 | err = vfs_unlink(d_inode(dir), dentry, NULL);
| ^~~~~~~~~~~~
| |
| struct inode *
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:1782:16: note: expected 'struct user_namespace *' but
argument is of type
'struct inode *'
1782 | int vfs_unlink(struct user_namespace *, struct inode *, struct dentry *,
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/cifsd/vfs.c:1125:34: error: passing argument 2 of 'vfs_unlink' from
incompatible pointer type [-
Werror=incompatible-pointer-types]
1125 | err = vfs_unlink(d_inode(dir), dentry, NULL);
| ^~~~~~
| |
| struct dentry *
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:1782:41: note: expected 'struct inode *' but argument is of
type 'struct dentry
*'
1782 | int vfs_unlink(struct user_namespace *, struct inode *, struct dentry *,
| ^~~~~~~~~~~~~~
fs/cifsd/vfs.c:1125:9: error: too few arguments to function 'vfs_unlink'
1125 | err = vfs_unlink(d_inode(dir), dentry, NULL);
| ^~~~~~~~~~
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:1782:5: note: declared here
1782 | int vfs_unlink(struct user_namespace *, struct inode *, struct dentry *,
| ^~~~~~~~~~
fs/cifsd/vfs.c: In function 'ksmbd_vfs_set_posix_acl':
>> fs/cifsd/vfs.c:1439:23: error: passing argument 1 of 'set_posix_acl'
>> from incompatible pointer type [-Werror=incompatible-pointer-types]
1439 | return set_posix_acl(inode, type, acl);
| ^~~~~
| |
| struct inode *
In file included from fs/cifsd/vfs.h:14,
from fs/cifsd/vfs_cache.h:16,
from fs/cifsd/glob.h:14,
from fs/cifsd/vfs.c:24:
include/linux/posix_acl.h:72:26: note: expected 'struct user_namespace *' but
argument is of type
'struct inode *'
72 | extern int set_posix_acl(struct user_namespace *, struct inode *, int,
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/cifsd/vfs.c:1439:30: warning: passing argument 2 of 'set_posix_acl' makes
pointer from integer
without a cast [-Wint-conversion]
1439 | return set_posix_acl(inode, type, acl);
| ^~~~
| |
| int
In file included from fs/cifsd/vfs.h:14,
from fs/cifsd/vfs_cache.h:16,
from fs/cifsd/glob.h:14,
from fs/cifsd/vfs.c:24:
include/linux/posix_acl.h:72:51: note: expected 'struct inode *' but argument
is of type 'int'
72 | extern int set_posix_acl(struct user_namespace *, struct inode *, int,
| ^~~~~~~~~~~~~~
fs/cifsd/vfs.c:1439:36: warning: passing argument 3 of 'set_posix_acl' makes
integer from pointer
without a cast [-Wint-conversion]
1439 | return set_posix_acl(inode, type, acl);
| ^~~
| |
| struct posix_acl *
In file included from fs/cifsd/vfs.h:14,
from fs/cifsd/vfs_cache.h:16,
from fs/cifsd/glob.h:14,
from fs/cifsd/vfs.c:24:
include/linux/posix_acl.h:72:67: note: expected 'int' but argument is of type
'struct posix_acl *'
72 | extern int set_posix_acl(struct user_namespace *, struct inode *, int,
| ^~~
>> fs/cifsd/vfs.c:1439:9: error: too few arguments to function
'set_posix_acl'
1439 | return set_posix_acl(inode, type, acl);
| ^~~~~~~~~~~~~
In file included from fs/cifsd/vfs.h:14,
from fs/cifsd/vfs_cache.h:16,
from fs/cifsd/glob.h:14,
from fs/cifsd/vfs.c:24:
include/linux/posix_acl.h:72:12: note: declared here
72 | extern int set_posix_acl(struct user_namespace *, struct inode *, int,
| ^~~~~~~~~~~~~
fs/cifsd/vfs.c: In function 'ksmbd_vfs_fill_dentry_attrs':
fs/cifsd/vfs.c:1478:19: error: passing argument 1 of 'generic_fillattr' from
incompatible pointer
type [-Werror=incompatible-pointer-types]
1478 | generic_fillattr(d_inode(dentry), ksmbd_kstat->kstat);
| ^~~~~~~~~~~~~~~
| |
| struct inode *
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:3211:23: note: expected 'struct user_namespace *' but
argument is of type
'struct inode *'
3211 | void generic_fillattr(struct user_namespace *, struct inode *, struct kstat
*);
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/cifsd/vfs.c:1478:47: error: passing argument 2 of 'generic_fillattr' from
incompatible pointer
type [-Werror=incompatible-pointer-types]
1478 | generic_fillattr(d_inode(dentry), ksmbd_kstat->kstat);
| ~~~~~~~~~~~^~~~~~~
| |
| struct kstat *
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:3211:48: note: expected 'struct inode *' but argument is of
type 'struct kstat
*'
3211 | void generic_fillattr(struct user_namespace *, struct inode *, struct kstat
*);
| ^~~~~~~~~~~~~~
fs/cifsd/vfs.c:1478:2: error: too few arguments to function
'generic_fillattr'
1478 | generic_fillattr(d_inode(dentry), ksmbd_kstat->kstat);
| ^~~~~~~~~~~~~~~~
In file included from fs/cifsd/vfs.c:8:
include/linux/fs.h:3211:6: note: declared here
3211 | void generic_fillattr(struct user_namespace *, struct inode *, struct kstat
*);
| ^~~~~~~~~~~~~~~~
fs/cifsd/vfs.c: In function 'ksmbd_vfs_xattr_len':
fs/cifsd/vfs.c:910:1: error: control reaches end of non-void function
[-Werror=return-type]
910 | }
| ^
fs/cifsd/vfs.c: In function 'ksmbd_vfs_remove_xattr':
fs/cifsd/vfs.c:1104:1: error: control reaches end of non-void function
[-Werror=return-type]
1104 | }
| ^
fs/cifsd/vfs.c: In function 'ksmbd_vfs_set_posix_acl':
fs/cifsd/vfs.c:1440:1: error: control reaches end of non-void function
[-Werror=return-type]
1440 | }
| ^
cc1: some warnings being treated as errors
vim +/set_posix_acl +1439 fs/cifsd/vfs.c
1435
1436 int ksmbd_vfs_set_posix_acl(struct inode *inode, int type,
1437 struct posix_acl *acl)
1438 {
> 1439 return set_posix_acl(inode, type, acl);
1440 }
1441
---
0-DAY CI Kernel Test Service, Intel Corporation
https://protect2.fireeye.com/v1/url?k=00392011-
5fa2195f-0038ab5e-0cc47a31ba82-57be21795e39c517&q=1&e=84dd4df2-50a8-4e60-b1fd-
61659da165a2&u=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuil...