[kbuild-all] Re: [PATCH 04/15] wireless: align some HE capabilities with the spec

Friday, 9 April 2021

Hi Luca,

I love your patch! Yet something to improve:

[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master wireless-drivers-next/master
wireless-drivers/master v5.12-rc6 next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:   
https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80211-pa...
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        #
https://github.com/0day-ci/linux/commit/13582e33bee8630eb3f2d4299b14e989b...
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review
Luca-Coelho/cfg80211-mac80211-patches-from-our-internal-tree-2021-04-09/20210409-181210
        git checkout 13582e33bee8630eb3f2d4299b14e989bc06d297
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All errors (new ones prefixed by >>):

   drivers/net/wireless/ath/ath11k/mac.c: In function
'ath11k_mac_filter_he_cap_mesh':
...
> drivers/net/wireless/ath/ath11k/mac.c:3810:6: error:
'IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION' undeclared (first use in
this function); did you mean
'IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECTIVE_TRANSMISSION'?     3810 |  m =
IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION |
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |      IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECTIVE_TRANSMISSION
   drivers/net/wireless/ath/ath11k/mac.c:3810:6: note: each undeclared identifier is
reported only once for each function it appears in
...
> drivers/net/wireless/ath/ath11k/mac.c:3820:6: error:
'IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA' undeclared (first use in
this function)     3820 |  m = IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA
|
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
> drivers/net/wireless/ath/ath11k/mac.c:3832:6: error:
'IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB' undeclared (first use in this
function); did you mean 'IEEE80211_HE_PHY_CAP6_TRIG_SU_BEAMFORMING_FB'?    
3832 |      IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB |
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |      IEEE80211_HE_PHY_CAP6_TRIG_SU_BEAMFORMING_FB
...
> drivers/net/wireless/ath/ath11k/mac.c:3837:6: error:
'IEEE80211_HE_PHY_CAP7_SRP_BASED_SR' undeclared (first use in this function); did
you mean 'IEEE80211_HE_PHY_CAP7_PSR_BASED_SR'?     3837 |  m =
IEEE80211_HE_PHY_CAP7_SRP_BASED_SR |
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |      IEEE80211_HE_PHY_CAP7_PSR_BASED_SR
...
> drivers/net/wireless/ath/ath11k/mac.c:3838:6: error:
'IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR' undeclared (first use in this
function); did you mean 'IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_SUPP'?    
3838 |      IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR |
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |      IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_SUPP

vim +3810 drivers/net/wireless/ath/ath11k/mac.c

9f056ed8ee01ad John Crispin   2019-11-25  3786  
13591a1c3899cf Sven Eckelmann 2019-12-10  3787  static void
13591a1c3899cf Sven Eckelmann 2019-12-10  3788  ath11k_mac_filter_he_cap_mesh(struct
ieee80211_he_cap_elem *he_cap_elem)
13591a1c3899cf Sven Eckelmann 2019-12-10  3789  {
13591a1c3899cf Sven Eckelmann 2019-12-10  3790  	u8 m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3791  
13591a1c3899cf Sven Eckelmann 2019-12-10  3792  	m = IEEE80211_HE_MAC_CAP0_TWT_RES |
13591a1c3899cf Sven Eckelmann 2019-12-10  3793  	    IEEE80211_HE_MAC_CAP0_TWT_REQ;
13591a1c3899cf Sven Eckelmann 2019-12-10  3794  	he_cap_elem->mac_cap_info[0] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3795  
13591a1c3899cf Sven Eckelmann 2019-12-10  3796  	m = IEEE80211_HE_MAC_CAP2_TRS |
13591a1c3899cf Sven Eckelmann 2019-12-10  3797  	    IEEE80211_HE_MAC_CAP2_BCAST_TWT |
13591a1c3899cf Sven Eckelmann 2019-12-10  3798  	    IEEE80211_HE_MAC_CAP2_MU_CASCADING;
13591a1c3899cf Sven Eckelmann 2019-12-10  3799  	he_cap_elem->mac_cap_info[2] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3800  
13591a1c3899cf Sven Eckelmann 2019-12-10  3801  	m = IEEE80211_HE_MAC_CAP3_FLEX_TWT_SCHED
|
13591a1c3899cf Sven Eckelmann 2019-12-10  3802  	    IEEE80211_HE_MAC_CAP2_BCAST_TWT |
13591a1c3899cf Sven Eckelmann 2019-12-10  3803  	    IEEE80211_HE_MAC_CAP2_MU_CASCADING;
13591a1c3899cf Sven Eckelmann 2019-12-10  3804  	he_cap_elem->mac_cap_info[3] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3805  
13591a1c3899cf Sven Eckelmann 2019-12-10  3806  	m =
IEEE80211_HE_MAC_CAP4_BSRP_BQRP_A_MPDU_AGG |
13591a1c3899cf Sven Eckelmann 2019-12-10  3807  	    IEEE80211_HE_MAC_CAP4_BQR;
13591a1c3899cf Sven Eckelmann 2019-12-10  3808  	he_cap_elem->mac_cap_info[4] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3809  
13591a1c3899cf Sven Eckelmann 2019-12-10 @3810  	m =
IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION |
13591a1c3899cf Sven Eckelmann 2019-12-10  3811  	   
IEEE80211_HE_MAC_CAP5_UL_2x996_TONE_RU |
13591a1c3899cf Sven Eckelmann 2019-12-10  3812  	   
IEEE80211_HE_MAC_CAP5_PUNCTURED_SOUNDING |
13591a1c3899cf Sven Eckelmann 2019-12-10  3813  	   
IEEE80211_HE_MAC_CAP5_HT_VHT_TRIG_FRAME_RX;
13591a1c3899cf Sven Eckelmann 2019-12-10  3814  	he_cap_elem->mac_cap_info[5] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3815  
13591a1c3899cf Sven Eckelmann 2019-12-10  3816  	m =
IEEE80211_HE_PHY_CAP2_UL_MU_FULL_MU_MIMO |
13591a1c3899cf Sven Eckelmann 2019-12-10  3817  	   
IEEE80211_HE_PHY_CAP2_UL_MU_PARTIAL_MU_MIMO;
13591a1c3899cf Sven Eckelmann 2019-12-10  3818  	he_cap_elem->phy_cap_info[2] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3819  
13591a1c3899cf Sven Eckelmann 2019-12-10 @3820  	m =
IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA |
13591a1c3899cf Sven Eckelmann 2019-12-10  3821  	   
IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_TX_MASK |
13591a1c3899cf Sven Eckelmann 2019-12-10  3822  	   
IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_RX_MASK;
13591a1c3899cf Sven Eckelmann 2019-12-10  3823  	he_cap_elem->phy_cap_info[3] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3824  
13591a1c3899cf Sven Eckelmann 2019-12-10  3825  	m = IEEE80211_HE_PHY_CAP4_MU_BEAMFORMER;
13591a1c3899cf Sven Eckelmann 2019-12-10  3826  	he_cap_elem->phy_cap_info[4] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3827  
13591a1c3899cf Sven Eckelmann 2019-12-10  3828  	m =
IEEE80211_HE_PHY_CAP5_NG16_MU_FEEDBACK;
13591a1c3899cf Sven Eckelmann 2019-12-10  3829  	he_cap_elem->phy_cap_info[5] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3830  
13591a1c3899cf Sven Eckelmann 2019-12-10  3831  	m =
IEEE80211_HE_PHY_CAP6_CODEBOOK_SIZE_75_MU |
13591a1c3899cf Sven Eckelmann 2019-12-10 @3832  	   
IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB |
13591a1c3899cf Sven Eckelmann 2019-12-10  3833  	    IEEE80211_HE_PHY_CAP6_TRIG_CQI_FB |
13591a1c3899cf Sven Eckelmann 2019-12-10  3834  	   
IEEE80211_HE_PHY_CAP6_PARTIAL_BANDWIDTH_DL_MUMIMO;
13591a1c3899cf Sven Eckelmann 2019-12-10  3835  	he_cap_elem->phy_cap_info[6] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3836  
13591a1c3899cf Sven Eckelmann 2019-12-10 @3837  	m = IEEE80211_HE_PHY_CAP7_SRP_BASED_SR |
13591a1c3899cf Sven Eckelmann 2019-12-10 @3838  	   
IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR |
13591a1c3899cf Sven Eckelmann 2019-12-10  3839  	   
IEEE80211_HE_PHY_CAP7_STBC_TX_ABOVE_80MHZ |
13591a1c3899cf Sven Eckelmann 2019-12-10  3840  	   
IEEE80211_HE_PHY_CAP7_STBC_RX_ABOVE_80MHZ;
13591a1c3899cf Sven Eckelmann 2019-12-10  3841  	he_cap_elem->phy_cap_info[7] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3842  
13591a1c3899cf Sven Eckelmann 2019-12-10  3843  	m =
IEEE80211_HE_PHY_CAP8_HE_ER_SU_PPDU_4XLTF_AND_08_US_GI |
13591a1c3899cf Sven Eckelmann 2019-12-10  3844  	   
IEEE80211_HE_PHY_CAP8_20MHZ_IN_40MHZ_HE_PPDU_IN_2G |
13591a1c3899cf Sven Eckelmann 2019-12-10  3845  	   
IEEE80211_HE_PHY_CAP8_20MHZ_IN_160MHZ_HE_PPDU |
13591a1c3899cf Sven Eckelmann 2019-12-10  3846  	   
IEEE80211_HE_PHY_CAP8_80MHZ_IN_160MHZ_HE_PPDU;
13591a1c3899cf Sven Eckelmann 2019-12-10  3847  	he_cap_elem->phy_cap_info[8] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3848  
13591a1c3899cf Sven Eckelmann 2019-12-10  3849  	m =
IEEE80211_HE_PHY_CAP9_LONGER_THAN_16_SIGB_OFDM_SYM |
13591a1c3899cf Sven Eckelmann 2019-12-10  3850  	   
IEEE80211_HE_PHY_CAP9_NON_TRIGGERED_CQI_FEEDBACK |
13591a1c3899cf Sven Eckelmann 2019-12-10  3851  	   
IEEE80211_HE_PHY_CAP9_RX_1024_QAM_LESS_THAN_242_TONE_RU |
13591a1c3899cf Sven Eckelmann 2019-12-10  3852  	   
IEEE80211_HE_PHY_CAP9_TX_1024_QAM_LESS_THAN_242_TONE_RU |
13591a1c3899cf Sven Eckelmann 2019-12-10  3853  	   
IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_COMP_SIGB |
13591a1c3899cf Sven Eckelmann 2019-12-10  3854  	   
IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_NON_COMP_SIGB;
13591a1c3899cf Sven Eckelmann 2019-12-10  3855  	he_cap_elem->phy_cap_info[9] &=
~m;
13591a1c3899cf Sven Eckelmann 2019-12-10  3856  }
13591a1c3899cf Sven Eckelmann 2019-12-10  3857  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019

[kbuild-all] Re: [PATCH 04/15] wireless: align some HE capabilities with the spec