tree:
https://github.com/morimoto/linux fw-cleanup-2020-06-22-v1
head: da14a739a693d4ffaa9cf86098ba87926dd11f41
commit: ed7020086e44bfd970c39f92a1085a23985a4f89 [81/146] ASoC: soc-pcm: add
soc_create_pcm() and simplify soc_new_pcm()
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout ed7020086e44bfd970c39f92a1085a23985a4f89
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the morimoto-linux/fw-cleanup-2020-06-22-v1 HEAD
da14a739a693d4ffaa9cf86098ba87926dd11f41 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/pm_runtime.h:11,
from sound/soc/soc-pcm.c:17:
sound/soc/soc-pcm.c: In function 'soc_new_pcm':
> sound/soc/soc-pcm.c:2828:4: error: 'new_name' undeclared
(first use in this function); did you mean 'dev_name'?
2828 |
new_name, rtd->dai_link->name, ret);
| ^~~~~~~~
include/linux/dev_printk.h:104:32: note: in definition of macro 'dev_err'
104 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
sound/soc/soc-pcm.c:2828:4: note: each undeclared identifier is reported only once for
each function it appears in
2828 | new_name, rtd->dai_link->name, ret);
| ^~~~~~~~
include/linux/dev_printk.h:104:32: note: in definition of macro 'dev_err'
104 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
vim +2828 sound/soc/soc-pcm.c
ed7020086e44bf Kuninori Morimoto 2020-03-02 2749
ed7020086e44bf Kuninori Morimoto 2020-03-02 2750 /* create a new pcm */
ed7020086e44bf Kuninori Morimoto 2020-03-02 2751 int soc_new_pcm(struct
snd_soc_pcm_runtime *rtd, int num)
ed7020086e44bf Kuninori Morimoto 2020-03-02 2752 {
ed7020086e44bf Kuninori Morimoto 2020-03-02 2753 struct snd_soc_component
*component;
ed7020086e44bf Kuninori Morimoto 2020-03-02 2754 struct snd_pcm *pcm;
ed7020086e44bf Kuninori Morimoto 2020-03-02 2755 int ret = 0, playback = 0, capture
= 0;
ed7020086e44bf Kuninori Morimoto 2020-03-02 2756 int i;
ed7020086e44bf Kuninori Morimoto 2020-03-02 2757
ed7020086e44bf Kuninori Morimoto 2020-03-02 2758 ret = soc_get_playback_capture(rtd,
&playback, &capture);
ed7020086e44bf Kuninori Morimoto 2020-03-02 2759 if (ret < 0)
ed7020086e44bf Kuninori Morimoto 2020-03-02 2760 return ret;
ed7020086e44bf Kuninori Morimoto 2020-03-02 2761
ed7020086e44bf Kuninori Morimoto 2020-03-02 2762 ret = soc_create_pcm(&pcm, rtd,
playback, capture, num);
ed7020086e44bf Kuninori Morimoto 2020-03-02 2763 if (ret < 0)
ed7020086e44bf Kuninori Morimoto 2020-03-02 2764 return ret;
ed7020086e44bf Kuninori Morimoto 2020-03-02 2765
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2766 /* DAPM dai link stream work */
a342031cdd0818 Jerome Brunet 2019-07-25 2767 if (rtd->dai_link->params)
4bf2e385aa59c2 Curtis Malainey 2019-12-03 2768 rtd->close_delayed_work_func =
codec2codec_close_delayed_work;
a342031cdd0818 Jerome Brunet 2019-07-25 2769 else
83f94a2e293d61 Kuninori Morimoto 2020-01-10 2770 rtd->close_delayed_work_func =
snd_soc_close_delayed_work;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2771
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2772 rtd->pcm = pcm;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2773 pcm->private_data = rtd;
888a3f04d72859 Kuninori Morimoto 2020-01-22 2774 pcm->nonatomic =
rtd->dai_link->nonatomic;
888a3f04d72859 Kuninori Morimoto 2020-01-22 2775 pcm->no_device_suspend = true;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2776
a342031cdd0818 Jerome Brunet 2019-07-25 2777 if (rtd->dai_link->no_pcm ||
rtd->dai_link->params) {
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2778 if (playback)
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2779
pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream->private_data = rtd;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2780 if (capture)
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2781
pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream->private_data = rtd;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2782 goto out;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2783 }
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2784
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2785 /* ASoC PCM operations */
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2786 if (rtd->dai_link->dynamic)
{
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2787 rtd->ops.open =
dpcm_fe_dai_open;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2788 rtd->ops.hw_params =
dpcm_fe_dai_hw_params;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2789 rtd->ops.prepare =
dpcm_fe_dai_prepare;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2790 rtd->ops.trigger =
dpcm_fe_dai_trigger;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2791 rtd->ops.hw_free =
dpcm_fe_dai_hw_free;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2792 rtd->ops.close =
dpcm_fe_dai_close;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2793 rtd->ops.pointer =
soc_pcm_pointer;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2794 } else {
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2795 rtd->ops.open = soc_pcm_open;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2796 rtd->ops.hw_params =
soc_pcm_hw_params;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2797 rtd->ops.prepare =
soc_pcm_prepare;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2798 rtd->ops.trigger =
soc_pcm_trigger;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2799 rtd->ops.hw_free =
soc_pcm_hw_free;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2800 rtd->ops.close =
soc_pcm_close;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2801 rtd->ops.pointer =
soc_pcm_pointer;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2802 }
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2803
613fb50059cf19 Kuninori Morimoto 2020-01-10 2804 for_each_rtd_components(rtd, i,
component) {
2b544dd7b43b19 Kuninori Morimoto 2019-10-15 2805 const struct
snd_soc_component_driver *drv = component->driver;
b8135864d4d33d Kuninori Morimoto 2017-10-11 2806
3b1c952c951d5a Takashi Iwai 2019-11-21 2807 if (drv->ioctl)
3b1c952c951d5a Takashi Iwai 2019-11-21 2808 rtd->ops.ioctl =
snd_soc_pcm_component_ioctl;
1e5ddb6ba73894 Takashi Iwai 2019-11-21 2809 if (drv->sync_stop)
1e5ddb6ba73894 Takashi Iwai 2019-11-21 2810 rtd->ops.sync_stop =
snd_soc_pcm_component_sync_stop;
e9067bb5027878 Kuninori Morimoto 2019-10-02 2811 if (drv->copy_user)
82d81f5cced36e Kuninori Morimoto 2019-07-26 2812 rtd->ops.copy_user =
snd_soc_pcm_component_copy_user;
e9067bb5027878 Kuninori Morimoto 2019-10-02 2813 if (drv->page)
9c712e4f572290 Kuninori Morimoto 2019-07-26 2814 rtd->ops.page =
snd_soc_pcm_component_page;
e9067bb5027878 Kuninori Morimoto 2019-10-02 2815 if (drv->mmap)
205875e1a12ef9 Kuninori Morimoto 2019-07-26 2816 rtd->ops.mmap =
snd_soc_pcm_component_mmap;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2817 }
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2818
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2819 if (playback)
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2820 snd_pcm_set_ops(pcm,
SNDRV_PCM_STREAM_PLAYBACK, &rtd->ops);
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2821
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2822 if (capture)
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2823 snd_pcm_set_ops(pcm,
SNDRV_PCM_STREAM_CAPTURE, &rtd->ops);
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2824
b2b2afbb48eac7 Kuninori Morimoto 2019-11-18 2825 ret =
snd_soc_pcm_component_new(rtd);
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2826 if (ret < 0) {
799827a42045e7 Pierre-Louis Bossart 2020-06-12 2827 dev_err(rtd->dev, "ASoC:
pcm %s constructor failed for dailink %s: %d\n",
799827a42045e7 Pierre-Louis Bossart 2020-06-12 @2828 new_name,
rtd->dai_link->name, ret);
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2829 return ret;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2830 }
c641e5b207ed7d Johan Hovold 2017-07-12 2831
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2832 out:
1d5cd5254f67bc Pierre-Louis Bossart 2020-06-12 2833 dev_dbg(rtd->card->dev,
"%s <-> %s mapping ok\n",
c2233a266178f8 Kuninori Morimoto 2020-03-30 2834 (rtd->num_codecs > 1) ?
"multicodec" : asoc_rtd_to_codec(rtd, 0)->name,
c2233a266178f8 Kuninori Morimoto 2020-03-30 2835 (rtd->num_cpus > 1) ?
"multicpu" : asoc_rtd_to_cpu(rtd, 0)->name);
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2836 return ret;
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2837 }
01d7584cd2e5a9 Liam Girdwood 2012-04-25 2838
:::::: The code at line 2828 was first introduced by commit
:::::: 799827a42045e77a34bd4a90ba8bde372ed8058d ASoC: soc-pcm: improve error messages in
soc_pcm_new()
:::::: TO: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com>
:::::: CC: Mark Brown <broonie(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org