12:04 a.m.
Hi Xu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on v5.14 next-20210910]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Xu-Wang/blk-zoned-Remove-needles...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-a006-20210910 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
261cbe98c38f8c1ee1a482fe76511110e790f58a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/bc1beb73948b721209a36db7693ed7a62...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Xu-Wang/blk-zoned-Remove-needless-request_queue-NULL-pointer-checks/20210910-144721
git checkout bc1beb73948b721209a36db7693ed7a621037757
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
block/blk-zoned.c:349:28: error: implicit declaration of function
'dev_get_queue' [-Werror,-Wimplicit-function-declaration]
struct request_queue *q = dev_get_queue(bdev);
^
block/blk-zoned.c:349:28: note: did you mean 'bdev_get_queue'?
include/linux/blkdev.h:897:37: note: 'bdev_get_queue' declared here
static inline struct request_queue *bdev_get_queue(struct block_device *bdev)
^
> block/blk-zoned.c:349:24: warning: incompatible integer to
pointer conversion initializing 'struct request_queue *' with an expression of
type 'int' [-Wint-conversion]
struct request_queue *q =
dev_get_queue(bdev);
^ ~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
vim +349 block/blk-zoned.c
339
340 /*
341 * BLKREPORTZONE ioctl processing.
342 * Called from blkdev_ioctl.
343 */
344 int blkdev_report_zones_ioctl(struct block_device *bdev, fmode_t mode,
345 unsigned int cmd, unsigned long arg)
346 {
347 void __user *argp = (void __user *)arg;
348 struct zone_report_args args;
349 struct request_queue *q = dev_get_queue(bdev);
350 struct blk_zone_report rep;
351 int ret;
352
353 if (!argp)
354 return -EINVAL;
355
356 if (!blk_queue_is_zoned(q))
357 return -ENOTTY;
358
359 if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
360 return -EFAULT;
361
362 if (!rep.nr_zones)
363 return -EINVAL;
364
365 args.zones = argp + sizeof(struct blk_zone_report);
366 ret = blkdev_report_zones(bdev, rep.sector, rep.nr_zones,
367 blkdev_copy_zone_to_user, &args);
368 if (ret < 0)
369 return ret;
370
371 rep.nr_zones = ret;
372 rep.flags = BLK_ZONE_REP_CAPACITY;
373 if (copy_to_user(argp, &rep, sizeof(struct blk_zone_report)))
374 return -EFAULT;
375 return 0;
376 }
377
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org